MiniDigger/Hangar

View on GitHub
ore/app/discourse/OreDiscourseApiEnabled.scala

Summary

Maintainability
B
6 hrs
Test Coverage

Function createProjectTopic has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def createProjectTopic(project: Model[Project]): F[Model[Project]] = {
    val title = Templates.projectTitle(project)

    implicit val mdc: DiscourseMDC = DiscourseMDC(project.ownerName, None, title)

Severity: Minor
Found in ore/app/discourse/OreDiscourseApiEnabled.scala - About 1 hr to fix

    Function updateProjectTopic has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def updateProjectTopic(project: Model[Project]): F[Boolean] = {
        require(project.topicId.isDefined, "undefined topic id")
        require(project.postId.isDefined, "undefined post id")
    
        val topicId   = project.topicId
    Severity: Minor
    Found in ore/app/discourse/OreDiscourseApiEnabled.scala - About 1 hr to fix

      Constructor has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          api: DiscourseApi[F],
          categoryDefault: Int,
          categoryDeleted: Int,
          topicTemplatePath: Path,
          versionReleasePostTemplatePath: Path,
      Severity: Major
      Found in ore/app/discourse/OreDiscourseApiEnabled.scala - About 1 hr to fix

        Function updateVersionPost has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def updateVersionPost(project: Model[Project], version: Model[Version]): F[Boolean] = {
            require(project.topicId.isDefined, "undefined topic id")
            require(version.postId.isDefined, "undefined post id")
        
            val topicId   = project.topicId
        Severity: Minor
        Found in ore/app/discourse/OreDiscourseApiEnabled.scala - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              def logErrorsAs(error: String, as: Boolean): F[Boolean] = {
                val message =
                  s"""|Request to update project topic was successful but Discourse responded with errors:
                      |Project: ${project.url}
                      |Topic ID: $topicId
          Severity: Minor
          Found in ore/app/discourse/OreDiscourseApiEnabled.scala and 1 other location - About 30 mins to fix
          ore/app/discourse/OreDiscourseApiEnabled.scala on lines 143..152

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 62.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              def logErrorsAs(error: String, as: Boolean): F[Boolean] = {
                val message =
                  s"""|Request to update project topic was successful but Discourse responded with errors:
                      |Project: ${project.url}
                      |Topic ID: $topicId
          Severity: Minor
          Found in ore/app/discourse/OreDiscourseApiEnabled.scala and 1 other location - About 30 mins to fix
          ore/app/discourse/OreDiscourseApiEnabled.scala on lines 225..234

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 62.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status