Sign upLogin

MiniDigger/Hangar

View on GitHub
Star
ore/app/form/project/ProjectSettingsForm.scala

Summary

Maintainability
B
6 hrs
Test Coverage

Function save has 88 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  ): EitherT[F, String, (Model[Project], Model[ProjectSettings])] = {
    import cats.instances.vector._
    logger.debug("Saving project settings")
    logger.debug(this.toString)
    val newOwnerId = this.ownerId.getOrElse(project.ownerId)
Severity: Major
Found in ore/app/form/project/ProjectSettingsForm.scala - About 3 hrs to fix

    Constructor has 16 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        categoryName: String,
    homepage: String,
    issues: String,
    source: String,
    support: String,
    Severity: Major
    Found in ore/app/form/project/ProjectSettingsForm.scala - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                    val roles = this.roleUps.traverse { role =>
                Role.projectRoles
                  .find(_.value == role)
                  .fold(F.raiseError[Role](new RuntimeException("supplied invalid role type")))(F.pure)
              }
      Severity: Minor
      Found in ore/app/form/project/ProjectSettingsForm.scala and 1 other location - About 40 mins to fix
      ore/app/form/organization/OrganizationMembersUpdate.scala on lines 73..77

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  Notification(
              userId = role.userId,
              originId = Some(project.ownerId),
              notificationType = NotificationType.ProjectInvite,
              messageArgs = NonEmptyList.of("notification.project.invite", role.role.title, project.name)
      Severity: Minor
      Found in ore/app/form/project/ProjectSettingsForm.scala and 1 other location - About 30 mins to fix
      orePlayCommon/app/db/impl/access/OrganizationBase.scala on lines 128..133

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status