Sign upLogin

MiniDigger/Hangar

View on GitHub
Star
orePlayCommon/app/db/impl/access/ProjectBase.scala

Summary

Maintainability
A
2 hrs
Test Coverage

Constructor has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

      implicit service: ModelService[F],
      config: OreConfig,
      forums: OreDiscourseApi[F],
      fileManager: ProjectFiles,
      F: cats.effect.Effect[F],
Severity: Minor
Found in orePlayCommon/app/db/impl/access/ProjectBase.scala - About 45 mins to fix

    FIXME found
    Open

        * FIXME: Weird behavior
    Severity: Minor
    Found in orePlayCommon/app/db/impl/access/ProjectBase.scala by fixme

    TODO found
    Open

          // TODO: Instead, move to the "projects_deleted" table just in case we couldn't delete the topic
    Severity: Minor
    Found in orePlayCommon/app/db/impl/access/ProjectBase.scala by fixme

    TODO found
    Open

            projects <- service.runDBIO(proj.versions(ModelView.raw(Version)).sortBy(_.createdAt.desc).result) // TODO optimize: only query one version
    Severity: Minor
    Found in orePlayCommon/app/db/impl/access/ProjectBase.scala by fixme

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def withName(owner: String, name: String): OptionT[F, Model[Project]] =
      ModelView
        .now(Project)
        .find(p => p.ownerName.toLowerCase === owner.toLowerCase && p.name.toLowerCase === name.toLowerCase)
    Severity: Minor
    Found in orePlayCommon/app/db/impl/access/ProjectBase.scala and 1 other location - About 55 mins to fix
    orePlayCommon/app/db/impl/access/ProjectBase.scala on lines 182..185

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 87.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def withSlug(owner: String, slug: String): OptionT[F, Model[Project]] =
      ModelView
        .now(Project)
        .find(p => p.ownerName.toLowerCase === owner.toLowerCase && p.slug.toLowerCase === slug.toLowerCase)
    Severity: Minor
    Found in orePlayCommon/app/db/impl/access/ProjectBase.scala and 1 other location - About 55 mins to fix
    orePlayCommon/app/db/impl/access/ProjectBase.scala on lines 177..180

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 87.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status