Sign upLogin

MiniProfiler/rack-mini-profiler

View on GitHub
Star
lib/mini_profiler/timer_struct/request.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method initialize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def initialize(name, page, parent)
          start_millis = (Process.clock_gettime(Process::CLOCK_MONOTONIC) * 1000).to_i - page[:started]
          depth        = parent ? parent.depth + 1 : 0
          super(
            id: MiniProfiler.generate_id,
Severity: Minor
Found in lib/mini_profiler/timer_struct/request.rb - About 1 hr to fix

    Method add_sql has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def add_sql(query, elapsed_ms, page, params = nil, skip_backtrace = false, full_backtrace = false)
    Severity: Minor
    Found in lib/mini_profiler/timer_struct/request.rb - About 45 mins to fix

      Method move_custom has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

              def move_custom(type, custom, destination)
          if index = self[:custom_timings][type]&.index(custom)
            custom[:parent_timing_id] = destination[:id]
            custom.parent = destination
            self[:custom_timings][type].slice!(index)
      Severity: Minor
      Found in lib/mini_profiler/timer_struct/request.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status