Sign upLogin

MinnPost/object-sync-for-salesforce

View on GitHub
Star
classes/class-object-sync-sf-pull-options.php

Summary

Maintainability
C
1 day
Test Coverage

Method legacy_option_upgrade has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    private function legacy_option_upgrade( $operation, $object_type = '', $fieldmap_id = '', $value = '', $autoload = true ) {
Severity: Minor
Found in classes/class-object-sync-sf-pull-options.php - About 35 mins to fix

    Method set has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function set( $operation, $object_type = '', $fieldmap_id = '', $value = '', $autoload = false ) {
    Severity: Minor
    Found in classes/class-object-sync-sf-pull-options.php - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function set( $operation, $object_type = '', $fieldmap_id = '', $value = '', $autoload = false ) {
        // generate the option key parameters.
        $params = array(
            'operation'   => $operation,
            'object_type' => $object_type,
      Severity: Major
      Found in classes/class-object-sync-sf-pull-options.php and 1 other location - About 2 hrs to fix
      classes/class-object-sync-sf-sync-transients.php on lines 89..117

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 141.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private function legacy_option_upgrade( $operation, $object_type = '', $fieldmap_id = '', $value = '', $autoload = true ) {
        $result       = false;
        $legacy_value = $this->legacy_get( $operation, $object_type, $fieldmap_id );
        if ( false !== $legacy_value ) {
            // generate the option key parameters.
      Severity: Major
      Found in classes/class-object-sync-sf-pull-options.php and 1 other location - About 2 hrs to fix
      classes/class-object-sync-sf-sync-transients.php on lines 130..148

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 139.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          private function remove_upgradeable_key( $key ) {
        $keys      = $this->get_upgradeable_keys();
        $array_key = array_search( $key, $keys, true );
        if ( false !== $array_key ) {
            unset( $keys[ $array_key ] );
      Severity: Major
      Found in classes/class-object-sync-sf-pull-options.php and 1 other location - About 2 hrs to fix
      classes/class-object-sync-sf-sync-transients.php on lines 269..283

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 132.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          private function add_upgradeable_key( $key ) {
        $keys   = $this->get_upgradeable_keys();
        $keys[] = $key;
        $keys   = array_unique( $keys );
        $result = update_option( $this->option_prefix . 'upgradeable_keys', $keys );
      Severity: Minor
      Found in classes/class-object-sync-sf-pull-options.php and 1 other location - About 30 mins to fix
      classes/class-object-sync-sf-sync-transients.php on lines 251..260

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 90.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status