Sign upLogin

MinnPost/object-sync-for-salesforce

View on GitHub
Star
classes/class-object-sync-sf-rest.php

Summary

Maintainability
C
1 day
Test Coverage

Function can_process has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function can_process( WP_REST_Request $request ) {
        // unless we specify it here, the method will not be allowed unless the user has configure_salesforce capability.
        $http_method = $request->get_method();
        $class       = $request->get_url_params()['class'];
        switch ( $class ) {
Severity: Minor
Found in classes/class-object-sync-sf-rest.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method can_process has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function can_process( WP_REST_Request $request ) {
        // unless we specify it here, the method will not be allowed unless the user has configure_salesforce capability.
        $http_method = $request->get_method();
        $class       = $request->get_url_params()['class'];
        switch ( $class ) {
Severity: Minor
Found in classes/class-object-sync-sf-rest.php - About 1 hr to fix

    Function process has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public function process( WP_REST_Request $request ) {
        // see methods: https://developer.wordpress.org/reference/classes/wp_rest_request/
        // use error_log( 'request is ' . print_r( $request, true ) ); to log the request.
        $http_method = $request->get_method();
        $route       = $request->get_route();
    Severity: Minor
    Found in classes/class-object-sync-sf-rest.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method register_routes has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function register_routes() {
        $namespace   = $this->namespace;
        $method_list = WP_REST_Server::ALLMETHODS;
        register_rest_route(
            $namespace,
    Severity: Minor
    Found in classes/class-object-sync-sf-rest.php - About 1 hr to fix

      Method process has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function process( WP_REST_Request $request ) {
        // see methods: https://developer.wordpress.org/reference/classes/wp_rest_request/
        // use error_log( 'request is ' . print_r( $request, true ) ); to log the request.
        $http_method = $request->get_method();
        $route       = $request->get_route();
      Severity: Minor
      Found in classes/class-object-sync-sf-rest.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                return true;
        Severity: Major
        Found in classes/class-object-sync-sf-rest.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                              return new WP_Error( 'rest_forbidden', esc_html__( 'You do not have permissions to view this data.', 'object-sync-for-salesforce' ), array( 'status' => 401 ) );
          Severity: Major
          Found in classes/class-object-sync-sf-rest.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                return new WP_Error( 'rest_forbidden', esc_html__( 'This kind of request is not allowed.', 'object-sync-for-salesforce' ), array( 'status' => 401 ) );
            Severity: Major
            Found in classes/class-object-sync-sf-rest.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                  return new WP_Error( 'rest_forbidden', esc_html__( 'This kind of request is not allowed.', 'object-sync-for-salesforce' ), array( 'status' => 401 ) );
              Severity: Major
              Found in classes/class-object-sync-sf-rest.php - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            case 'mappings':
                if ( ! in_array( $http_method, explode( ',', WP_REST_Server::ALLMETHODS ), true ) ) {
                    return new WP_Error( 'rest_forbidden', esc_html__( 'This kind of request is not allowed.', 'object-sync-for-salesforce' ), array( 'status' => 401 ) );
                }
                if ( ! current_user_can( 'configure_salesforce' ) ) {
                Severity: Major
                Found in classes/class-object-sync-sf-rest.php and 1 other location - About 1 hr to fix
                classes/class-object-sync-sf-rest.php on lines 203..210

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 119.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            case 'salesforce':
                if ( ! in_array( $http_method, explode( ',', WP_REST_Server::ALLMETHODS ), true ) ) {
                    return new WP_Error( 'rest_forbidden', esc_html__( 'This kind of request is not allowed.', 'object-sync-for-salesforce' ), array( 'status' => 401 ) );
                }
                if ( ! current_user_can( 'configure_salesforce' ) ) {
                Severity: Major
                Found in classes/class-object-sync-sf-rest.php and 1 other location - About 1 hr to fix
                classes/class-object-sync-sf-rest.php on lines 211..218

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 119.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status