Sign upLogin

MinnPost/object-sync-for-salesforce

View on GitHub
Star
classes/class-object-sync-sf-salesforce-push.php

Summary

Maintainability
F
1 wk
Test Coverage

Method salesforce_push_sync_rest has 490 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function salesforce_push_sync_rest( $object_type, $object, $mapping, $sf_sync_trigger ) {

        // when using async, this task receives the WordPress object id value as an integer. otherwise, it receives the WordPress object data as an array.
        if ( is_int( $object ) ) {
            $wordpress_id = $object;
Severity: Major
Found in classes/class-object-sync-sf-salesforce-push.php - About 2 days to fix

    File class-object-sync-sf-salesforce-push.php has 965 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Push data from WordPress into Salesforce
 *
 * @class   Object_Sync_Sf_Salesforce_Push
    Severity: Major
    Found in classes/class-object-sync-sf-salesforce-push.php - About 2 days to fix

      Function salesforce_push_sync_rest has a Cognitive Complexity of 98 (exceeds 5 allowed). Consider refactoring.
      Open

          public function salesforce_push_sync_rest( $object_type, $object, $mapping, $sf_sync_trigger ) {

        // when using async, this task receives the WordPress object id value as an integer. otherwise, it receives the WordPress object data as an array.
        if ( is_int( $object ) ) {
            $wordpress_id = $object;
      Severity: Minor
      Found in classes/class-object-sync-sf-salesforce-push.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function salesforce_push_object_crud has a Cognitive Complexity of 83 (exceeds 5 allowed). Consider refactoring.
      Open

          private function salesforce_push_object_crud( $object_type, $object, $sf_sync_trigger, $manual = false ) {

        $structure               = $this->wordpress->get_wordpress_table_structure( $object_type );
        $wordpress_id_field_name = $structure['id_field'];
      Severity: Minor
      Found in classes/class-object-sync-sf-salesforce-push.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method salesforce_push_object_crud has 186 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function salesforce_push_object_crud( $object_type, $object, $sf_sync_trigger, $manual = false ) {

        $structure               = $this->wordpress->get_wordpress_table_structure( $object_type );
        $wordpress_id_field_name = $structure['id_field'];
      Severity: Major
      Found in classes/class-object-sync-sf-salesforce-push.php - About 7 hrs to fix

        Function add_actions has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
        Open

            public function add_actions() {
        $db_version = get_option( $this->option_prefix . 'db_version', false );
        if ( $db_version === $this->version ) {
            foreach ( $this->mappings->get_fieldmaps( null, $this->mappings->active_fieldmap_conditions ) as $mapping ) {
                $object_type = $mapping['wordpress_object'];
        Severity: Minor
        Found in classes/class-object-sync-sf-salesforce-push.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Object_Sync_Sf_Salesforce_Push has 26 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class Object_Sync_Sf_Salesforce_Push {

    /**
     * Current version of the plugin
     *
        Severity: Minor
        Found in classes/class-object-sync-sf-salesforce-push.php - About 3 hrs to fix

          Function manual_push has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
          Open

              public function manual_push( $object_type, $wordpress_id, $http_method ) {
        $object = $this->wordpress->get_wordpress_object_data( $object_type, $wordpress_id );
        // run the WordPress trigger that corresponds to the HTTP method.
        switch ( $http_method ) {
            case 'POST':
          Severity: Minor
          Found in classes/class-object-sync-sf-salesforce-push.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function post_actions has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

              public function post_actions( $post_id, $post ) {

        // if this runs on a non-object due to another operation, don't continue.
        if ( ! is_object( $post ) ) {
            return;
          Severity: Minor
          Found in classes/class-object-sync-sf-salesforce-push.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method post_actions has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function post_actions( $post_id, $post ) {

        // if this runs on a non-object due to another operation, don't continue.
        if ( ! is_object( $post ) ) {
            return;
          Severity: Minor
          Found in classes/class-object-sync-sf-salesforce-push.php - About 1 hr to fix

            Method add_actions has 38 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function add_actions() {
        $db_version = get_option( $this->option_prefix . 'db_version', false );
        if ( $db_version === $this->version ) {
            foreach ( $this->mappings->get_fieldmaps( null, $this->mappings->active_fieldmap_conditions ) as $mapping ) {
                $object_type = $mapping['wordpress_object'];
            Severity: Minor
            Found in classes/class-object-sync-sf-salesforce-push.php - About 1 hr to fix

              Method manual_push has 34 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function manual_push( $object_type, $wordpress_id, $http_method ) {
        $object = $this->wordpress->get_wordpress_object_data( $object_type, $wordpress_id );
        // run the WordPress trigger that corresponds to the HTTP method.
        switch ( $http_method ) {
            case 'POST':
              Severity: Minor
              Found in classes/class-object-sync-sf-salesforce-push.php - About 1 hr to fix

                Consider simplifying this complex logical expression.
                Open

                            if ( ( ! isset( $mapping['push_drafts'] ) || '1' !== $mapping['push_drafts'] ) && isset( $object['post_status'] ) && ( 'draft' === $object['post_status'] || ( 'inherit' === $object['post_status'] && 'attachment' !== $object['post_type'] ) ) ) {
                // skip this object if it is a draft and the fieldmap settings told us to ignore it.
                continue;
            }
                Severity: Major
                Found in classes/class-object-sync-sf-salesforce-push.php - About 40 mins to fix

                  Method create_object_map has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      private function create_object_map( $wordpress_object, $id_field_name, $salesforce_id, $field_mapping, $pending = false ) {
                  Severity: Minor
                  Found in classes/class-object-sync-sf-salesforce-push.php - About 35 mins to fix

                    Method is_push_allowed has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        private function is_push_allowed( $object_type, $object, $sf_sync_trigger, $mapping, $map_sync_triggers ) {
                    Severity: Minor
                    Found in classes/class-object-sync-sf-salesforce-push.php - About 35 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                      return $result;
                      Severity: Major
                      Found in classes/class-object-sync-sf-salesforce-push.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                        return $result;
                        Severity: Major
                        Found in classes/class-object-sync-sf-salesforce-push.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                  return $result;
                          Severity: Major
                          Found in classes/class-object-sync-sf-salesforce-push.php - About 30 mins to fix

                            Function is_push_allowed has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                                private function is_push_allowed( $object_type, $object, $sf_sync_trigger, $mapping, $map_sync_triggers ) {

        // default is push is allowed.
        $push_allowed = true;
                            Severity: Minor
                            Found in classes/class-object-sync-sf-salesforce-push.php - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                            if ( 1 === $salesforce_pulling ) {
                    // if it is pulling, delete the transient and continue on through the loop.
                    // we need to either do this for every individual mapping object, or only do it when all the mapping objects are done.
                            $transients_to_delete[ $fieldmap_key ]['transients'][] = $mapping_object_id_transient;
                    if ( true === $this->debug ) {
                            Severity: Major
                            Found in classes/class-object-sync-sf-salesforce-push.php and 1 other location - About 2 hrs to fix
                            classes/class-object-sync-sf-salesforce-pull.php on lines 1380..1402

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 136.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                    foreach ( $transients_to_delete as $key => $value ) {
            $fieldmap_id = $value['fieldmap']['id'];
            $transients  = (array) $value['transients'];
            foreach ( $transients as $transient_end ) {
                $this->sync_transients->delete( 'salesforce_pulling_' . $transient_end, '', $fieldmap_id );
                            Severity: Major
                            Found in classes/class-object-sync-sf-salesforce-push.php and 1 other location - About 2 hrs to fix
                            classes/class-object-sync-sf-salesforce-pull.php on lines 1535..1545

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 122.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 5 locations. Consider refactoring.
                            Open

                                            $title  = sprintf(
                    // translators: placeholders are: 1) the log status, 2) what operation is happening, 3) the name of the Salesforce object, 4) the Salesforce Id value, 5) the name of the WordPress object type, 6) the WordPress id field name, 7) the WordPress object id value.
                    esc_html__( '%1$s: %2$s Salesforce %3$s %4$s (WordPress %5$s with %6$s of %7$s)', 'object-sync-for-salesforce' ),
                    ucfirst( esc_attr( $status ) ),
                    esc_attr( $op ),
                            Severity: Major
                            Found in classes/class-object-sync-sf-salesforce-push.php and 4 other locations - About 1 hr to fix
                            classes/class-object-sync-sf-salesforce-push.php on lines 872..882
                            classes/class-object-sync-sf-salesforce-push.php on lines 905..915
                            classes/class-object-sync-sf-salesforce-push.php on lines 940..950
                            classes/class-object-sync-sf-salesforce-push.php on lines 1417..1427

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 119.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 5 locations. Consider refactoring.
                            Open

                                                    $title = sprintf(
                            // translators: placeholders are: 1) the log status, 2) what operation is happening, 3) the name of the Salesforce object, 4) the Salesforce Id value, 5) the name of the WordPress object type, 6) the WordPress id field name, 7) the WordPress object id value.
                            esc_html__( '%1$s: %2$s Salesforce %3$s %4$s (WordPress %5$s with %6$s of %7$s)', 'object-sync-for-salesforce' ),
                            ucfirst( esc_attr( $status ) ),
                            esc_attr( $op ),
                            Severity: Major
                            Found in classes/class-object-sync-sf-salesforce-push.php and 4 other locations - About 1 hr to fix
                            classes/class-object-sync-sf-salesforce-push.php on lines 905..915
                            classes/class-object-sync-sf-salesforce-push.php on lines 940..950
                            classes/class-object-sync-sf-salesforce-push.php on lines 1391..1401
                            classes/class-object-sync-sf-salesforce-push.php on lines 1417..1427

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 119.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 5 locations. Consider refactoring.
                            Open

                                                $title  = sprintf(
                        // translators: placeholders are: 1) the log status, 2) what operation is happening, 3) the name of the Salesforce object, 4) the Salesforce Id value, 5) the name of the WordPress object type, 6) the WordPress id field name, 7) the WordPress object id value.
                        esc_html__( '%1$s: %2$s on Salesforce %3$s with Id of %4$s was stopped because there are other Salesforce records mapped to WordPress %5$s with %6$s of %7$s', 'object-sync-for-salesforce' ),
                        ucfirst( esc_attr( $status ) ),
                        esc_attr( $op ),
                            Severity: Major
                            Found in classes/class-object-sync-sf-salesforce-push.php and 4 other locations - About 1 hr to fix
                            classes/class-object-sync-sf-salesforce-push.php on lines 872..882
                            classes/class-object-sync-sf-salesforce-push.php on lines 905..915
                            classes/class-object-sync-sf-salesforce-push.php on lines 1391..1401
                            classes/class-object-sync-sf-salesforce-push.php on lines 1417..1427

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 119.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 5 locations. Consider refactoring.
                            Open

                                            $title  = sprintf(
                    // translators: placeholders are: 1) the log status, 2) what operation is happening, 3) the name of the Salesforce object, 4) the Salesforce Id value, 5) the name of the WordPress object type, 6) the WordPress id field name, 7) the WordPress object id value.
                    esc_html__( '%1$s: %2$s Salesforce %3$s %4$s (WordPress %5$s with %6$s of %7$s)', 'object-sync-for-salesforce' ),
                    ucfirst( esc_attr( $status ) ),
                    esc_attr( $op ),
                            Severity: Major
                            Found in classes/class-object-sync-sf-salesforce-push.php and 4 other locations - About 1 hr to fix
                            classes/class-object-sync-sf-salesforce-push.php on lines 872..882
                            classes/class-object-sync-sf-salesforce-push.php on lines 905..915
                            classes/class-object-sync-sf-salesforce-push.php on lines 940..950
                            classes/class-object-sync-sf-salesforce-push.php on lines 1391..1401

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 119.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 5 locations. Consider refactoring.
                            Open

                                                    $title  = sprintf(
                            // translators: placeholders are: 1) the log status, 2) what operation is happening, 3) the name of the Salesforce object, 4) the Salesforce Id value, 5) the name of the WordPress object type, 6) the WordPress id field name, 7) the WordPress object id value.
                            esc_html__( '%1$s: %2$s Salesforce %3$s %4$s (WordPress %5$s with %6$s of %7$s)', 'object-sync-for-salesforce' ),
                            ucfirst( esc_attr( $status ) ),
                            esc_attr( $op ),
                            Severity: Major
                            Found in classes/class-object-sync-sf-salesforce-push.php and 4 other locations - About 1 hr to fix
                            classes/class-object-sync-sf-salesforce-push.php on lines 872..882
                            classes/class-object-sync-sf-salesforce-push.php on lines 940..950
                            classes/class-object-sync-sf-salesforce-push.php on lines 1391..1401
                            classes/class-object-sync-sf-salesforce-push.php on lines 1417..1427

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 119.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status