Sign upLogin

MiraitSystems/enju_trunk

View on GitHub
Star
app/controllers/library_reports_controller.rb

Summary

Maintainability
C
1 day
Test Coverage

Method monthly_report has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def monthly_report
    yyyymm = params[:library_report][:yyyymm]
    library_ids = params[:library]
    begin
      report = EnjuTrunk.new_report('monthly_library_report.tlf')
Severity: Major
Found in app/controllers/library_reports_controller.rb - About 2 hrs to fix

    Method daily_report has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def daily_report
   @library_reports = LibraryReport.where(:id => params[:id]) rescue nil
   yyyymmdd = @library_reports[0].yyyymmdd.to_s unless @library_reports.empty?
   yyyymmdd = params[:library_report][:yyyymmdd].to_s if params[:library_report] && params[:library_report][:yyyymmdd]
   library_ids = params[:library]
    Severity: Major
    Found in app/controllers/library_reports_controller.rb - About 2 hrs to fix

      Method index has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def index
    @count = {}
    search = Sunspot.new_search(LibraryReport)
    if params[:yyyymm]
      @yyyymm = params[:yyyymm]
      Severity: Minor
      Found in app/controllers/library_reports_controller.rb - About 1 hr to fix

        Method monthly_report has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

          def monthly_report
    yyyymm = params[:library_report][:yyyymm]
    library_ids = params[:library]
    begin
      report = EnjuTrunk.new_report('monthly_library_report.tlf')
        Severity: Minor
        Found in app/controllers/library_reports_controller.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method index has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

          def index
    @count = {}
    search = Sunspot.new_search(LibraryReport)
    if params[:yyyymm]
      @yyyymm = params[:yyyymm]
        Severity: Minor
        Found in app/controllers/library_reports_controller.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method daily_report has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def daily_report
   @library_reports = LibraryReport.where(:id => params[:id]) rescue nil
   yyyymmdd = @library_reports[0].yyyymmdd.to_s unless @library_reports.empty?
   yyyymmdd = params[:library_report][:yyyymmdd].to_s if params[:library_report] && params[:library_report][:yyyymmdd]
   library_ids = params[:library]
        Severity: Minor
        Found in app/controllers/library_reports_controller.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def create
    @library_report = LibraryReport.new(params[:library_report])

    respond_to do |format|
      if @library_report.save
        Severity: Major
        Found in app/controllers/library_reports_controller.rb and 1 other location - About 1 hr to fix
        app/controllers/item_has_use_restrictions_controller.rb on lines 48..59

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 61.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status