Sign upLogin

MiraitSystems/enju_trunk

View on GitHub
Star
app/controllers/purchase_requests_controller.rb

Summary

Maintainability
D
2 days
Test Coverage

Method index has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
Open

  def index
    unless can_use_purchase_request?
      access_denied; return
    else
      if !user_signed_in?
Severity: Minor
Found in app/controllers/purchase_requests_controller.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  def update
    check_can_access_purchase_request

    if @user
      @purchase_request = @user.purchase_requests.find(params[:id])
Severity: Minor
Found in app/controllers/purchase_requests_controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method index has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def index
    unless can_use_purchase_request?
      access_denied; return
    else
      if !user_signed_in?
Severity: Major
Found in app/controllers/purchase_requests_controller.rb - About 2 hrs to fix

    Method create has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      def create
    unless can_use_purchase_request?
      access_denied; return
    end
    Severity: Minor
    Found in app/controllers/purchase_requests_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method destroy has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      def destroy
    unless can_use_purchase_request?
      access_denied; return
    else
      if !user_signed_in?
    Severity: Minor
    Found in app/controllers/purchase_requests_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check_can_access_purchase_request has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def check_can_access_purchase_request
    unless can_use_purchase_request?
      access_denied; return
    else
      unless user_signed_in?
    Severity: Minor
    Found in app/controllers/purchase_requests_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method update has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def update
    check_can_access_purchase_request

    if @user
      @purchase_request = @user.purchase_requests.find(params[:id])
    Severity: Minor
    Found in app/controllers/purchase_requests_controller.rb - About 1 hr to fix

      Method create has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def create
    unless can_use_purchase_request?
      access_denied; return
    end
      Severity: Minor
      Found in app/controllers/purchase_requests_controller.rb - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                  unless current_user == @user
            access_denied; return
          end
        Severity: Major
        Found in app/controllers/purchase_requests_controller.rb - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def reject
    check_can_access_purchase_request

    if @purchase_request.sm_reject
      @purchase_request.send_message(@purchase_request.state)
          Severity: Minor
          Found in app/controllers/purchase_requests_controller.rb and 1 other location - About 30 mins to fix
          app/controllers/purchase_requests_controller.rb on lines 193..206

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def accept
    check_can_access_purchase_request

    if @purchase_request.sm_accept
      @purchase_request.send_message(@purchase_request.state)
          Severity: Minor
          Found in app/controllers/purchase_requests_controller.rb and 1 other location - About 30 mins to fix
          app/controllers/purchase_requests_controller.rb on lines 210..223

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status