Sign upLogin

MiraitSystems/enju_trunk

View on GitHub
Star
app/models/abbreviation.rb

Summary

Maintainability
C
1 day
Test Coverage

Method val_v has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  def val_v
    # 先頭に数字が混ざる可能性があるため、検証する開始文字位置を定める
    string_location = 0
    v.split("").each do |spelling|
      if string_location == 0 then
Severity: Minor
Found in app/models/abbreviation.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_abbreviation has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  def self.get_abbreviation(bookname)
    # 当モデルのチェックメソッドを使用するため、レシーバのインスタンスを生成する
    abbreviation_res = Abbreviation.new

    merge_v = ""
Severity: Minor
Found in app/models/abbreviation.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method val_keyword has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  def val_keyword
    # 先頭に数字が混ざる可能性があるため、検証する開始文字位置を定める
    string_location = 0
    keyword.split("").each do |spelling|
      if string_location == 0 then
Severity: Minor
Found in app/models/abbreviation.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_abbreviation has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.get_abbreviation(bookname)
    # 当モデルのチェックメソッドを使用するため、レシーバのインスタンスを生成する
    abbreviation_res = Abbreviation.new

    merge_v = ""
Severity: Minor
Found in app/models/abbreviation.rb - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

        errors.add(:v) unless
    (check_first_big?(v) or
     check_first_numeric?(v)) and
    ((v.length == 1) or
     (string_location == 0) or
    Severity: Major
    Found in app/models/abbreviation.rb - About 1 hr to fix

      Method check_hankaku? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def check_hankaku?(str)
    str.split("").each do |spelling|
      # 半角小文字か
      if check_hankaku_small_string?(spelling) then
        next
      Severity: Minor
      Found in app/models/abbreviation.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          keyword.split("").each do |spelling|
      if string_location == 0 then
        string_location += 1
      elsif check_first_numeric?(keyword) and
            check_first_numeric?(spelling) then
      Severity: Minor
      Found in app/models/abbreviation.rb and 1 other location - About 30 mins to fix
      app/models/abbreviation.rb on lines 41..52

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          v.split("").each do |spelling|
      if string_location == 0 then
        string_location += 1
      elsif check_first_numeric?(v) and
            check_first_numeric?(spelling) then
      Severity: Minor
      Found in app/models/abbreviation.rb and 1 other location - About 30 mins to fix
      app/models/abbreviation.rb on lines 15..26

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status