Sign upLogin

MiraitSystems/enju_trunk

View on GitHub
Star
app/models/approval.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method check_status has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  def check_status
    if self.all_process_start_at

      if self.all_process_end_at
        self.set_all_process_end
Severity: Minor
Found in app/models/approval.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_status has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def check_status
    if self.all_process_start_at

      if self.all_process_end_at
        self.set_all_process_end
Severity: Minor
Found in app/models/approval.rb - About 1 hr to fix

    Method ouput_columns has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.ouput_columns
    return [{name:"approval_identifier"},
            {name:"identifier"},
            {name:"original_title"},
            {name:"four_priority_areas"},
    Severity: Minor
    Found in app/models/approval.rb - About 1 hr to fix

      Method validate_identifier has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def validate_identifier
    return if self.manifestation_id

    if self.identifier.blank?
    errors.add(I18n.t('activerecord.attributes.manifestation.identifier'), I18n.t('approval.no_blank_identifier'))
      Severity: Minor
      Found in app/models/approval.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status