Sign upLogin

MiraitSystems/enju_trunk

View on GitHub
Star
app/models/order_list.rb

Summary

Maintainability
D
1 day
Test Coverage

Method generate_non_arrival_list has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def self.generate_non_arrival_list(start_at, end_at)
    # generate order list
    logger.debug "self.generate_non_arrival_list start_at=#{start_at} end_at=#{end_at}"

    order_lists = OrderList.where(:ordered_at => start_at.beginning_of_day..end_at.end_of_day)
Severity: Minor
Found in app/models/order_list.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method generate_non_arrival_list has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.generate_non_arrival_list(start_at, end_at)
    # generate order list
    logger.debug "self.generate_non_arrival_list start_at=#{start_at} end_at=#{end_at}"

    order_lists = OrderList.where(:ordered_at => start_at.beginning_of_day..end_at.end_of_day)
Severity: Major
Found in app/models/order_list.rb - About 2 hrs to fix

    File order_list.rb has 253 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class OrderList < ActiveRecord::Base
  include ItemsHelper

  scope :not_ordered, where(:state => 'pending')
    Severity: Minor
    Found in app/models/order_list.rb - About 2 hrs to fix

      Method generate_order_list has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def self.generate_order_list(start_at, end_at)
    # generate order list
    logger.debug "self.generate_order_list start_at=#{start_at} end_at=#{end_at}"

    order_lists = OrderList.where(:ordered_at => start_at.beginning_of_day..end_at.end_of_day)
      Severity: Minor
      Found in app/models/order_list.rb - About 2 hrs to fix

        Method do_order has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def do_order(letter_file_only = false)
    # generate order file
    order_file_dir = File.join(Rails.root.to_s, 'private', 'system', 'order_letter', "#{self.id}")
    order_file_path = File.join(order_file_dir, "order_letter_#{Time.now.strftime("%Y%m%d")}")
    FileUtils.mkdir_p(order_file_dir)
        Severity: Minor
        Found in app/models/order_list.rb - About 1 hr to fix

          Method generate_order_list has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

            def self.generate_order_list(start_at, end_at)
    # generate order list
    logger.debug "self.generate_order_list start_at=#{start_at} end_at=#{end_at}"

    order_lists = OrderList.where(:ordered_at => start_at.beginning_of_day..end_at.end_of_day)
          Severity: Minor
          Found in app/models/order_list.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method change_state_on_order has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def change_state_on_order
    ordered_state = CirculationStatus.where(name: "On Ordered").first

    if ordered_state
      if self.orders
          Severity: Minor
          Found in app/models/order_list.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method do_order has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def do_order(letter_file_only = false)
    # generate order file
    order_file_dir = File.join(Rails.root.to_s, 'private', 'system', 'order_letter', "#{self.id}")
    order_file_path = File.join(order_file_dir, "order_letter_#{Time.now.strftime("%Y%m%d")}")
    FileUtils.mkdir_p(order_file_dir)
          Severity: Minor
          Found in app/models/order_list.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      if o.item && o.item.manifestation
              original_title_string = o.item.manifestation.original_title
              creators_string = o.item.manifestation.creators.pluck(:full_name).first
              publishers_string = o.item.manifestation.publishers.pluck(:full_name).first
              isbn_string = o.item.manifestation.isbn
          Severity: Minor
          Found in app/models/order_list.rb and 1 other location - About 35 mins to fix
          app/models/order_list.rb on lines 98..103

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 34.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      if o.item && o.item.manifestation
              original_title_string = o.item.manifestation.original_title
              creators_string = o.item.manifestation.creators.pluck(:full_name).first
              publishers_string = o.item.manifestation.publishers.pluck(:full_name).first
              isbn_string = o.item.manifestation.isbn
          Severity: Minor
          Found in app/models/order_list.rb and 1 other location - About 35 mins to fix
          app/models/order_list.rb on lines 164..169

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 34.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status