Sign upLogin

MiraitSystems/enju_trunk

View on GitHub
Star
app/models/purchase_request.rb

Summary

Maintainability
C
1 day
Test Coverage

Method send_message has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

  def send_message(status, reason = nil)
    system_user = User.find(1) # TODO: システムからのメッセージの発信者
    PurchaseRequest.transaction do
      case status
      when 'accepted'
Severity: Minor
Found in app/models/purchase_request.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_purchase_requests_tsv has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.get_purchase_requests_tsv(purchase_requests)
    data = String.new
    data << "\xEF\xBB\xBF".force_encoding("UTF-8") + "\n"
    columns = [
      [:original_title, 'activerecord.attributes.manifestation.original_title'],
Severity: Minor
Found in app/models/purchase_request.rb - About 1 hr to fix

    Method send_message has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def send_message(status, reason = nil)
    system_user = User.find(1) # TODO: システムからのメッセージの発信者
    PurchaseRequest.transaction do
      case status
      when 'accepted'
    Severity: Minor
    Found in app/models/purchase_request.rb - About 1 hr to fix

      Method get_purchase_requests_tsv has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.get_purchase_requests_tsv(purchase_requests)
    data = String.new
    data << "\xEF\xBB\xBF".force_encoding("UTF-8") + "\n"
    columns = [
      [:original_title, 'activerecord.attributes.manifestation.original_title'],
      Severity: Minor
      Found in app/models/purchase_request.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method set_date_of_publication has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def set_date_of_publication
    return if pub_date.blank?
    begin
      date = Time.zone.parse("#{pub_date}")
    rescue ArgumentError
      Severity: Minor
      Found in app/models/purchase_request.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status