Sign upLogin

MiraitSystems/enju_trunk

View on GitHub
Star
app/models/resource_import_textresult.rb

Summary

Maintainability
D
2 days
Test Coverage

Method get_resource_import_textresults_excelx has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

  def self.get_resource_import_textresults_excelx(resource_import_textresults)
    # initialize
    out_dir = "#{Rails.root}/private/system/manifestations_list_excelx"
    excel_filepath = "#{out_dir}/list#{Time.now.strftime('%s')}#{rand(10)}.xlsx"
    FileUtils.mkdir_p(out_dir) unless FileTest.exist?(out_dir)
Severity: Minor
Found in app/models/resource_import_textresult.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_resource_import_textresults_tsv_csv has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

  def self.get_resource_import_textresults_tsv_csv(resource_import_textresults)
    split = SystemConfiguration.get("set_output_format_type") ? "\t" : ","
    before_sheet_name = nil
    data = String.new
    data << "\xEF\xBB\xBF".force_encoding("UTF-8")
Severity: Minor
Found in app/models/resource_import_textresult.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method delete_article has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

  def self.delete_article(result)
    item = Item.find(result.item_id) rescue nil
    if item
      if item.manifestation.article?
        if item.reserve
Severity: Minor
Found in app/models/resource_import_textresult.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method read_wrong_sheet has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def self.read_wrong_sheet(extraparams, options = { sheet: nil, default_style: nil, data: nil })
    oo = Excelx.new(eval(extraparams)['filename'])
    sheet_name = eval(extraparams)['sheet'] rescue nil
    oo.default_sheet = sheet_name
    begin
Severity: Minor
Found in app/models/resource_import_textresult.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_resource_import_textresults_excelx has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.get_resource_import_textresults_excelx(resource_import_textresults)
    # initialize
    out_dir = "#{Rails.root}/private/system/manifestations_list_excelx"
    excel_filepath = "#{out_dir}/list#{Time.now.strftime('%s')}#{rand(10)}.xlsx"
    FileUtils.mkdir_p(out_dir) unless FileTest.exist?(out_dir)
Severity: Minor
Found in app/models/resource_import_textresult.rb - About 1 hr to fix

    Method read_wrong_sheet has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.read_wrong_sheet(extraparams, options = { sheet: nil, default_style: nil, data: nil })
    oo = Excelx.new(eval(extraparams)['filename'])
    sheet_name = eval(extraparams)['sheet'] rescue nil
    oo.default_sheet = sheet_name
    begin
    Severity: Minor
    Found in app/models/resource_import_textresult.rb - About 1 hr to fix

      Method read_wrong_format has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.read_wrong_format(filename, options = { sheet: nil, default_style: nil, data: nil })
    split = SystemConfiguration.get('set_output_format_type') ? "\t" : ","
    #file = Tsvfile_Adapter.new.open_import_file(filename)
    tempfile = Tempfile.new('resource_import_file')
    if Setting.uploaded_file.storage == :s3
      Severity: Minor
      Found in app/models/resource_import_textresult.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method generate_resource_import_textresult_list has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.generate_resource_import_textresult_list(resource_import_textresults, output_type, current_user, &block)
    threshold ||= Setting.background_job.threshold.export rescue nil

    # 出力件数の計算
    all_size = resource_import_textresults.count
      Severity: Minor
      Found in app/models/resource_import_textresult.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            ResourceImportTextresult.generate_resource_import_textresult_list_internal(textresults, output_type) do |output|
        io, info = user_file.create(:resource_import_results, output.filename)
        if output.result_type == :path
          open(output.path) { |io2| FileUtils.copy_stream(io2, io) }
        else
      Severity: Major
      Found in app/models/resource_import_textresult.rb and 1 other location - About 1 hr to fix
      app/models/checkoutlist.rb on lines 67..80

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 68.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status