Sign upLogin

MiraitSystems/enju_trunk

View on GitHub
Star

Showing 1,155 of 1,155 total issues

Method excel_worksheet_value has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def excel_worksheet_value(ws_type, ws_col, sep_flg, ccount, item = nil)
Severity: Minor
Found in app/models/manifestation.rb - About 35 mins to fix

    Method create_export_file has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def self.create_export_file(current_user, filename, header, rows, file_type = 'xlsx')
    Severity: Minor
    Found in app/servies/create_export_file.rb - About 35 mins to fix

      Method make_export_register_job has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def self.make_export_register_job(file_name, file_type, method, args, user)
      Severity: Minor
      Found in app/models/item.rb - About 35 mins to fix

        Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def initialize(name, fileinfo, output_type, user, circulation_status_ids)
        Severity: Minor
        Found in app/models/checkoutlist.rb - About 35 mins to fix

          Method adhoc_text_field_query has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def adhoc_text_field_query(qwords, model, fields, nest = true, op = :default)
          Severity: Minor
          Found in app/controllers/form_input_utils.rb - About 35 mins to fix

            Method set_data has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def set_data(field_value, field_name, mode, model, options = {})
            Severity: Minor
            Found in lib/enju_trunk/resourceadapter/import_book.rb - About 35 mins to fix

              Method update_manifestation_languages has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def update_manifestation_languages(sheet, datas, field, manifestation, error_msgs)
              Severity: Minor
              Found in lib/enju_trunk/resourceadapter/import_book.rb - About 35 mins to fix

                Method build_associated_records has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def build_associated_records(sheet, datas, record, assoc_name, spec)
                Severity: Minor
                Found in lib/enju_trunk/resourceadapter/import_book.rb - About 35 mins to fix

                  Method update_manifestation_classifications has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def update_manifestation_classifications(sheet, datas, field, manifestation, error_msgs)
                  Severity: Minor
                  Found in lib/enju_trunk/resourceadapter/import_book.rb - About 35 mins to fix

                    Method check_book_datas_has_necessary_field has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        def check_book_datas_has_necessary_field(datas, sheet, item, manifestation, manifestation_type)
                    Severity: Minor
                    Found in lib/enju_trunk/resourceadapter/import_book.rb - About 35 mins to fix

                      Method update_manifestation_subjects has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          def update_manifestation_subjects(sheet, datas, field, manifestation, error_msgs)
                      Severity: Minor
                      Found in lib/enju_trunk/resourceadapter/import_book.rb - About 35 mins to fix

                        Method update_manifestation_agents has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            def update_manifestation_agents(sheet, datas, field, manifestation, error_msgs)
                        Severity: Minor
                        Found in lib/enju_trunk/resourceadapter/import_book.rb - About 35 mins to fix

                          Method process_article_data has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              def process_article_data(import_textresult, origin_datas, sheet, textfile, numbering)
                          Severity: Minor
                          Found in lib/enju_trunk/resourceadapter/import_article.rb - About 35 mins to fix

                            Method select2_tag has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                  def select2_tag(selector_id, selector_name, collection, selected_id, *options)
                            Severity: Minor
                            Found in lib/enju_trunk/enju_trunk_helper.rb - About 35 mins to fix

                              Method build_select2 has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                    def build_select2(selector_id, selector_name, collection, selected_id, options)
                              Severity: Minor
                              Found in lib/enju_trunk/enju_trunk_helper.rb - About 35 mins to fix

                                Method agents_list has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                    def agents_list(relations = [], options = {}, manifestation_id = nil, type = nil, mode = 'html')
                                Severity: Minor
                                Found in lib/enju_trunk/enju_trunk_helper.rb - About 35 mins to fix

                                  Similar blocks of code found in 5 locations. Consider refactoring.
                                  Open

                                    def create
    @user_status = UserStatus.new(params[:user_status])
      respond_to do |format|
      if @user_status.save
        flash[:notice] = t('controller.successfully_created', :model => t('activerecord.models.user_status'))
                                  Severity: Major
                                  Found in app/controllers/user_statuses_controller.rb and 4 other locations - About 35 mins to fix
                                  app/controllers/barcode_lists_controller.rb on lines 53..61
                                  app/controllers/enju_terminals_controller.rb on lines 8..16
                                  app/controllers/numberings_controller.rb on lines 10..17
                                  app/controllers/publication_statuses_controller.rb on lines 18..26

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 36.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 5 locations. Consider refactoring.
                                  Open

                                    def create
    @numbering = Numbering.new(params[:numbering])
    respond_to do |format|
      if @numbering.save
        flash[:notice] = t('controller.successfully_created', :model => t('activerecord.models.numbering'))
                                  Severity: Major
                                  Found in app/controllers/numberings_controller.rb and 4 other locations - About 35 mins to fix
                                  app/controllers/barcode_lists_controller.rb on lines 53..61
                                  app/controllers/enju_terminals_controller.rb on lines 8..16
                                  app/controllers/publication_statuses_controller.rb on lines 18..26
                                  app/controllers/user_statuses_controller.rb on lines 8..15

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 36.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 5 locations. Consider refactoring.
                                  Open

                                    def create
    @barcode_list = BarcodeList.new(params[:barcode_list])

    respond_to do |format|
      if @barcode_list.save
                                  Severity: Major
                                  Found in app/controllers/barcode_lists_controller.rb and 4 other locations - About 35 mins to fix
                                  app/controllers/enju_terminals_controller.rb on lines 8..16
                                  app/controllers/numberings_controller.rb on lines 10..17
                                  app/controllers/publication_statuses_controller.rb on lines 18..26
                                  app/controllers/user_statuses_controller.rb on lines 8..15

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 36.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 5 locations. Consider refactoring.
                                  Open

                                    def create
    @enju_terminal = EnjuTerminal.new(params[:enju_terminal])

    respond_to do |format|
      if @enju_terminal.save
                                  Severity: Major
                                  Found in app/controllers/enju_terminals_controller.rb and 4 other locations - About 35 mins to fix
                                  app/controllers/barcode_lists_controller.rb on lines 53..61
                                  app/controllers/numberings_controller.rb on lines 10..17
                                  app/controllers/publication_statuses_controller.rb on lines 18..26
                                  app/controllers/user_statuses_controller.rb on lines 8..15

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 36.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language