Sign upLogin

MiraitSystems/enju_trunk

View on GitHub
Star

Showing 1,155 of 1,155 total issues

Method create has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

  def create
    unless @basket
      access_denied; return
    end
    @accept.basket = @basket
Severity: Minor
Found in app/controllers/accepts_controller.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build_associated_records has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    def build_associated_records(sheet, datas, record, assoc_name, spec)
      field_keys = spec.values.map(&:first)
      target_data = sheet.field_data_set(datas, field_keys)
      return nil if target_data.nil?
Severity: Minor
Found in lib/enju_trunk/resourceadapter/import_book.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

     def create_contributor_values(add_contributors)
       realizes = []
       (add_contributors || []).each do |add_contributor|
         next if add_contributor[:id].blank?
         if add_contributor[:id].to_i != 0
Severity: Major
Found in lib/enju_trunk/enju_trunk_controller.rb and 2 other locations - About 3 hrs to fix
lib/enju_trunk/enju_trunk_controller.rb on lines 497..526
lib/enju_trunk/enju_trunk_controller.rb on lines 567..596

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 134.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

     def create_creator_values(add_creators)
       creates = []
       (add_creators || []).each do |add_creator|
         next if add_creator[:id].blank?
         if add_creator[:id].to_i != 0
Severity: Major
Found in lib/enju_trunk/enju_trunk_controller.rb and 2 other locations - About 3 hrs to fix
lib/enju_trunk/enju_trunk_controller.rb on lines 532..561
lib/enju_trunk/enju_trunk_controller.rb on lines 567..596

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 134.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

     def create_publisher_values(add_publishers)
       produces = []
       (add_publishers || []).each do |add_publisher|
         next if add_publisher[:id].blank?
         if add_publisher[:id].to_i != 0
Severity: Major
Found in lib/enju_trunk/enju_trunk_controller.rb and 2 other locations - About 3 hrs to fix
lib/enju_trunk/enju_trunk_controller.rb on lines 497..526
lib/enju_trunk/enju_trunk_controller.rb on lines 532..561

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 134.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method export_removing_list has 94 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.export_removing_list(out_dir, file_type = nil)
    raise "invalid parameter: no path" if out_dir.nil? || out_dir.length < 1
    tsv_file = out_dir + "removing_list.tsv"
    pdf_file = out_dir + "removing_list.pdf"
    logger.info "output removing_list tsv: #{tsv_file} pdf: #{pdf_file}"
Severity: Major
Found in app/models/item.rb - About 3 hrs to fix

    Method advanced_search_condition_summary has 94 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def advanced_search_condition_summary(opts = {})
      return "(#{I18n.t('page.new_resource')})" if params[:mode] == 'recent'
      return "(#{params[:solr_query]})" if params[:solr_query].present?

      summary_ary = []
    Severity: Major
    Found in lib/enju_trunk/enju_trunk_helper.rb - About 3 hrs to fix

      Method send_message has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
      Open

        def send_message(status, reason = nil)
    system_user = User.find(1) # TODO: システムからのメッセージの発信者
    PurchaseRequest.transaction do
      case status
      when 'accepted'
      Severity: Minor
      Found in app/models/purchase_request.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method update_all has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
      Open

        def update_all
    changed = failed = 0
    abilities = {}

    (params['function_class_abilities'] || {}).each do |function_id, ability|
      Severity: Minor
      Found in app/controllers/function_class_abilities_controller.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method agents_list has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
      Open

          def agents_list(relations = [], options = {}, manifestation_id = nil, type = nil, mode = 'html')
      return nil if relations.blank?
      agents_list = []
      exclude_agents = SystemConfiguration.get("exclude_agents").split(',').inject([]){ |list, word| list << word.gsub(/^[　\s]*(.*?)[　\s]*$/, '\1') }
      relations.each do |relation|
      Severity: Minor
      Found in lib/enju_trunk/enju_trunk_helper.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (mon) {
        if (mon.month != cal.date.getMonth()) {
            if (cal.hilitedMonth) {
                Calendar.removeClass(cal.hilitedMonth, "hilite");
            }
      Severity: Major
      Found in app/assets/javascripts/jquery.simplecalendarjp.js and 1 other location - About 3 hrs to fix
      app/assets/javascripts/jquery.simplecalendarjp.js on lines 508..520

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 108.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (year) {
            if (year.year != cal.date.getFullYear()) {
                if (cal.hilitedYear) {
                    Calendar.removeClass(cal.hilitedYear, "hilite");
                }
      Severity: Major
      Found in app/assets/javascripts/jquery.simplecalendarjp.js and 1 other location - About 3 hrs to fix
      app/assets/javascripts/jquery.simplecalendarjp.js on lines 493..521

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 108.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method output_reminder_postal_card has 91 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def self.output_reminder_postal_card(file, reminder_lists, user, current_user)
    logger.info "create_file=> #{file}"
    report_path = EnjuTrunk.report_path

    report = ThinReports::Report.create do
      Severity: Major
      Found in app/models/reminder_list.rb - About 3 hrs to fix

        Method index has 90 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def index
    @term = Term.current_term
    @terms = Term.find(:all, :order => "start_at")
    @results = []
    @budget_sum = nil
        Severity: Major
        Found in app/controllers/budget_and_results_managements_controller.rb - About 3 hrs to fix

          Method make_export_series_statements_list_pdf has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
          Open

            def self.make_export_series_statements_list_pdf(items, acquired_at)
    return false if items.blank?
    report = EnjuTrunk.new_report('series_statements_list')

    report.events.on :page_create do |e|
          Severity: Minor
          Found in app/models/item.rb - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method make_export_series_statements_latest_list_tsv has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
          Open

            def self.make_export_series_statements_latest_list_tsv(items)
    data = String.new
    data << "\xEF\xBB\xBF".force_encoding("UTF-8") + "\n"

    columns = [
          Severity: Minor
          Found in app/models/item.rb - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method initialize_output_column_spec has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
          Open

                def initialize_output_column_spec(spec_hash = OUTPUT_COLUMN_SPEC, force_all = false)
        clear_cache!

        spec_file = "#{Rails.root}/lib/enju_trunk/columns_spec.csv"
        spec_file = Gem::Specification.find_by_name("enju_trunk").gem_dir + '/lib/enju_trunk/columns_spec.csv' unless File.exist?(spec_file)
          Severity: Minor
          Found in lib/enju_trunk/output_columns.rb - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method create_contributor_values has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
          Open

               def create_contributor_values(add_contributors)
       realizes = []
       (add_contributors || []).each do |add_contributor|
         next if add_contributor[:id].blank?
         if add_contributor[:id].to_i != 0
          Severity: Minor
          Found in lib/enju_trunk/enju_trunk_controller.rb - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method create_publisher_values has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
          Open

               def create_publisher_values(add_publishers)
       produces = []
       (add_publishers || []).each do |add_publisher|
         next if add_publisher[:id].blank?
         if add_publisher[:id].to_i != 0
          Severity: Minor
          Found in lib/enju_trunk/enju_trunk_controller.rb - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method create_creator_values has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
          Open

               def create_creator_values(add_creators)
       creates = []
       (add_creators || []).each do |add_creator|
         next if add_creator[:id].blank?
         if add_creator[:id].to_i != 0
          Severity: Minor
          Found in lib/enju_trunk/enju_trunk_controller.rb - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language