Mirocow/yii2-elasticsearch

View on GitHub

Showing 33 of 33 total issues

Function createModels has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
Open

    protected function createModels($rows)
    {
        $models = [];
        if ($this->asArray) {
            if ($this->indexBy === null) {
Severity: Minor
Found in src/components/indexes/ModelPopulate.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function search has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

    public function search()
    {
        $items = $this->result;

        if (!($items instanceof SearchHitIterator)) {
Severity: Minor
Found in src/components/indexes/ModelPopulate.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function generateResults has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

    public function generateResults($results, $nestedAggs = [])
    {
        if (empty($nestedAggs) && (!empty($this->nestedAggs) || $this->nestedAggMulti !== null)) {
            $nestedAggs = $this->nestedAggs;
            if ($this->nestedAggMulti !== null) {
Severity: Minor
Found in src/components/queries/Aggregation/Aggregation.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

QueryBuilder has 32 functions (exceeds 20 allowed). Consider refactoring.
Open

class QueryBuilder
{
    /**
     * @var null
     */
Severity: Minor
Found in src/components/queries/QueryBuilder.php - About 4 hrs to fix

    QueryHelper has 31 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class QueryHelper
    {
        /**
         * @example QueryHelper::bool(QueryHelper::match(), QueryHelper::match(), QueryHelper::match(), QueryHelper::match())
         * @see https://www.elastic.co/guide/en/elasticsearch/reference/5.6/query-filter-context.html
    Severity: Minor
    Found in src/components/queries/helpers/QueryHelper.php - About 3 hrs to fix

      AbstractSearchIndex has 25 functions (exceeds 20 allowed). Consider refactoring.
      Open

      abstract class AbstractSearchIndex implements IndexInterface, QueryInterface
      {
          public $hosts = [
            'localhost:9200'
          ];
      Severity: Minor
      Found in src/components/indexes/AbstractSearchIndex.php - About 2 hrs to fix

        Method createModels has 66 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function createModels($rows)
            {
                $models = [];
                if ($this->asArray) {
                    if ($this->indexBy === null) {
        Severity: Major
        Found in src/components/indexes/ModelPopulate.php - About 2 hrs to fix

          File QueryHelper.php has 266 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          namespace mirocow\elasticsearch\components\queries\helpers;
          
          use yii\helpers\ArrayHelper;
          
          
          Severity: Minor
          Found in src/components/queries/helpers/QueryHelper.php - About 2 hrs to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            <?php
            namespace mirocow\elasticsearch\controllers\index\actions;
            
            use mirocow\elasticsearch\contracts\IndexerInterface;
            use mirocow\elasticsearch\exceptions\SearchIndexerException;
            Severity: Major
            Found in src/controllers/index/actions/ActionDestroy.php and 2 other locations - About 2 hrs to fix
            src/controllers/index/actions/ActionCreate.php on lines 1..46
            src/controllers/index/actions/ActionPopulate.php on lines 1..46

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 105.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function populate has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
            Open

                public function populate()
                {
                    $rows = &$this->result;
            
                    if ($this->indexBy === null) {
            Severity: Minor
            Found in src/components/indexes/ModelPopulate.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            <?php
            namespace mirocow\elasticsearch\controllers\index\actions;
            
            use mirocow\elasticsearch\contracts\IndexerInterface;
            use mirocow\elasticsearch\exceptions\SearchIndexerException;
            Severity: Major
            Found in src/controllers/index/actions/ActionPopulate.php and 2 other locations - About 2 hrs to fix
            src/controllers/index/actions/ActionCreate.php on lines 1..46
            src/controllers/index/actions/ActionDestroy.php on lines 1..46

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 105.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            <?php
            namespace mirocow\elasticsearch\controllers\index\actions;
            
            use mirocow\elasticsearch\contracts\IndexerInterface;
            use mirocow\elasticsearch\exceptions\SearchIndexerException;
            Severity: Major
            Found in src/controllers/index/actions/ActionCreate.php and 2 other locations - About 2 hrs to fix
            src/controllers/index/actions/ActionDestroy.php on lines 1..46
            src/controllers/index/actions/ActionPopulate.php on lines 1..46

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 105.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            File AbstractSearchIndex.php has 259 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            namespace mirocow\elasticsearch\components\indexes;
            
            use Elasticsearch\Client;
            use Elasticsearch\ClientBuilder;
            Severity: Minor
            Found in src/components/indexes/AbstractSearchIndex.php - About 2 hrs to fix

              Method search has 49 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function search()
                  {
                      $items = $this->result;
              
                      if (!($items instanceof SearchHitIterator)) {
              Severity: Minor
              Found in src/components/indexes/ModelPopulate.php - About 1 hr to fix

                Method generateResults has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function generateResults($results, $nestedAggs = [])
                    {
                        if (empty($nestedAggs) && (!empty($this->nestedAggs) || $this->nestedAggMulti !== null)) {
                            $nestedAggs = $this->nestedAggs;
                            if ($this->nestedAggMulti !== null) {
                Severity: Minor
                Found in src/components/queries/Aggregation/Aggregation.php - About 1 hr to fix

                  Method execute has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function execute($query = [], $method = 'search', $params = [])
                      {
                          if ($query instanceof QueryBuilder) {
                              /** @var QueryBuilder $query */
                              $query = $query->generateQuery();
                  Severity: Minor
                  Found in src/components/indexes/AbstractSearchIndex.php - About 1 hr to fix

                    Function populate has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function populate(string $indexName = '', $skipNotExists = false)
                        {
                            foreach ($this->getIndexes($indexName) as $index) {
                    
                                if (!$index->exists()) {
                    Severity: Minor
                    Found in src/components/indexers/SearchIndexer.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function execute has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function execute($query = [], $method = 'search', $params = [])
                        {
                            if ($query instanceof QueryBuilder) {
                                /** @var QueryBuilder $query */
                                $query = $query->generateQuery();
                    Severity: Minor
                    Found in src/components/indexes/AbstractSearchIndex.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function getIndexes has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function getIndexes($indexName)
                        {
                            $indexes = [];
                    
                            if(!$indexName){
                    Severity: Minor
                    Found in src/components/indexers/SearchIndexer.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method prepareModels has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        protected function prepareModels()
                        {
                    
                            if (!$this->query instanceof QueryBuilder) {
                                throw new InvalidConfigException('The "query" property must be an instance of a class \mirocow\elasticsearch\components\queries\QueryBuilder or its subclasses.');
                    Severity: Minor
                    Found in src/components/indexes/SearchDataProvider.php - About 1 hr to fix
                      Severity
                      Category
                      Status
                      Source
                      Language