Sign upLogin

Mirroar/hivemind

View on GitHub
Star
src/process/strategy/intershard.ts

Summary

Maintainability
C
1 day
Test Coverage

File intershard.ts has 310 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import cache from 'utils/cache';
import hivemind from 'hivemind';
import interShard from 'intershard';
import NavMesh from 'utils/nav-mesh';
import Process from 'process/process';
Severity: Minor
Found in src/process/strategy/intershard.ts - About 3 hrs to fix

    Function findClosestSpawn has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        findClosestSpawn(targetRoom: string): {name: string; range: number} | null {
        let bestRoom = null;
        let bestLength = 0;
        for (const room of Game.myRooms) {
            if (room.controller.level < 5) continue;
    Severity: Minor
    Found in src/process/strategy/intershard.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function updateShardInfo has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        updateShardInfo() {
        if (!this.memory.info) this.memory.info = {};

        this.memory.info.ownedRooms = Game.myRooms.length;
        this.memory.info.ownedCreeps = _.size(Game.creeps);
    Severity: Minor
    Found in src/process/strategy/intershard.ts - About 1 hr to fix

      Function manageExpanding has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          manageExpanding() {
        if (!hivemind.segmentMemory.isReady()) return;

        if (this.memory.info.ownedRooms > 0) {
            // Remove expansion request when our room has hopefully stabilized.
      Severity: Minor
      Found in src/process/strategy/intershard.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function addShardData has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          addShardData(shardName: string, shardMemory?: ShardMemory) {
        // Only handle each shard once.
        if (this._shardData[shardName]) return;

        if (!shardMemory) shardMemory = interShard.getRemoteMemory(shardName);
      Severity: Minor
      Found in src/process/strategy/intershard.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

                  return false;
      Severity: Major
      Found in src/process/strategy/intershard.ts - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        if (!roomStats.bestExpansion || roomStats.bestExpansion.score < info.expansionScore) {
                    roomStats.bestExpansion = {
                        name: roomName,
                        score: info.expansionScore,
                    };
        Severity: Major
        Found in src/process/strategy/intershard.ts and 1 other location - About 1 hr to fix
        src/process/strategy/intershard.ts on lines 114..119

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 61.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        if (!roomStats.bestRoom || roomStats.bestRoom.score < info.expansionScore) {
                    roomStats.bestRoom = {
                        name: roomName,
                        score: info.expansionScore,
                    };
        Severity: Major
        Found in src/process/strategy/intershard.ts and 1 other location - About 1 hr to fix
        src/process/strategy/intershard.ts on lines 105..110

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 61.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (!bestRoom || bestLength > path.path.length) {
                bestRoom = room;
                bestLength = path.path.length;
            }
        Severity: Minor
        Found in src/process/strategy/intershard.ts and 1 other location - About 35 mins to fix
        src/process/strategy/expand.ts on lines 555..558

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status