Sign upLogin

Mirroar/hivemind

View on GitHub
Star
src/prototype/creep.military.ts

Summary

Maintainability
D
2 days
Test Coverage

Function getDamageCapacity has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

Creep.prototype.getDamageCapacity = function (this: Creep, range) {
    // @todo Cache for one tick?
    let total = 0;
    if (range > 3) return total;
Severity: Minor
Found in src/prototype/creep.military.ts - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getHealCapacity has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

Creep.prototype.getHealCapacity = function (this: Creep, range) {
    // @todo Cache for one tick?
    let total = 0;
    if (range > 3) return total;
    const power = range === 1 ? HEAL_POWER : RANGED_HEAL_POWER;
Severity: Minor
Found in src/prototype/creep.military.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getEffectiveDamage has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

Creep.prototype.getEffectiveDamage = function (this: Creep, potentialDamage) {
    let total = 0;
    let damageTaken = 0;

    for (const part of this.body) {
Severity: Minor
Found in src/prototype/creep.military.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getDamageCapacity has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Creep.prototype.getDamageCapacity = function (this: Creep, range) {
    // @todo Cache for one tick?
    let total = 0;
    if (range > 3) return total;
Severity: Minor
Found in src/prototype/creep.military.ts - About 1 hr to fix

    Function getEffectiveHealth has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    Creep.prototype.getEffectiveHealth = function (this: Creep) {
    // @todo Cache for one tick?
    let total = 0;

    for (const part of this.body) {
    Severity: Minor
    Found in src/prototype/creep.military.ts - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function isDangerous has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    Creep.prototype.isDangerous = function (this: Creep) {
    if (hivemind.relations.isAlly(this.owner.username)) return false;

    for (const part of this.body) {
        if (part.type !== MOVE && part.type !== TOUGH) {
    Severity: Minor
    Found in src/prototype/creep.military.ts - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

        return false;
    Severity: Major
    Found in src/prototype/creep.military.ts - About 30 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          interface Creep {
        isDangerous: () => boolean;
        getEffectiveHealth: () => number;
        getDamageCapacity: (range: number) => number;
        getHealCapacity: (range: number) => number;
      Severity: Major
      Found in src/prototype/creep.military.ts and 1 other location - About 2 hrs to fix
      src/prototype/creep.military.ts on lines 15..21

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 81.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          interface PowerCreep {
        isDangerous: () => boolean;
        getEffectiveHealth: () => number;
        getDamageCapacity: (range: number) => number;
        getHealCapacity: (range: number) => number;
      Severity: Major
      Found in src/prototype/creep.military.ts and 1 other location - About 2 hrs to fix
      src/prototype/creep.military.ts on lines 7..13

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 81.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              if (part.boost) {
            const effects = BOOSTS[part.type][part.boost];
            if (effects.rangedAttack) {
                total += RANGED_ATTACK_POWER * effects.rangedAttack;
                continue;
      Severity: Major
      Found in src/prototype/creep.military.ts and 2 other locations - About 1 hr to fix
      src/prototype/creep.military.ts on lines 94..100
      src/prototype/creep.military.ts on lines 134..140

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              if (part.boost) {
            const effects = BOOSTS[part.type][part.boost];
            if (effects.heal) {
                total += power * effects.heal;
                continue;
      Severity: Major
      Found in src/prototype/creep.military.ts and 2 other locations - About 1 hr to fix
      src/prototype/creep.military.ts on lines 94..100
      src/prototype/creep.military.ts on lines 107..113

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  if (part.boost) {
                const effects = BOOSTS[part.type][part.boost];
                if (effects.attack) {
                    total += ATTACK_POWER * effects.attack;
                    continue;
      Severity: Major
      Found in src/prototype/creep.military.ts and 2 other locations - About 1 hr to fix
      src/prototype/creep.military.ts on lines 107..113
      src/prototype/creep.military.ts on lines 134..140

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status