Sign upLogin

Mirroar/hivemind

View on GitHub
Star
src/role/upgrader.ts

Summary

Maintainability
D
2 days
Test Coverage

Function performUpgrade has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    performUpgrade(creep: UpgraderCreep, allowRefilling: boolean) {
        // Upgrade controller.
        const controller = creep.room.controller;
        const distance = creep.pos.getRangeTo(controller);
        const isOnlyUpgrader = creep.memory.role === 'upgrader' && _.size(creep.room.creepsByRole.upgrader) === 1;
Severity: Minor
Found in src/role/upgrader.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function performGetUpgraderEnergy has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    performGetUpgraderEnergy(creep: UpgraderCreep) {
        // Ideally, get energy from a link or container close to the controller.
        if (creep.room.memory.controllerLink) {
            const target = Game.getObjectById<StructureLink>(creep.room.memory.controllerLink);
            if (target && target.energy > 50) {
Severity: Major
Found in src/role/upgrader.ts - About 2 hrs to fix

    Function performGetUpgraderEnergy has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        performGetUpgraderEnergy(creep: UpgraderCreep) {
        // Ideally, get energy from a link or container close to the controller.
        if (creep.room.memory.controllerLink) {
            const target = Game.getObjectById<StructureLink>(creep.room.memory.controllerLink);
            if (target && target.energy > 50) {
    Severity: Minor
    Found in src/role/upgrader.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function performUpgrade has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        performUpgrade(creep: UpgraderCreep, allowRefilling: boolean) {
        // Upgrade controller.
        const controller = creep.room.controller;
        const distance = creep.pos.getRangeTo(controller);
        const isOnlyUpgrader = creep.memory.role === 'upgrader' && _.size(creep.room.creepsByRole.upgrader) === 1;
    Severity: Minor
    Found in src/role/upgrader.ts - About 1 hr to fix

      Function run has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          run(creep: UpgraderCreep) {
        if (!creep.heapMemory.currentRcl) {
            creep.heapMemory.currentRcl = creep.room.controller.level;
        }
        else if (
      Severity: Minor
      Found in src/role/upgrader.ts - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

                  return;
      Severity: Major
      Found in src/role/upgrader.ts - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (!withdrawn && creep.room.memory.controllerContainer) {
                const controllerContainer = Game.getObjectById<StructureContainer>(creep.room.memory.controllerContainer);
                if (controllerContainer && controllerContainer.store.energy > 50 && creep.pos.getRangeTo(controllerContainer) <= 1 && creep.withdraw(controllerContainer, RESOURCE_ENERGY) === OK) {
                    withdrawn = true;
                }
        Severity: Major
        Found in src/role/upgrader.ts and 1 other location - About 3 hrs to fix
        src/role/upgrader.ts on lines 118..123

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (creep.room.memory.controllerLink) {
                const controllerLink = Game.getObjectById<StructureLink>(creep.room.memory.controllerLink);
                if (controllerLink && controllerLink.store[RESOURCE_ENERGY] > 50 && creep.pos.getRangeTo(controllerLink) <= 1 && creep.withdraw(controllerLink, RESOURCE_ENERGY) === OK) {
                    withdrawn = true;
                }
        Severity: Major
        Found in src/role/upgrader.ts and 1 other location - About 3 hrs to fix
        src/role/upgrader.ts on lines 125..130

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                        if (controller.level == 8 && result == OK) {
                    const amount = Math.min(creep.store[RESOURCE_ENERGY], creep.getActiveBodyparts(WORK) * UPGRADE_CONTROLLER_POWER);
                    balancer.recordGplEnergy(amount);
                }
        Severity: Major
        Found in src/role/upgrader.ts and 1 other location - About 1 hr to fix
        src/role/builder.ts on lines 193..196

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 70.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            constructor() {
        super();

        // Upgraders have high priority because we need to praise the GCL!
        this.stopAt = 0;
        Severity: Major
        Found in src/role/upgrader.ts and 2 other locations - About 1 hr to fix
        src/role/brawler.ts on lines 68..76
        src/role/harvester.ts on lines 35..43

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (otherContainers.length > 0) {
            creep.whenInRange(1, otherContainers[0], () => {
                creep.withdraw(otherContainers[0], RESOURCE_ENERGY);
            });
        Severity: Major
        Found in src/role/upgrader.ts and 1 other location - About 1 hr to fix
        src/role/power/hauler.ts on lines 149..155

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status