Sign upLogin

Mirroar/hivemind

View on GitHub
Star
src/spawn-role/harvester.power.ts

Summary

Maintainability
C
1 day
Test Coverage

Function addOptionsForTarget has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    addOptionsForTarget(info: PowerTargetRoom, roomName: string, sourceRoom: Room, options: PowerHarvesterSpawnOption[]) {
        // We're assigned to spawn creeps for this power gathering operation!
        const activePowerHarvesters = _.filter(Game.creepsByRole['harvester.power'] || [], (creep: Creep) => {
            if (creep.memory.isHealer) return false;
            if (creep.memory.sourceRoom !== sourceRoom.name) return false;
Severity: Minor
Found in src/spawn-role/harvester.power.ts - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addOptionsForTarget has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    addOptionsForTarget(info: PowerTargetRoom, roomName: string, sourceRoom: Room, options: PowerHarvesterSpawnOption[]) {
        // We're assigned to spawn creeps for this power gathering operation!
        const activePowerHarvesters = _.filter(Game.creepsByRole['harvester.power'] || [], (creep: Creep) => {
            if (creep.memory.isHealer) return false;
            if (creep.memory.sourceRoom !== sourceRoom.name) return false;
Severity: Minor
Found in src/spawn-role/harvester.power.ts - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

                return true;
    Severity: Major
    Found in src/spawn-role/harvester.power.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return mesh.estimateTravelTime(sourcePos, targetPos);
      Severity: Major
      Found in src/spawn-role/harvester.power.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return true;
        Severity: Major
        Found in src/spawn-role/harvester.power.ts - About 30 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      const travelTime = this.getTravelTime(creep.memory.sourceRoom, creep.memory.targetRoom) || info.spawnRooms[sourceRoom.name].distance * 50;
          Severity: Major
          Found in src/spawn-role/harvester.power.ts and 1 other location - About 1 hr to fix
          src/spawn-role/harvester.power.ts on lines 56..56

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      const travelTime = this.getTravelTime(creep.memory.sourceRoom, creep.memory.targetRoom) || info.spawnRooms[sourceRoom.name].distance * 50;
          Severity: Major
          Found in src/spawn-role/harvester.power.ts and 1 other location - About 1 hr to fix
          src/spawn-role/harvester.power.ts on lines 46..46

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (currentHps < expectedHps && dpsRatio > hpsRatio && timeToKill > 0) {
            options.push({
                priority: hivemind.settings.get('powerMineCreepPriority'),
                weight: 1,
                targetRoom: roomName,
          Severity: Minor
          Found in src/spawn-role/harvester.power.ts and 1 other location - About 40 mins to fix
          src/spawn-role/harvester.power.ts on lines 78..85

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (currentDps < expectedDps && dpsRatio <= hpsRatio && timeToKill > 0 && activePowerHarvesters.length < info.freeTiles) {
            options.push({
                priority: hivemind.settings.get('powerMineCreepPriority'),
                weight: 1,
                targetRoom: roomName,
          Severity: Minor
          Found in src/spawn-role/harvester.power.ts and 1 other location - About 40 mins to fix
          src/spawn-role/harvester.power.ts on lines 88..95

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                      if (!Memory.strategy || !Memory.strategy.power || !Memory.strategy.power.rooms) return [];
          Severity: Minor
          Found in src/spawn-role/harvester.power.ts and 2 other locations - About 35 mins to fix
          src/spawn-role/harvester.deposit.ts on lines 29..29
          src/spawn-role/hauler.power.ts on lines 22..22

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status