Sign upLogin

Mirroar/hivemind

View on GitHub
Star
src/utilities.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Function getPath has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    getPath(startPosition: RoomPosition, endPosition, allowDanger = false, addOptions: {isQuad?: boolean; allowDanger?: boolean; whiteListRooms?: string[]; singleRoom?: string; avoidNearbyCreeps?: boolean} = {}) {
        const options: PathFinderOpts = {
            plainCost: 2,
            swampCost: 10,
            maxOps: 10_000, // The default 2000 can be too little even at a distance of only 2 rooms.
Severity: Minor
Found in src/utilities.ts - About 1 hr to fix

    Function getPath has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        getPath(startPosition: RoomPosition, endPosition, allowDanger = false, addOptions: {isQuad?: boolean; allowDanger?: boolean; whiteListRooms?: string[]; singleRoom?: string; avoidNearbyCreeps?: boolean} = {}) {
        const options: PathFinderOpts = {
            plainCost: 2,
            swampCost: 10,
            maxOps: 10_000, // The default 2000 can be too little even at a distance of only 2 rooms.
    Severity: Minor
    Found in src/utilities.ts - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Consider simplifying this complex logical expression.
    Open

                    if (!(allowDanger || addOptions.allowDanger) && hivemind.segmentMemory.isReady() && getRoomIntel(roomName).isOwned() && (!addOptions.whiteListRooms || !addOptions.whiteListRooms.includes(roomName))) {
                    return false;
                }
    Severity: Major
    Found in src/utilities.ts - About 40 mins to fix

      Function getBestOption has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          getBestOption<T extends WeightedOption>(options: T[]): T {
        let best = null;

        for (const option of options) {
            if (option.priority < 0) continue;
      Severity: Minor
      Found in src/utilities.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status