Sign upLogin

Mkohm/detekt-hint

View on GitHub
Star

Showing 3 of 5 total issues

Method getReachableExpressions has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    /*
    * From public, protected, initializer methods etc. Calls to private methods can exist.
    * We need to find all such calls and look for references there as well.
    */
    private fun getReachableExpressions(
Severity: Minor
Found in src/main/kotlin/io/github/mkohm/detekt/hint/rules/LackOfCohesionMethods.kt - About 1 hr to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                (superClass.findPsi() as KtClass).body?.functions?.filter { it.isPublic }.isNullOrEmpty() -> "empty public interface"
    Severity: Minor
    Found in src/main/kotlin/io/github/mkohm/detekt/hint/rules/UseCompositionInsteadOfInheritance.kt and 1 other location - About 30 mins to fix
    src/main/kotlin/io/github/mkohm/detekt/hint/rules/UseCompositionInsteadOfInheritance.kt on lines 84..84

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                    val functions = (superClass.findPsi() as KtClass).body?.functions?.filter { it.isPublic }
    Severity: Minor
    Found in src/main/kotlin/io/github/mkohm/detekt/hint/rules/UseCompositionInsteadOfInheritance.kt and 1 other location - About 30 mins to fix
    src/main/kotlin/io/github/mkohm/detekt/hint/rules/UseCompositionInsteadOfInheritance.kt on lines 82..82

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language