MrMatt57/MrMatt.io

View on GitHub

Showing 11 of 11 total issues

Function TableOfContents has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function TableOfContents() {
    var toc = "";
    var level = 2;

    var parseMatch = function(str, openLevel, id, titleText, closeLevel) {
Severity: Minor
Found in src/scripts/toc.js - About 1 hr to fix

    Function TableOfContents has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    function TableOfContents() {
        var toc = "";
        var level = 2;
    
        var parseMatch = function(str, openLevel, id, titleText, closeLevel) {
    Severity: Minor
    Found in src/scripts/toc.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function innerHTML has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

                /<h([\d])(.*)>([^<]+)<\/h([\d])>/gi, function(str, openLevel, id, titleText, closeLevel) {
    Severity: Minor
    Found in src/scripts/toc.js - About 35 mins to fix

      Function parseMatch has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          var parseMatch = function(str, openLevel, id, titleText, closeLevel) {
      Severity: Minor
      Found in src/scripts/toc.js - About 35 mins to fix

        Function migrate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        def migrate(filepath):
            '''
            Parse the Ghost json file and write post files
            '''
        
        
        Severity: Minor
        Found in src/ghost-hugo-migration/migrate.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Expected '!==' and instead saw '!='.
        Open

                if (openLevel != closeLevel) {
        Severity: Minor
        Found in src/scripts/toc.js by eslint

        Require === and !== (eqeqeq)

        It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

        The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

        • [] == false
        • [] == ![]
        • 3 == "03"

        If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

        Rule Details

        This rule is aimed at eliminating the type-unsafe equality operators.

        Examples of incorrect code for this rule:

        /*eslint eqeqeq: "error"*/
        
        if (x == 42) { }
        
        if ("" == text) { }
        
        if (obj.getStuff() != undefined) { }

        The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

        Options

        always

        The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

        Examples of incorrect code for the "always" option:

        /*eslint eqeqeq: ["error", "always"]*/
        
        a == b
        foo == true
        bananas != 1
        value == undefined
        typeof foo == 'undefined'
        'hello' != 'world'
        0 == 0
        true == true
        foo == null

        Examples of correct code for the "always" option:

        /*eslint eqeqeq: ["error", "always"]*/
        
        a === b
        foo === true
        bananas !== 1
        value === undefined
        typeof foo === 'undefined'
        'hello' !== 'world'
        0 === 0
        true === true
        foo === null

        This rule optionally takes a second argument, which should be an object with the following supported properties:

        • "null": Customize how this rule treats null literals. Possible values:
          • always (default) - Always use === or !==.
          • never - Never use === or !== with null.
          • ignore - Do not apply this rule to null.

        smart

        The "smart" option enforces the use of === and !== except for these cases:

        • Comparing two literal values
        • Evaluating the value of typeof
        • Comparing against null

        Examples of incorrect code for the "smart" option:

        /*eslint eqeqeq: ["error", "smart"]*/
        
        // comparing two variables requires ===
        a == b
        
        // only one side is a literal
        foo == true
        bananas != 1
        
        // comparing to undefined requires ===
        value == undefined

        Examples of correct code for the "smart" option:

        /*eslint eqeqeq: ["error", "smart"]*/
        
        typeof foo == 'undefined'
        'hello' != 'world'
        0 == 0
        true == true
        foo == null

        allow-null

        Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

        ["error", "always", {"null": "ignore"}]

        When Not To Use It

        If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

        Unnecessary semicolon.
        Open

        };
        Severity: Minor
        Found in src/scripts/toc.js by eslint

        disallow unnecessary semicolons (no-extra-semi)

        Typing mistakes and misunderstandings about where semicolons are required can lead to semicolons that are unnecessary. While not technically an error, extra semicolons can cause confusion when reading code.

        Rule Details

        This rule disallows unnecessary semicolons.

        Examples of incorrect code for this rule:

        /*eslint no-extra-semi: "error"*/
        
        var x = 5;;
        
        function foo() {
            // code
        };

        Examples of correct code for this rule:

        /*eslint no-extra-semi: "error"*/
        
        var x = 5;
        
        var foo = function() {
            // code
        };

        When Not To Use It

        If you intentionally use extra semicolons then you can disable this rule.

        Related Rules

        Expected return with your callback function.
        Open

                  cb();
        Severity: Minor
        Found in gulp/sprite.js by eslint

        Enforce Return After Callback (callback-return)

        The callback pattern is at the heart of most I/O and event-driven programming in JavaScript.

        function doSomething(err, callback) {
            if (err) {
                return callback(err);
            }
            callback();
        }

        To prevent calling the callback multiple times it is important to return anytime the callback is triggered outside of the main function body. Neglecting this technique often leads to issues where you do something more than once. For example, in the case of an HTTP request, you may try to send HTTP headers more than once leading Node.js to throw a Can't render headers after they are sent to the client. error.

        Rule Details

        This rule is aimed at ensuring that callbacks used outside of the main function block are always part-of or immediately preceding a return statement. This rule decides what is a callback based on the name of the function being called.

        Options

        The rule takes a single option - an array of possible callback names - which may include object methods. The default callback names are callback, cb, next.

        Default callback names

        Examples of incorrect code for this rule with the default ["callback", "cb", "next"] option:

        /*eslint callback-return: "error"*/
        
        function foo(err, callback) {
            if (err) {
                callback(err);
            }
            callback();
        }

        Examples of correct code for this rule with the default ["callback", "cb", "next"] option:

        /*eslint callback-return: "error"*/
        
        function foo(err, callback) {
            if (err) {
                return callback(err);
            }
            callback();
        }

        Supplied callback names

        Examples of incorrect code for this rule with the option ["done", "send.error", "send.success"]:

        /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
        
        function foo(err, done) {
            if (err) {
                done(err);
            }
            done();
        }
        
        function bar(err, send) {
            if (err) {
                send.error(err);
            }
            send.success();
        }

        Examples of correct code for this rule with the option ["done", "send.error", "send.success"]:

        /*eslint callback-return: ["error", ["done", "send.error", "send.success"]]*/
        
        function foo(err, done) {
            if (err) {
                return done(err);
            }
            done();
        }
        
        function bar(err, send) {
            if (err) {
                return send.error(err);
            }
            send.success();
        }

        Known Limitations

        Because it is difficult to understand the meaning of a program through static analysis, this rule has limitations:

        • false negatives when this rule reports correct code, but the program calls the callback more than one time (which is incorrect behavior)
        • false positives when this rule reports incorrect code, but the program calls the callback only one time (which is correct behavior)

        Passing the callback by reference

        The static analysis of this rule does not detect that the program calls the callback if it is an argument of a function (for example, setTimeout).

        Example of a false negative when this rule reports correct code:

        /*eslint callback-return: "error"*/
        
        function foo(err, callback) {
            if (err) {
                setTimeout(callback, 0); // this is bad, but WILL NOT warn
            }
            callback();
        }

        Triggering the callback within a nested function

        The static analysis of this rule does not detect that the program calls the callback from within a nested function or an immediately-invoked function expression (IIFE).

        Example of a false negative when this rule reports correct code:

        /*eslint callback-return: "error"*/
        
        function foo(err, callback) {
            if (err) {
                process.nextTick(function() {
                    return callback(); // this is bad, but WILL NOT warn
                });
            }
            callback();
        }

        If/else statements

        The static analysis of this rule does not detect that the program calls the callback only one time in each branch of an if statement.

        Example of a false positive when this rule reports incorrect code:

        /*eslint callback-return: "error"*/
        
        function foo(err, callback) {
            if (err) {
                callback(err); // this is fine, but WILL warn
            } else {
                callback();    // this is fine, but WILL warn
            }
        }

        When Not To Use It

        There are some cases where you might want to call a callback function more than once. In those cases this rule may lead to incorrect behavior. In those cases you may want to reserve a special name for those callbacks and not include that in the list of callbacks that trigger warnings.

        Further Reading

        Related Rules

        Missing radix parameter.
        Open

                level = parseInt(openLevel);
        Severity: Minor
        Found in src/scripts/toc.js by eslint

        Require Radix Parameter (radix)

        When using the parseInt() function it is common to omit the second argument, the radix, and let the function try to determine from the first argument what type of number it is. By default, parseInt() will autodetect decimal and hexadecimal (via 0x prefix). Prior to ECMAScript 5, parseInt() also autodetected octal literals, which caused problems because many developers assumed a leading 0 would be ignored.

        This confusion led to the suggestion that you always use the radix parameter to parseInt() to eliminate unintended consequences. So instead of doing this:

        var num = parseInt("071");      // 57

        Do this:

        var num = parseInt("071", 10);  // 71

        ECMAScript 5 changed the behavior of parseInt() so that it no longer autodetects octal literals and instead treats them as decimal literals. However, the differences between hexadecimal and decimal interpretation of the first parameter causes many developers to continue using the radix parameter to ensure the string is interpreted in the intended way.

        On the other hand, if the code is targeting only ES5-compliant environments passing the radix 10 may be redundant. In such a case you might want to disallow using such a radix.

        Rule Details

        This rule is aimed at preventing the unintended conversion of a string to a number of a different base than intended or at preventing the redundant 10 radix if targeting modern environments only.

        Options

        There are two options for this rule:

        • "always" enforces providing a radix (default)
        • "as-needed" disallows providing the 10 radix

        always

        Examples of incorrect code for the default "always" option:

        /*eslint radix: "error"*/
        
        var num = parseInt("071");
        
        var num = parseInt(someValue);
        
        var num = parseInt("071", "abc");
        
        var num = parseInt();

        Examples of correct code for the default "always" option:

        /*eslint radix: "error"*/
        
        var num = parseInt("071", 10);
        
        var num = parseInt("071", 8);
        
        var num = parseFloat(someValue);

        as-needed

        Examples of incorrect code for the "as-needed" option:

        /*eslint radix: ["error", "as-needed"]*/
        
        var num = parseInt("071", 10);
        
        var num = parseInt("071", "abc");
        
        var num = parseInt();

        Examples of correct code for the "as-needed" option:

        /*eslint radix: ["error", "as-needed"]*/
        
        var num = parseInt("071");
        
        var num = parseInt("071", 8);
        
        var num = parseFloat(someValue);

        When Not To Use It

        If you don't want to enforce either presence or omission of the 10 radix value you can turn this rule off.

        Further Reading

        TODO found
        Open

          'node_modules/photoswipe/src/css/default-skin/*.gif']) // TODO move to config
        Severity: Minor
        Found in gulp/photoswipe.js by fixme

        TODO found
        Open

            ])  //TODO Move to require file
        Severity: Minor
        Found in gulp/scripts.js by fixme
        Severity
        Category
        Status
        Source
        Language