MrZaiko/Polysmee

View on GitHub
app/src/main/java/io/github/polysmee/calendar/googlecalendarsync/CalendarUtilities.java

Summary

Maintainability
A
0 mins
Test Coverage
A
97%

Method updateAppointmentOnCalendar has 9 arguments (exceeds 4 allowed). Consider refactoring.
Wontfix

    public static void updateAppointmentOnCalendar(Context context, String calendarId, String eventId,
                                                   String title, String course, Long startTime, Long duration,
                                                   Runnable onSuccess, Runnable onError) {

    Method addAppointmentToCalendar has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Wontfix

        public static void addAppointmentToCalendar(Context context, String calendarId, String title, String course,
                                                    long startTime, long duration, Consumer<String> onSuccess, Runnable onError) {

      Method addUserToCalendar has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Wontfix

          public static void addUserToCalendar(Context context, String calendarId, String email, Runnable onSuccess, Runnable onError) {

        Method deleteAppointmentFromCalendar has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Wontfix

            public static void deleteAppointmentFromCalendar(Context context, String calendarId, String eventId,
                                                             Runnable onSuccess, Runnable onError) {

          Similar blocks of code found in 2 locations. Consider refactoring.
          Wontfix

              public static void addUserToCalendar(Context context, String calendarId, String email, Runnable onSuccess, Runnable onError) {
                  createService(context);
          
                  new Thread(() -> {
                      try {
          app/src/main/java/io/github/polysmee/calendar/googlecalendarsync/CalendarUtilities.java on lines 42..55

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Wontfix

              public static void deleteAppointmentFromCalendar(Context context, String calendarId, String eventId,
                                                               Runnable onSuccess, Runnable onError) {
                  createService(context);
          
                  new Thread(() -> {
          app/src/main/java/io/github/polysmee/calendar/googlecalendarsync/CalendarUtilities.java on lines 86..98

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status