Sign upLogin

MrZaiko/Polysmee

View on GitHub
Star
app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java

Summary

Maintainability
A
0 mins
Test Coverage
C
79%

File RoomActivityMessagesFragment.java has 458 lines of code (exceeds 250 allowed). Consider refactoring.
Invalid

package io.github.polysmee.room.fragments;

import android.Manifest;
import android.annotation.SuppressLint;
import android.app.AlertDialog;
Severity: Minor
Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java - About 7 hrs to fix

    RoomActivityMessagesFragment has 28 methods (exceeds 20 allowed). Consider refactoring.
    Wontfix

    public class RoomActivityMessagesFragment extends Fragment {
    public static String MESSAGES_KEY = "io.github.polysme.room.fragments.roomActivityMessagesFragment.MESSAGES_KEY";
    private static final int PICK_IMAGE = 100;
    private static final int TAKE_PICTURE = 200;
    private static final int SEND_PICTURE = 300;
    Severity: Minor
    Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java - About 3 hrs to fix

      Method generateCallback has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Invalid

          private ActionMode.Callback generateCallback(String messageKey, String pictureId, boolean isSent) {
        return new ActionMode.Callback() {
            @Override
            public boolean onCreateActionMode(ActionMode mode, Menu menu) {
                MenuInflater inflater = mode.getMenuInflater();
      Severity: Major
      Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java - About 2 hrs to fix

        Method generateMessageTextView has 54 lines of code (exceeds 25 allowed). Consider refactoring.
        Invalid

            private View generateMessageTextView(Message message, boolean isSent, String messageKey) {
        User sender = new DatabaseUser(message.getSender());

        Date currentDate = new Date(message.getMessageTime());
        String TIMESTAMP_PATTERN = "HH:mm";
        Severity: Major
        Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java - About 2 hrs to fix

          Method generateMessageTextView has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
          Invalid

              private View generateMessageTextView(Message message, boolean isSent, String messageKey) {
        User sender = new DatabaseUser(message.getSender());

        Date currentDate = new Date(message.getMessageTime());
        String TIMESTAMP_PATTERN = "HH:mm";
          Severity: Minor
          Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method generateCallback has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Invalid

              private ActionMode.Callback generateCallback(String messageKey, String pictureId, boolean isSent) {
        return new ActionMode.Callback() {
            @Override
            public boolean onCreateActionMode(ActionMode mode, Menu menu) {
                MenuInflater inflater = mode.getMenuInflater();
          Severity: Minor
          Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method initializeAndDisplayDatabase has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Wontfix

              private void initializeAndDisplayDatabase() {

        listener = new MessageChildListener() {

            @Override
          Severity: Minor
          Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java - About 1 hr to fix

            Method takePicture has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Wontfix

                private void takePicture(View view) {
        if(!(ContextCompat.checkSelfPermission(getContext(), Manifest.permission.CAMERA) == PackageManager.PERMISSION_GRANTED)) {
            requestPermissionLauncher.launch(Manifest.permission.CAMERA);
            return;
        }
            Severity: Minor
            Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Wontfix

                    if(!InternetConnection.isOn()) {
            AlertDialog.Builder builder = new AlertDialog.Builder(getContext());
            builder.setMessage(R.string.offline_picture);

            //add ok button
            Severity: Major
            Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java and 2 other locations - About 45 mins to fix
            app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java on lines 250..257
            app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java on lines 592..599

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Wontfix

                        if(!InternetConnection.isOn()) {
                AlertDialog.Builder offlineMsg = new AlertDialog.Builder(getContext());
                offlineMsg.setMessage(R.string.offline_edit_message);

                //add ok button
            Severity: Major
            Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java and 2 other locations - About 45 mins to fix
            app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java on lines 220..227
            app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java on lines 250..257

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Wontfix

                    if(!InternetConnection.isOn()) {
            AlertDialog.Builder builder = new AlertDialog.Builder(getContext());
            builder.setMessage(R.string.offline_send_message);

            //add ok button
            Severity: Major
            Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java and 2 other locations - About 45 mins to fix
            app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java on lines 220..227
            app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java on lines 592..599

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Wontfix

                    } else {
            ((TextView) messageLayout.findViewById(R.id.roomActivityMessageElementDateReceived)).setText(formatter.format(currentDate));

            if (message.getIsAPicture())
                messageLayout.findViewById(R.id.roomActivityMessageElementDateReceived).setBackgroundColor(Color.BLACK);
            Severity: Minor
            Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java and 1 other location - About 40 mins to fix
            app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java on lines 328..333

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Wontfix

                    if (isSent) {
            ((TextView) messageLayout.findViewById(R.id.roomActivityMessageElementDateSent)).setText(formatter.format(currentDate));

            if (message.getIsAPicture())
                messageLayout.findViewById(R.id.roomActivityMessageElementDateSent).setBackgroundColor(Color.BLACK);
            Severity: Minor
            Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java and 1 other location - About 40 mins to fix
            app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java on lines 333..338

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Invalid

                    if(!(ContextCompat.checkSelfPermission(getContext(), Manifest.permission.CAMERA) == PackageManager.PERMISSION_GRANTED)) {
            requestPermissionLauncher.launch(Manifest.permission.CAMERA);
            return;
        }
            Severity: Minor
            Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java and 2 other locations - About 30 mins to fix
            app/src/main/java/io/github/polysmee/room/fragments/RoomActivityParticipantsFragment.java on lines 351..354
            app/src/main/java/io/github/polysmee/room/fragments/RoomActivityParticipantsFragment.java on lines 356..359

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 40.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status