Sign upLogin

MrZaiko/Polysmee

View on GitHub
Star
app/src/main/java/io/github/polysmee/room/fragments/RoomActivityParticipantsFragment.java

Summary

Maintainability
D
1 day
Test Coverage
B
81%

File RoomActivityParticipantsFragment.java has 423 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package io.github.polysmee.room.fragments;

import android.Manifest;
import android.app.Activity;
import android.app.AlertDialog;
Severity: Minor
Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityParticipantsFragment.java - About 6 hrs to fix

    Method generateParticipantsView has 94 lines of code (exceeds 25 allowed). Consider refactoring.
    Invalid

        private void generateParticipantsView() {
        LinearLayout layout = rootView.findViewById(R.id.roomActivityParticipantsLayout);

        StringSetValueListener participantListener = p -> {
            if(p.contains(mainUser.getId())) {
    Severity: Major
    Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityParticipantsFragment.java - About 3 hrs to fix

      Method setUserOnline has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
      Wontfix

          public void setUserOnline(boolean online, @NonNull String id) {

        ConstraintLayout participantsLayout = participantsViews.get(id);
        View muteButton = participantsLayout.findViewById(R.id.roomActivityParticipantElementMuteButton);
        View videoButton = participantsLayout.findViewById(R.id.roomActivityParticipantElementVideoButton);
      Severity: Minor
      Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityParticipantsFragment.java - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      RoomActivityParticipantsFragment has 24 methods (exceeds 20 allowed). Consider refactoring.
      Invalid

      public class RoomActivityParticipantsFragment extends Fragment implements VoiceTunerChoiceDialogFragment.VoiceTunerChoiceDialogFragmentListener {

    private User mainUser;
    private ViewGroup rootView;
    private Appointment appointment;
      Severity: Minor
      Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityParticipantsFragment.java - About 2 hrs to fix

        Method setUserOnline has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public void setUserOnline(boolean online, @NonNull String id) {

        ConstraintLayout participantsLayout = participantsViews.get(id);
        View muteButton = participantsLayout.findViewById(R.id.roomActivityParticipantElementMuteButton);
        View videoButton = participantsLayout.findViewById(R.id.roomActivityParticipantElementVideoButton);
        Severity: Minor
        Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityParticipantsFragment.java - About 1 hr to fix

          Method generateParticipantsView has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

              private void generateParticipantsView() {
        LinearLayout layout = rootView.findViewById(R.id.roomActivityParticipantsLayout);

        StringSetValueListener participantListener = p -> {
            if(p.contains(mainUser.getId())) {
          Severity: Minor
          Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityParticipantsFragment.java - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method joinChannel has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              private void joinChannel() {
        if(InternetConnection.isOn()) {
            if(!(ContextCompat.checkSelfPermission(getContext(), Manifest.permission.RECORD_AUDIO) == PackageManager.PERMISSION_GRANTED)) {
                requestPermissionLauncher.launch(Manifest.permission.RECORD_AUDIO);
                return;
          Severity: Minor
          Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityParticipantsFragment.java - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method joinChannel has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private void joinChannel() {
        if(InternetConnection.isOn()) {
            if(!(ContextCompat.checkSelfPermission(getContext(), Manifest.permission.RECORD_AUDIO) == PackageManager.PERMISSION_GRANTED)) {
                requestPermissionLauncher.launch(Manifest.permission.RECORD_AUDIO);
                return;
          Severity: Minor
          Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityParticipantsFragment.java - About 1 hr to fix

            Method setMutedUser has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Wontfix

                public void setMutedUser(boolean muted, @NonNull String id) {
        ConstraintLayout participantsLayout = participantsViews.get(id);
        ImageView muteButton = participantsLayout.findViewById(R.id.roomActivityParticipantElementMuteButton);
        if (muted) {
            muteButton.setImageResource(R.drawable.baseline_mic_off);
            Severity: Minor
            Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityParticipantsFragment.java - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method refreshViews has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                private void refreshViews() {
        LinearLayout layout = rootView.findViewById(R.id.roomActivityParticipantsLayout);
        layout.removeAllViews();
        String userId = mainUser.getId();
        //add current user for it to appear first
            Severity: Minor
            Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityParticipantsFragment.java - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Invalid

                        if(!(ContextCompat.checkSelfPermission(getContext(), Manifest.permission.RECORD_AUDIO) == PackageManager.PERMISSION_GRANTED)) {
                requestPermissionLauncher.launch(Manifest.permission.RECORD_AUDIO);
                return;
            }
            Severity: Minor
            Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityParticipantsFragment.java and 2 other locations - About 30 mins to fix
            app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java on lines 151..154
            app/src/main/java/io/github/polysmee/room/fragments/RoomActivityParticipantsFragment.java on lines 356..359

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 40.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Invalid

                        if(!(ContextCompat.checkSelfPermission(getContext(), Manifest.permission.BLUETOOTH) == PackageManager.PERMISSION_GRANTED)) {
                requestPermissionLauncher.launch(Manifest.permission.BLUETOOTH);
                return;
            }
            Severity: Minor
            Found in app/src/main/java/io/github/polysmee/room/fragments/RoomActivityParticipantsFragment.java and 2 other locations - About 30 mins to fix
            app/src/main/java/io/github/polysmee/room/fragments/RoomActivityMessagesFragment.java on lines 151..154
            app/src/main/java/io/github/polysmee/room/fragments/RoomActivityParticipantsFragment.java on lines 351..354

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 40.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status