Sign upLogin

MushroomRL/mushroom-rl

View on GitHub
Star
mushroom_rl/features/features.py

Summary

Maintainability
A
3 hrs
Test Coverage
A
90%

Consider simplifying this complex logical expression.
Open

    if basis_list is not None and tilings is None and tensor_list is None and n_outputs is None:
        return BasisFeatures(basis_list)
    elif basis_list is None and tilings is not None and tensor_list is None and n_outputs is None:
        return TilesFeatures(tilings)
    elif basis_list is None and tilings is None and tensor_list is not None and n_outputs is None:
Severity: Critical
Found in mushroom_rl/features/features.py - About 3 hrs to fix

    Function Features has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Wontfix

    def Features(basis_list=None, tilings=None, tensor_list=None,
             n_outputs=None, function=None):
    """
    Factory method to build the requested type of features. The types are
    mutually exclusive.
    Severity: Minor
    Found in mushroom_rl/features/features.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status