Sign upLogin

Muterra/py_golix

View on GitHub
Star
golix/cipher.py

Summary

Maintainability
F
3 days
Test Coverage

File cipher.py has 1050 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'''
LICENSING
-------------------------------------------------

golix: A python library for Golix protocol object manipulation.
Severity: Major
Found in golix/cipher.py - About 2 days to fix

    _FirstPartyBase has 31 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class _FirstPartyBase(_ObjectHandlerBase, metaclass=abc.ABCMeta):
    DEFAULT_ADDRESS_ALGO = DEFAULT_ADDRESSER
    
    def __init__(self, keys=None, ghid=None, address_algo='default', *args,
                 **kwargs):
    Severity: Minor
    Found in golix/cipher.py - About 3 hrs to fix

      Cyclomatic complexity is too high in method verify_object. (7)
      Open

          @classmethod
    def verify_object(cls, second_party, obj):
        ''' Verifies the signature of any symmetric object (aka
        everything except GARQ) against data.
      Severity: Minor
      Found in golix/cipher.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(self, keys=None, ghid=None, address_algo='default', *args,
      Severity: Minor
      Found in golix/cipher.py - About 35 mins to fix

        Function unpack_request has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def unpack_request(self, packed):
        garq = GARQ.unpack(packed)
        plaintext = self._decrypt_asym(garq.payload)
        
        # Could do this with a loop, but it gets awkward when trying to
        Severity: Minor
        Found in golix/cipher.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status