Sign upLogin

MyEMS/myems

View on GitHub
Star

Showing 10,536 of 10,536 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        modalInstance.result.then(function(point) {
            point.data_source_id = $scope.currentDataSource;
            let headers = { "User-UUID": $scope.cur_user.uuid, "Token": $scope.cur_user.token };
            PointService.addPoint(point, headers, function (response) {
                if (angular.isDefined(response.status) && response.status === 201) {
Severity: Major
Found in myems-admin/app/controllers/settings/datasource/point.controller.js and 1 other location - About 1 day to fix
myems-admin/app/controllers/settings/datasource/point.controller.js on lines 98..119

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 259.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        modalInstance.result.then(function(modifiedPoint) {
            modifiedPoint.data_source_id = $scope.currentDataSource;
            let headers = { "User-UUID": $scope.cur_user.uuid, "Token": $scope.cur_user.token };
            PointService.editPoint(modifiedPoint, headers, function (response) {
                if (angular.isDefined(response.status) && response.status === 200) {
Severity: Major
Found in myems-admin/app/controllers/settings/datasource/point.controller.js and 1 other location - About 1 day to fix
myems-admin/app/controllers/settings/datasource/point.controller.js on lines 57..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 259.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        modalInstance.result.then(function(datasource) {
            let headers = { "User-UUID": $scope.cur_user.uuid, "Token": $scope.cur_user.token };
            datasource.gateway_id = datasource.gateway.id;
            DataSourceService.addDataSource(datasource, headers, function (response) {
                if (angular.isDefined(response.status) && response.status === 201) {
Severity: Major
Found in myems-admin/app/controllers/settings/datasource/datasource.controller.js and 1 other location - About 1 day to fix
myems-admin/app/controllers/settings/datasource/datasource.controller.js on lines 111..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 259.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File storeenergyitem.py has 633 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import base64
from core.utilities import get_translation
import os
import re
import uuid
Severity: Major
Found in myems-api/excelexporters/storeenergyitem.py - About 1 day to fix

    File tenantenergyitem.py has 633 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import base64
from core.utilities import get_translation
import os
import re
import uuid
    Severity: Major
    Found in myems-api/excelexporters/tenantenergyitem.py - About 1 day to fix

      File shopfloorenergyitem.py has 633 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import base64
from core.utilities import get_translation
import os
import re
import uuid
      Severity: Major
      Found in myems-api/excelexporters/shopfloorenergyitem.py - About 1 day to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    for i in range(0, base_period_data_ca_len):
                current_col_number += 1
                col = format_cell.get_column_letter(current_col_number)
                ws[col + str(current_row_number)].font = title_font
                ws[col + str(current_row_number)].alignment = c_c_alignment
        Severity: Major
        Found in myems-api/excelexporters/spaceefficiency.py and 1 other location - About 1 day to fix
        myems-api/excelexporters/spaceefficiency.py on lines 541..548

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 160.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    for i in range(0, reporting_period_data_ca_len):
                current_col_number += 1
                col = format_cell.get_column_letter(current_col_number)
                ws[col + str(current_row_number)].font = title_font
                ws[col + str(current_row_number)].alignment = c_c_alignment
        Severity: Major
        Found in myems-api/excelexporters/spaceefficiency.py and 1 other location - About 1 day to fix
        myems-api/excelexporters/spaceefficiency.py on lines 524..531

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 160.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function on_get has a Cognitive Complexity of 70 (exceeds 5 allowed). Consider refactoring.
        Open

            def on_get(req, resp):
        access_control(req)
        start_datetime_local = req.params.get('startdatetime')
        end_datetime_local = req.params.get('enddatetime')
        status = req.params.get('status')
        Severity: Minor
        Found in myems-api/core/webmessage.py - About 1 day to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File equipmentplan.py has 628 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        import re
from datetime import datetime, timedelta, timezone
from decimal import Decimal
import falcon
import mysql.connector
        Severity: Major
        Found in myems-api/reports/equipmentplan.py - About 1 day to fix

          File equipmentsaving.py has 628 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          import re
from datetime import datetime, timedelta, timezone
from decimal import Decimal
import falcon
import mysql.connector
          Severity: Major
          Found in myems-api/reports/equipmentsaving.py - About 1 day to fix

            Function datePickerDirective has 275 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                Module.directive('datePicker', ['datePickerConfig', 'datePickerUtils', function datePickerDirective(datePickerConfig, datePickerUtils) {

        //noinspection JSUnusedLocalSymbols
        return {
            // this is a bug ?
            Severity: Major
            Found in myems-admin/js/plugins/datapicker/angular-datepicker.js - About 1 day to fix

              File shopfloorenergycategory.py has 624 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              import re
from datetime import datetime, timedelta, timezone
from decimal import Decimal
import falcon
import mysql.connector
              Severity: Major
              Found in myems-api/reports/shopfloorenergycategory.py - About 1 day to fix

                Function ResourceProvider has 273 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  provider('$resource', function ResourceProvider() {
    var PROTOCOL_AND_IPV6_REGEX = /^https?:\/\/\[[^\]]*][^/]*/;

    var provider = this;
                Severity: Major
                Found in myems-admin/js/angular/angular-resource.js - About 1 day to fix

                  Function on_get has a Cognitive Complexity of 69 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def on_get(req, resp):
        if 'API-KEY' not in req.headers or \
                not isinstance(req.headers['API-KEY'], str) or \
                len(str.strip(req.headers['API-KEY'])) == 0:
            access_control(req)
                  Severity: Minor
                  Found in myems-api/reports/offlinemeterbatch.py - About 1 day to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function on_get has a Cognitive Complexity of 69 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def on_get(req, resp):
        if 'API-KEY' not in req.headers or \
                not isinstance(req.headers['API-KEY'], str) or \
                len(str.strip(req.headers['API-KEY'])) == 0:
            access_control(req)
                  Severity: Minor
                  Found in myems-api/reports/virtualmeterbatch.py - About 1 day to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function generate_excel has a Cognitive Complexity of 69 (exceeds 5 allowed). Consider refactoring.
                  Open

                  def generate_excel(report,
                   name,
                   reporting_start_datetime_local,
                   reporting_end_datetime_local,
                   period_type,
                  Severity: Minor
                  Found in myems-api/excelexporters/metertrend.py - About 1 day to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  File storeenergycategory.py has 621 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  import re
from datetime import datetime, timedelta, timezone
from decimal import Decimal
import falcon
import mysql.connector
                  Severity: Major
                  Found in myems-api/reports/storeenergycategory.py - About 1 day to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            modalInstance.result.then(function(nonWorkingDay) {
            let headers = { "User-UUID": $scope.cur_user.uuid, "Token": $scope.cur_user.token };
            WorkingCalendarNonWorkingDayService.addNonWorkingDay(nonWorkingDay.working_calendar_id, nonWorkingDay,
                 headers, function (response) {
                if (angular.isDefined(response.status) && response.status === 201) {
                    Severity: Major
                    Found in myems-admin/app/controllers/settings/workingcalendar/workingcalendarnonworkingday.controller.js and 1 other location - About 1 day to fix
                    myems-admin/app/controllers/settings/workingcalendar/workingcalendarnonworkingday.controller.js on lines 183..203

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 253.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            modalInstance.result.then(function(nonWorkingDay) {
            let headers = { "User-UUID": $scope.cur_user.uuid, "Token": $scope.cur_user.token };
            WorkingCalendarNonWorkingDayService.editNonWorkingDay(nonWorkingDay.id, nonWorkingDay, headers, function (response) {
                if (angular.isDefined(response.status) && response.status === 200) {
                    toaster.pop({
                    Severity: Major
                    Found in myems-admin/app/controllers/settings/workingcalendar/workingcalendarnonworkingday.controller.js and 1 other location - About 1 day to fix
                    myems-admin/app/controllers/settings/workingcalendar/workingcalendarnonworkingday.controller.js on lines 141..162

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 253.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language