Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-aggregation/combined_equipment_billing_input_category.py

Summary

Maintainability
F
2 wks
Test Coverage

Function main has a Cognitive Complexity of 152 (exceeds 5 allowed). Consider refactoring.
Open

def main(logger):

    while True:
        # the outermost while loop
        ################################################################################################################
Severity: Minor
Found in myems-aggregation/combined_equipment_billing_input_category.py - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if len(billing_dict[current_datetime_utc]) == 0:
                        del billing_dict[current_datetime_utc]

            ############################################################################################################
            # Step 6: save billing data to billing database
Severity: Major
Found in myems-aggregation/combined_equipment_billing_input_category.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            for energy_category_id in energy_category_list:
                            current_billing = billing_dict[current_datetime_utc].get(energy_category_id)
                            if current_billing is not None and isinstance(current_billing, Decimal):
                                add_values += " (" + str(combined_equipment['id']) + ","
                                add_values += " " + str(energy_category_id) + ","
    Severity: Major
    Found in myems-aggregation/combined_equipment_billing_input_category.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          for energy_category_id in energy_category_list:
                        current_tariff = tariff_dict[energy_category_id].get(current_datetime_utc)
                        current_energy = energy_dict[current_datetime_utc].get(energy_category_id)
                        if current_tariff is not None \
                                and isinstance(current_tariff, Decimal) \
      Severity: Major
      Found in myems-aggregation/combined_equipment_billing_input_category.py - About 45 mins to fix

        Similar blocks of code found in 15 locations. Consider refactoring.
        Open

        Severity: Major
        Found in myems-aggregation/combined_equipment_billing_input_category.py and 14 other locations - About 2 wks to fix
        myems-aggregation/combined_equipment_billing_input_item.py on lines 0..271
        myems-aggregation/combined_equipment_billing_output_category.py on lines 0..271
        myems-aggregation/equipment_billing_input_category.py on lines 0..270
        myems-aggregation/equipment_billing_input_item.py on lines 0..270
        myems-aggregation/equipment_billing_output_category.py on lines 0..270
        myems-aggregation/shopfloor_billing_input_category.py on lines 0..270
        myems-aggregation/shopfloor_billing_input_item.py on lines 0..270
        myems-aggregation/space_billing_input_category.py on lines 0..270
        myems-aggregation/space_billing_input_item.py on lines 0..270
        myems-aggregation/space_billing_output_category.py on lines 0..270
        myems-aggregation/store_billing_input_category.py on lines 0..270
        myems-aggregation/store_billing_input_item.py on lines 0..270
        myems-aggregation/tenant_billing_input_category.py on lines 0..269
        myems-aggregation/tenant_billing_input_item.py on lines 0..269

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 1528.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status