Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-aggregation/energy_storage_power_station_energy_charge.py

Summary

Maintainability
F
3 wks
Test Coverage

Function worker has a Cognitive Complexity of 98 (exceeds 5 allowed). Consider refactoring.
Open

def worker(energy_storage_power_station):
    cnx_system_db = None
    cursor_system_db = None
    try:
        cnx_system_db = mysql.connector.connect(**config.myems_system_db)
Severity: Minor
Found in myems-aggregation/energy_storage_power_station_energy_charge.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function main has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

def main(logger):

    while True:
        # the outermost while loop
        ################################################################################################################
Severity: Minor
Found in myems-aggregation/energy_storage_power_station_energy_charge.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if common_start_datetime_utc < min(energy_hourly.keys()):
                        common_start_datetime_utc = min(energy_hourly.keys())
                    if common_end_datetime_utc > max(energy_hourly.keys()):
Severity: Major
Found in myems-aggregation/energy_storage_power_station_energy_charge.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                        if common_end_datetime_utc > max(energy_hourly.keys()):
                        common_end_datetime_utc = max(energy_hourly.keys())
    Severity: Major
    Found in myems-aggregation/energy_storage_power_station_energy_charge.py - About 45 mins to fix

      Avoid too many return statements within this function.
      Open

              return error_string
      Severity: Major
      Found in myems-aggregation/energy_storage_power_station_energy_charge.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return error_string
        Severity: Major
        Found in myems-aggregation/energy_storage_power_station_energy_charge.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return error_string
          Severity: Major
          Found in myems-aggregation/energy_storage_power_station_energy_charge.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return error_string
            Severity: Major
            Found in myems-aggregation/energy_storage_power_station_energy_charge.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return None
              Severity: Major
              Found in myems-aggregation/energy_storage_power_station_energy_charge.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return None
                Severity: Major
                Found in myems-aggregation/energy_storage_power_station_energy_charge.py - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  Severity: Major
                  Found in myems-aggregation/energy_storage_power_station_energy_charge.py and 1 other location - About 2 wks to fix
                  myems-aggregation/energy_storage_power_station_energy_discharge.py on lines 0..342

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 1973.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status