Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-aggregation/offline_meter_carbon.py

Summary

Maintainability
D
2 days
Test Coverage

Function main has a Cognitive Complexity of 131 (exceeds 5 allowed). Consider refactoring.
Open

def main(logger):

    while True:
        # the outermost while loop
        ################################################################################################################
Severity: Minor
Found in myems-aggregation/offline_meter_carbon.py - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if current_factor is not None \
                            and isinstance(current_factor, Decimal) \
                            and current_energy is not None \
                            and isinstance(current_energy, Decimal):
                        aggregated_value['actual_value'] = current_energy * current_factor
Severity: Major
Found in myems-aggregation/offline_meter_carbon.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if aggregated_value['actual_value'] is not None and \
                                isinstance(aggregated_value['actual_value'], Decimal):
                            add_values += " (" + str(offline_meter['id']) + ","
                            add_values += "'" + aggregated_value['start_datetime_utc'].isoformat()[0:19] + "',"
                            add_values += str(aggregated_value['actual_value']) + "), "
    Severity: Major
    Found in myems-aggregation/offline_meter_carbon.py - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status