Function `worker` has a Cognitive Complexity of 290 (exceeds 5 allowed). Consider refactoring.
Open

def worker(shopfloor):
    ####################################################################################################################
    # Step 1: get all input meters associated with the shopfloor
    ####################################################################################################################
    print("Step 1: get all input meters associated with the shopfloor " + str(shopfloor['name']))

Found in myems-aggregation/shopfloor_energy_input_item.py - About 5 days to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

def worker(shopfloor):
    ####################################################################################################################
    # Step 1: get all input meters associated with the shopfloor
    ####################################################################################################################
    print("Step 1: get all input meters associated with the shopfloor " + str(shopfloor['name']))

Found in myems-aggregation/shopfloor_energy_input_item.py - About 1 hr to fix

Consider simplifying this complex logical expression.
Open

    if (meter_list is None or len(meter_list) == 0) and \
            (virtual_meter_list is None or len(virtual_meter_list) == 0) and \
            (offline_meter_list is None or len(offline_meter_list) == 0) and \
            (equipment_list is None or len(equipment_list) == 0):
        print("This is an empty shopfloor ")

Found in myems-aggregation/shopfloor_energy_input_item.py - About 1 hr to fix

Consider simplifying this complex logical expression.
Open

    if (energy_meter_hourly is None or len(energy_meter_hourly) == 0) and \
            (energy_virtual_meter_hourly is None or len(energy_virtual_meter_hourly) == 0) and \
            (energy_offline_meter_hourly is None or len(energy_offline_meter_hourly) == 0) and \
            (energy_equipment_hourly is None or len(energy_equipment_hourly) == 0):
        # There isn't any energy data

Found in myems-aggregation/shopfloor_energy_input_item.py - About 1 hr to fix

Avoid deeply nested control flow statements.
Open

                        for energy_item_id, actual_value in meta_data_dict.items():
                            aggregated_value['meta_data'][energy_item_id] = \
                                aggregated_value['meta_data'].get(energy_item_id, Decimal(0.0)) + actual_value

Found in myems-aggregation/shopfloor_energy_input_item.py - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

                    if common_end_datetime_utc > max(energy_hourly.keys()):
                        common_end_datetime_utc = max(energy_hourly.keys())

Found in myems-aggregation/shopfloor_energy_input_item.py - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

                    if common_end_datetime_utc > max(energy_hourly.keys()):
                        common_end_datetime_utc = max(energy_hourly.keys())

Found in myems-aggregation/shopfloor_energy_input_item.py - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

                        if current_datetime_utc not in energy_equipment_hourly[equipment_id]:
                            energy_equipment_hourly[equipment_id][current_datetime_utc] = dict()
                        energy_item_id = row_value[1]

Found in myems-aggregation/shopfloor_energy_input_item.py - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

                    if common_end_datetime_utc > max(energy_hourly.keys()):
                        common_end_datetime_utc = max(energy_hourly.keys())

Found in myems-aggregation/shopfloor_energy_input_item.py - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

                    if common_start_datetime_utc < min(energy_hourly.keys()):
                        common_start_datetime_utc = min(energy_hourly.keys())
                    if common_end_datetime_utc > max(energy_hourly.keys()):

Found in myems-aggregation/shopfloor_energy_input_item.py - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

                    if common_start_datetime_utc < min(energy_hourly.keys()):
                        common_start_datetime_utc = min(energy_hourly.keys())
                    if common_end_datetime_utc > max(energy_hourly.keys()):

Found in myems-aggregation/shopfloor_energy_input_item.py - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

                    if common_start_datetime_utc < min(energy_hourly.keys()):
                        common_start_datetime_utc = min(energy_hourly.keys())
                    if common_end_datetime_utc > max(energy_hourly.keys()):

Found in myems-aggregation/shopfloor_energy_input_item.py - About 45 mins to fix

Avoid too many `return` statements within this function.
Open

            return error_string

Found in myems-aggregation/shopfloor_energy_input_item.py - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

        return None

Found in myems-aggregation/shopfloor_energy_input_item.py - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

        return None

Found in myems-aggregation/shopfloor_energy_input_item.py - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

        return error_string

Found in myems-aggregation/shopfloor_energy_input_item.py - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

            return error_string

Found in myems-aggregation/shopfloor_energy_input_item.py - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

        return error_string

Found in myems-aggregation/shopfloor_energy_input_item.py - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

            return error_string

Found in myems-aggregation/shopfloor_energy_input_item.py - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

    return None

Found in myems-aggregation/shopfloor_energy_input_item.py - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

        return error_string

Found in myems-aggregation/shopfloor_energy_input_item.py - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

            return error_string

Found in myems-aggregation/shopfloor_energy_input_item.py - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

        return error_string

Found in myems-aggregation/shopfloor_energy_input_item.py - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

        return error_string

Found in myems-aggregation/shopfloor_energy_input_item.py - About 30 mins to fix

Similar blocks of code found in 5 locations. Consider refactoring.
Open

Found in myems-aggregation/shopfloor_energy_input_item.py and 4 other locations - About 1 mo to fix

Read up
Read up

myems-aggregation/combined_equipment_energy_input_category.py on lines 0..622

myems-aggregation/combined_equipment_energy_input_item.py on lines 0..625

myems-aggregation/combined_equipment_energy_output_category.py on lines 0..622

myems-aggregation/shopfloor_energy_input_category.py on lines 0..619

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 4224.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

MyEMS/myems

Summary

Maintainability

Test Coverage

Function worker has a Cognitive Complexity of 290 (exceeds 5 allowed). Consider refactoring. Open

Cognitive Complexity

A method's cognitive complexity is based on a few simple rules:

Further reading

File shopfloor_energy_input_item.py has 469 lines of code (exceeds 250 allowed). Consider refactoring. Open

Function main has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring. Open

Cognitive Complexity

A method's cognitive complexity is based on a few simple rules:

Further reading

Function worker has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open

Consider simplifying this complex logical expression. Open

Consider simplifying this complex logical expression. Open

Avoid deeply nested control flow statements. Open

Avoid deeply nested control flow statements. Open

Avoid deeply nested control flow statements. Open

Avoid deeply nested control flow statements. Open

Avoid deeply nested control flow statements. Open

Avoid deeply nested control flow statements. Open

Avoid deeply nested control flow statements. Open

Avoid deeply nested control flow statements. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Similar blocks of code found in 5 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

There are no issues that match your filters.

Category

Status

Function `worker` has a Cognitive Complexity of 290 (exceeds 5 allowed). Consider refactoring.
Open

File `shopfloor_energy_input_item.py` has 469 lines of code (exceeds 250 allowed). Consider refactoring.
Open

Function `main` has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

Function `worker` has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Consider simplifying this complex logical expression.
Open

Consider simplifying this complex logical expression.
Open

Avoid deeply nested control flow statements.
Open

Avoid deeply nested control flow statements.
Open

Avoid deeply nested control flow statements.
Open

Avoid deeply nested control flow statements.
Open

Avoid deeply nested control flow statements.
Open

Avoid deeply nested control flow statements.
Open

Avoid deeply nested control flow statements.
Open

Avoid deeply nested control flow statements.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Similar blocks of code found in 5 locations. Consider refactoring.
Open