Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-aggregation/space_energy_input_item.py

Summary

Maintainability
F
3 mos
Test Coverage

Function worker has a Cognitive Complexity of 665 (exceeds 5 allowed). Consider refactoring.
Open

def worker(space):
    ####################################################################################################################
    # Step 1: get all input meters associated with the space
    ####################################################################################################################
    print("Step 1: get all input meters associated with the space " + str(space['name']))
Severity: Minor
Found in myems-aggregation/space_energy_input_item.py - About 1 wk to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File space_energy_input_item.py has 855 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import random
import time
from datetime import datetime, timedelta
from decimal import Decimal
from multiprocessing import Pool
Severity: Major
Found in myems-aggregation/space_energy_input_item.py - About 2 days to fix

    Consider simplifying this complex logical expression.
    Open

        if (energy_meter_hourly is None or len(energy_meter_hourly) == 0) and \
            (energy_virtual_meter_hourly is None or len(energy_virtual_meter_hourly) == 0) and \
            (energy_offline_meter_hourly is None or len(energy_offline_meter_hourly) == 0) and \
            (energy_combined_equipment_hourly is None or len(energy_combined_equipment_hourly) == 0) and \
            (energy_equipment_hourly is None or len(energy_equipment_hourly) == 0) and \
    Severity: Critical
    Found in myems-aggregation/space_energy_input_item.py - About 4 hrs to fix

      Consider simplifying this complex logical expression.
      Open

          if (meter_list is None or len(meter_list) == 0) and \
            (virtual_meter_list is None or len(virtual_meter_list) == 0) and \
            (offline_meter_list is None or len(offline_meter_list) == 0) and \
            (combined_equipment_list is None or len(combined_equipment_list) == 0) and \
            (equipment_list is None or len(equipment_list) == 0) and \
      Severity: Critical
      Found in myems-aggregation/space_energy_input_item.py - About 4 hrs to fix

        Function main has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
        Open

        def main(logger):

    while True:
        # the outermost while loop
        ################################################################################################################
        Severity: Minor
        Found in myems-aggregation/space_energy_input_item.py - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function worker has 63 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        def worker(space):
    ####################################################################################################################
    # Step 1: get all input meters associated with the space
    ####################################################################################################################
    print("Step 1: get all input meters associated with the space " + str(space['name']))
        Severity: Major
        Found in myems-aggregation/space_energy_input_item.py - About 2 hrs to fix

          Avoid deeply nested control flow statements.
          Open

                              if common_start_datetime_utc < min(energy_hourly.keys()):
                        common_start_datetime_utc = min(energy_hourly.keys())
                    if common_end_datetime_utc > max(energy_hourly.keys()):
          Severity: Major
          Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if current_datetime_utc not in energy_child_space_hourly[child_space_id]:
                            energy_child_space_hourly[child_space_id][current_datetime_utc] = dict()
                        energy_item_id = row_energy_value[1]
            Severity: Major
            Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  if common_end_datetime_utc > max(energy_hourly.keys()):
                        common_end_datetime_utc = max(energy_hourly.keys())
              Severity: Major
              Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                    if common_end_datetime_utc > max(energy_hourly.keys()):
                        common_end_datetime_utc = max(energy_hourly.keys())
                Severity: Major
                Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                          for energy_item_id, actual_value in meta_data_dict.items():
                            aggregated_value['meta_data'][energy_item_id] = \
                                aggregated_value['meta_data'].get(energy_item_id, Decimal(0.0)) + actual_value
                  Severity: Major
                  Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                        if common_start_datetime_utc < min(energy_hourly.keys()):
                        common_start_datetime_utc = min(energy_hourly.keys())
                    if common_end_datetime_utc > max(energy_hourly.keys()):
                    Severity: Major
                    Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                          if common_start_datetime_utc < min(energy_hourly.keys()):
                        common_start_datetime_utc = min(energy_hourly.keys())
                    if common_end_datetime_utc > max(energy_hourly.keys()):
                      Severity: Major
                      Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                                if current_datetime_utc not in energy_equipment_hourly[equipment_id]:
                            energy_equipment_hourly[equipment_id][current_datetime_utc] = dict()
                        energy_item_id = row_value[1]
                        Severity: Major
                        Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                                  for energy_item_id, actual_value in meta_data_dict.items():
                            aggregated_value['meta_data'][energy_item_id] = \
                                aggregated_value['meta_data'].get(energy_item_id, Decimal(0.0)) + actual_value
                          Severity: Major
                          Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                                    if current_datetime_utc not in energy_combined_equipment_hourly[combined_equipment_id]:
                            energy_combined_equipment_hourly[combined_equipment_id][current_datetime_utc] = dict()
                        energy_item_id = row_value[1]
                            Severity: Major
                            Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                                  if common_start_datetime_utc < min(energy_hourly.keys()):
                        common_start_datetime_utc = min(energy_hourly.keys())
                    if common_end_datetime_utc > max(energy_hourly.keys()):
                              Severity: Major
                              Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                                Avoid deeply nested control flow statements.
                                Open

                                                        for energy_item_id, actual_value in meta_data_dict.items():
                            aggregated_value['meta_data'][energy_item_id] = \
                                aggregated_value['meta_data'].get(energy_item_id, Decimal(0.0)) + actual_value
                                Severity: Major
                                Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                                  Avoid deeply nested control flow statements.
                                  Open

                                                          if current_datetime_utc not in energy_tenant_hourly[tenant_id]:
                            energy_tenant_hourly[tenant_id][current_datetime_utc] = dict()
                        energy_item_id = row_energy_value[1]
                                  Severity: Major
                                  Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                                    Avoid deeply nested control flow statements.
                                    Open

                                                        if common_end_datetime_utc > max(energy_hourly.keys()):
                        common_end_datetime_utc = max(energy_hourly.keys())
                                    Severity: Major
                                    Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                                      Avoid deeply nested control flow statements.
                                      Open

                                                              for energy_item_id, actual_value in meta_data_dict.items():
                            aggregated_value['meta_data'][energy_item_id] = \
                                aggregated_value['meta_data'].get(energy_item_id, Decimal(0.0)) + actual_value
                                      Severity: Major
                                      Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                                        Avoid deeply nested control flow statements.
                                        Open

                                                            if common_start_datetime_utc < min(energy_hourly.keys()):
                        common_start_datetime_utc = min(energy_hourly.keys())
                    if common_end_datetime_utc > max(energy_hourly.keys()):
                                        Severity: Major
                                        Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                                          Avoid deeply nested control flow statements.
                                          Open

                                                              if common_start_datetime_utc < min(energy_hourly.keys()):
                        common_start_datetime_utc = min(energy_hourly.keys())
                    if common_end_datetime_utc > max(energy_hourly.keys()):
                                          Severity: Major
                                          Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                                            Avoid deeply nested control flow statements.
                                            Open

                                                                if common_end_datetime_utc > max(energy_hourly.keys()):
                        common_end_datetime_utc = max(energy_hourly.keys())
                                            Severity: Major
                                            Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                                              Avoid deeply nested control flow statements.
                                              Open

                                                                  if common_start_datetime_utc < min(energy_hourly.keys()):
                        common_start_datetime_utc = min(energy_hourly.keys())
                    if common_end_datetime_utc > max(energy_hourly.keys()):
                                              Severity: Major
                                              Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                                                Avoid deeply nested control flow statements.
                                                Open

                                                                    if common_start_datetime_utc < min(energy_hourly.keys()):
                        common_start_datetime_utc = min(energy_hourly.keys())
                    if common_end_datetime_utc > max(energy_hourly.keys()):
                                                Severity: Major
                                                Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                                                  Avoid deeply nested control flow statements.
                                                  Open

                                                                          for energy_item_id, actual_value in meta_data_dict.items():
                            aggregated_value['meta_data'][energy_item_id] = \
                                aggregated_value['meta_data'].get(energy_item_id, Decimal(0.0)) + actual_value
                                                  Severity: Major
                                                  Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                                                    Avoid deeply nested control flow statements.
                                                    Open

                                                                        if common_end_datetime_utc > max(energy_hourly.keys()):
                        common_end_datetime_utc = max(energy_hourly.keys())
                                                    Severity: Major
                                                    Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                                                      Avoid deeply nested control flow statements.
                                                      Open

                                                                          if common_end_datetime_utc > max(energy_hourly.keys()):
                        common_end_datetime_utc = max(energy_hourly.keys())
                                                      Severity: Major
                                                      Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                                                        Avoid deeply nested control flow statements.
                                                        Open

                                                                            if common_end_datetime_utc > max(energy_hourly.keys()):
                        common_end_datetime_utc = max(energy_hourly.keys())
                                                        Severity: Major
                                                        Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                                                          Avoid deeply nested control flow statements.
                                                          Open

                                                                              if common_end_datetime_utc > max(energy_hourly.keys()):
                        common_end_datetime_utc = max(energy_hourly.keys())
                                                          Severity: Major
                                                          Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                                                            Avoid deeply nested control flow statements.
                                                            Open

                                                                                    if current_datetime_utc not in energy_shopfloor_hourly[shopfloor_id]:
                            energy_shopfloor_hourly[shopfloor_id][current_datetime_utc] = dict()
                        energy_item_id = row_energy_value[1]
                                                            Severity: Major
                                                            Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                                                              Avoid deeply nested control flow statements.
                                                              Open

                                                                                      if current_datetime_utc not in energy_store_hourly[store_id]:
                            energy_store_hourly[store_id][current_datetime_utc] = dict()
                        energy_item_id = row_energy_value[1]
                                                              Severity: Major
                                                              Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                                                                Avoid deeply nested control flow statements.
                                                                Open

                                                                                        for energy_item_id, actual_value in meta_data_dict.items():
                            aggregated_value['meta_data'][energy_item_id] = \
                                aggregated_value['meta_data'].get(energy_item_id, Decimal(0.0)) + actual_value
                                                                Severity: Major
                                                                Found in myems-aggregation/space_energy_input_item.py - About 45 mins to fix

                                                                  Avoid too many return statements within this function.
                                                                  Open

                                                                      return None
                                                                  Severity: Major
                                                                  Found in myems-aggregation/space_energy_input_item.py - About 30 mins to fix

                                                                    Avoid too many return statements within this function.
                                                                    Open

                                                                            return error_string
                                                                    Severity: Major
                                                                    Found in myems-aggregation/space_energy_input_item.py - About 30 mins to fix

                                                                      Avoid too many return statements within this function.
                                                                      Open

                                                                                  return error_string
                                                                      Severity: Major
                                                                      Found in myems-aggregation/space_energy_input_item.py - About 30 mins to fix

                                                                        Avoid too many return statements within this function.
                                                                        Open

                                                                                return error_string
                                                                        Severity: Major
                                                                        Found in myems-aggregation/space_energy_input_item.py - About 30 mins to fix

                                                                          Avoid too many return statements within this function.
                                                                          Open

                                                                                  return error_string
                                                                          Severity: Major
                                                                          Found in myems-aggregation/space_energy_input_item.py - About 30 mins to fix

                                                                            Avoid too many return statements within this function.
                                                                            Open

                                                                                    return None
                                                                            Severity: Major
                                                                            Found in myems-aggregation/space_energy_input_item.py - About 30 mins to fix

                                                                              Avoid too many return statements within this function.
                                                                              Open

                                                                                          return error_string
                                                                              Severity: Major
                                                                              Found in myems-aggregation/space_energy_input_item.py - About 30 mins to fix

                                                                                Avoid too many return statements within this function.
                                                                                Open

                                                                                        return error_string
                                                                                Severity: Major
                                                                                Found in myems-aggregation/space_energy_input_item.py - About 30 mins to fix

                                                                                  Avoid too many return statements within this function.
                                                                                  Open

                                                                                          return error_string
                                                                                  Severity: Major
                                                                                  Found in myems-aggregation/space_energy_input_item.py - About 30 mins to fix

                                                                                    Avoid too many return statements within this function.
                                                                                    Open

                                                                                            return error_string
                                                                                    Severity: Major
                                                                                    Found in myems-aggregation/space_energy_input_item.py - About 30 mins to fix

                                                                                      Avoid too many return statements within this function.
                                                                                      Open

                                                                                                  return error_string
                                                                                      Severity: Major
                                                                                      Found in myems-aggregation/space_energy_input_item.py - About 30 mins to fix

                                                                                        Avoid too many return statements within this function.
                                                                                        Open

                                                                                                return error_string
                                                                                        Severity: Major
                                                                                        Found in myems-aggregation/space_energy_input_item.py - About 30 mins to fix

                                                                                          Avoid too many return statements within this function.
                                                                                          Open

                                                                                                      return error_string
                                                                                          Severity: Major
                                                                                          Found in myems-aggregation/space_energy_input_item.py - About 30 mins to fix

                                                                                            Avoid too many return statements within this function.
                                                                                            Open

                                                                                                        return error_string
                                                                                            Severity: Major
                                                                                            Found in myems-aggregation/space_energy_input_item.py - About 30 mins to fix

                                                                                              Avoid too many return statements within this function.
                                                                                              Open

                                                                                                      return error_string
                                                                                              Severity: Major
                                                                                              Found in myems-aggregation/space_energy_input_item.py - About 30 mins to fix

                                                                                                Avoid too many return statements within this function.
                                                                                                Open

                                                                                                            return error_string
                                                                                                Severity: Major
                                                                                                Found in myems-aggregation/space_energy_input_item.py - About 30 mins to fix

                                                                                                  Avoid too many return statements within this function.
                                                                                                  Open

                                                                                                              return error_string
                                                                                                  Severity: Major
                                                                                                  Found in myems-aggregation/space_energy_input_item.py - About 30 mins to fix

                                                                                                    Avoid too many return statements within this function.
                                                                                                    Open

                                                                                                                return error_string
                                                                                                    Severity: Major
                                                                                                    Found in myems-aggregation/space_energy_input_item.py - About 30 mins to fix

                                                                                                      Avoid too many return statements within this function.
                                                                                                      Open

                                                                                                              return error_string
                                                                                                      Severity: Major
                                                                                                      Found in myems-aggregation/space_energy_input_item.py - About 30 mins to fix

                                                                                                        Avoid too many return statements within this function.
                                                                                                        Open

                                                                                                                return error_string
                                                                                                        Severity: Major
                                                                                                        Found in myems-aggregation/space_energy_input_item.py - About 30 mins to fix

                                                                                                          Avoid too many return statements within this function.
                                                                                                          Open

                                                                                                                  return None
                                                                                                          Severity: Major
                                                                                                          Found in myems-aggregation/space_energy_input_item.py - About 30 mins to fix

                                                                                                            Avoid too many return statements within this function.
                                                                                                            Open

                                                                                                                        return error_string
                                                                                                            Severity: Major
                                                                                                            Found in myems-aggregation/space_energy_input_item.py - About 30 mins to fix

                                                                                                              Similar blocks of code found in 2 locations. Consider refactoring.
                                                                                                              Open

                                                                                                              Severity: Major
                                                                                                              Found in myems-aggregation/space_energy_input_item.py and 1 other location - About 3 mos to fix
                                                                                                              myems-aggregation/space_energy_input_category.py on lines 0..1087

                                                                                                              Duplicated Code

                                                                                                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                                                                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                                                                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                                                                              Tuning

                                                                                                              This issue has a mass of 8094.

                                                                                                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                                                                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                                                                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                                                                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                                                                              Refactorings

                                                                                                              Further Reading

                                                                                                              There are no issues that match your filters.

                                                                                                              Category
                                                                                                              Status