Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-api/core/virtualpowerplant.py

Summary

Maintainability
F
2 wks
Test Coverage

File virtualpowerplant.py has 747 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import uuid
from datetime import datetime, timedelta
import falcon
import mysql.connector
import simplejson as json
Severity: Major
Found in myems-api/core/virtualpowerplant.py - About 1 day to fix

    Function on_get has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        def on_get(req, resp):
        if 'API-KEY' not in req.headers or \
                not isinstance(req.headers['API-KEY'], str) or \
                len(str.strip(req.headers['API-KEY'])) == 0:
            access_control(req)
    Severity: Minor
    Found in myems-api/core/virtualpowerplant.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function on_get has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        def on_get(req, resp, id_):
        if 'API-KEY' not in req.headers or \
                not isinstance(req.headers['API-KEY'], str) or \
                len(str.strip(req.headers['API-KEY'])) == 0:
            access_control(req)
    Severity: Minor
    Found in myems-api/core/virtualpowerplant.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function on_get has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        def on_get(req, resp, id_):
        if 'API-KEY' not in req.headers or \
                not isinstance(req.headers['API-KEY'], str) or \
                len(str.strip(req.headers['API-KEY'])) == 0:
            access_control(req)
    Severity: Minor
    Found in myems-api/core/virtualpowerplant.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function on_put has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def on_put(req, resp, id_):
        """Handles PUT requests"""
        admin_control(req)
        try:
            raw_json = req.stream.read().decode('utf-8')
    Severity: Minor
    Found in myems-api/core/virtualpowerplant.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function on_post has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def on_post(req, resp):
        """Handles POST requests"""
        admin_control(req)
        try:
            raw_json = req.stream.read().decode('utf-8')
    Severity: Minor
    Found in myems-api/core/virtualpowerplant.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function on_post has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def on_post(req, resp):
        """Handles POST requests"""
        admin_control(req)
        try:
            raw_json = req.stream.read().decode('utf-8')
    Severity: Minor
    Found in myems-api/core/virtualpowerplant.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function on_put has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def on_put(req, resp, id_):
        """Handles PUT requests"""
        admin_control(req)
        try:
            raw_json = req.stream.read().decode('utf-8')
    Severity: Minor
    Found in myems-api/core/virtualpowerplant.py - About 1 hr to fix

      Function on_post has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def on_post(req, resp):
        """Handles POST requests"""
        admin_control(req)
        try:
            raw_json = req.stream.read().decode('utf-8')
      Severity: Minor
      Found in myems-api/core/virtualpowerplant.py - About 1 hr to fix

        Function on_post has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def on_post(req, resp):
        """Handles POST requests"""
        admin_control(req)
        try:
            raw_json = req.stream.read().decode('utf-8')
        Severity: Minor
        Found in myems-api/core/virtualpowerplant.py - About 1 hr to fix

          Function on_get has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              def on_get(req, resp, id_):
        if 'API-KEY' not in req.headers or \
                not isinstance(req.headers['API-KEY'], str) or \
                len(str.strip(req.headers['API-KEY'])) == 0:
            access_control(req)
          Severity: Minor
          Found in myems-api/core/virtualpowerplant.py - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function on_post has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              def on_post(req, resp, id_):
        if 'API-KEY' not in req.headers or \
                not isinstance(req.headers['API-KEY'], str) or \
                len(str.strip(req.headers['API-KEY'])) == 0:
            access_control(req)
          Severity: Minor
          Found in myems-api/core/virtualpowerplant.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function on_post has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def on_post(req, resp, id_):
        """Handles POST requests"""
        admin_control(req)
        try:
            raw_json = req.stream.read().decode('utf-8')
          Severity: Minor
          Found in myems-api/core/virtualpowerplant.py - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function on_delete has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def on_delete(req, resp, id_, mid):
        admin_control(req)
        if not id_.isdigit() or int(id_) <= 0:
            raise falcon.HTTPError(status=falcon.HTTP_400, title='API.BAD_REQUEST',
                                   description='API.INVALID_VIRTUAL_POWER_PLANT_ID')
          Severity: Minor
          Found in myems-api/core/virtualpowerplant.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 24 locations. Consider refactoring.
          Open

          class VirtualPowerPlantMicrogridCollection:
    def __init__(self):
        """Initializes Class"""
        pass
          Severity: Major
          Found in myems-api/core/virtualpowerplant.py and 23 other locations - About 1 wk to fix
          myems-api/core/combinedequipment.py on lines 2098..2210
          myems-api/core/equipment.py on lines 1914..2028
          myems-api/core/meter.py on lines 1142..1254
          myems-api/core/shopfloor.py on lines 458..570
          myems-api/core/shopfloor.py on lines 1199..1311
          myems-api/core/shopfloor.py on lines 1563..1675
          myems-api/core/shopfloor.py on lines 1739..1851
          myems-api/core/space.py on lines 817..929
          myems-api/core/space.py on lines 993..1105
          myems-api/core/space.py on lines 1169..1281
          myems-api/core/space.py on lines 1534..1646
          myems-api/core/space.py on lines 2087..2199
          myems-api/core/space.py on lines 2262..2374
          myems-api/core/space.py on lines 2437..2549
          myems-api/core/space.py on lines 2612..2724
          myems-api/core/space.py on lines 3161..3273
          myems-api/core/space.py on lines 3337..3449
          myems-api/core/store.py on lines 1142..1254
          myems-api/core/store.py on lines 1506..1618
          myems-api/core/store.py on lines 1682..1794
          myems-api/core/tenant.py on lines 1246..1360
          myems-api/core/tenant.py on lines 1614..1728
          myems-api/core/tenant.py on lines 1792..1906

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 873.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 50 locations. Consider refactoring.
          Open

          class VirtualPowerPlantMicrogridItem:
    def __init__(self):
        """Initializes Class"""
        pass
          Severity: Major
          Found in myems-api/core/virtualpowerplant.py and 49 other locations - About 3 days to fix
          myems-api/core/combinedequipment.py on lines 713..771
          myems-api/core/combinedequipment.py on lines 1638..1696
          myems-api/core/combinedequipment.py on lines 1838..1896
          myems-api/core/combinedequipment.py on lines 2037..2095
          myems-api/core/combinedequipment.py on lines 2213..2271
          myems-api/core/distributioncircuit.py on lines 527..585
          myems-api/core/energystoragepowerstation.py on lines 705..763
          myems-api/core/equipment.py on lines 1458..1515
          myems-api/core/equipment.py on lines 1655..1713
          myems-api/core/equipment.py on lines 1853..1911
          myems-api/core/equipment.py on lines 2031..2088
          myems-api/core/meter.py on lines 1257..1314
          myems-api/core/microgrid.py on lines 4892..4950
          myems-api/core/sensor.py on lines 417..474
          myems-api/core/shopfloor.py on lines 573..631
          myems-api/core/shopfloor.py on lines 762..819
          myems-api/core/shopfloor.py on lines 950..1008
          myems-api/core/shopfloor.py on lines 1138..1196
          myems-api/core/shopfloor.py on lines 1314..1371
          myems-api/core/shopfloor.py on lines 1502..1560
          myems-api/core/shopfloor.py on lines 1678..1736
          myems-api/core/shopfloor.py on lines 1854..1911
          myems-api/core/space.py on lines 932..990
          myems-api/core/space.py on lines 1108..1166
          myems-api/core/space.py on lines 1284..1341
          myems-api/core/space.py on lines 1649..1707
          myems-api/core/space.py on lines 1838..1896
          myems-api/core/space.py on lines 2026..2084
          myems-api/core/space.py on lines 2202..2259
          myems-api/core/space.py on lines 2377..2434
          myems-api/core/space.py on lines 2552..2609
          myems-api/core/space.py on lines 2727..2784
          myems-api/core/space.py on lines 2915..2973
          myems-api/core/space.py on lines 3276..3334
          myems-api/core/space.py on lines 3452..3509
          myems-api/core/store.py on lines 705..762
          myems-api/core/store.py on lines 893..951
          myems-api/core/store.py on lines 1081..1139
          myems-api/core/store.py on lines 1257..1314
          myems-api/core/store.py on lines 1445..1503
          myems-api/core/store.py on lines 1621..1679
          myems-api/core/store.py on lines 1797..1854
          myems-api/core/tenant.py on lines 805..862
          myems-api/core/tenant.py on lines 995..1053
          myems-api/core/tenant.py on lines 1185..1243
          myems-api/core/tenant.py on lines 1363..1420
          myems-api/core/tenant.py on lines 1553..1611
          myems-api/core/tenant.py on lines 1731..1789
          myems-api/core/tenant.py on lines 1909..1966

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 388.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if row is None:
            raise falcon.HTTPError(status=falcon.HTTP_404, title='API.NOT_FOUND',
                                   description='API.VIRTUAL_POWER_PLANT_NOT_FOUND')
        else:
            meta_result = {"id": row[0],
          Severity: Major
          Found in myems-api/core/virtualpowerplant.py and 1 other location - About 6 hrs to fix
          myems-api/core/virtualpowerplant.py on lines 74..81

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 98.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          meta_result = {"id": row[0],
                               "name": row[1],
                               "uuid": row[2],
                               "cost_center": cost_center_dict.get(row[3], None),
                               "balancing_price_point": point_dict.get(row[4], None),
          Severity: Major
          Found in myems-api/core/virtualpowerplant.py and 1 other location - About 6 hrs to fix
          myems-api/core/virtualpowerplant.py on lines 266..277

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 98.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                      cursor.execute(add_values, (new_name,
                                        str(uuid.uuid4()),
                                        meta_result['cost_center_id'],
                                        meta_result['balancing_price_point_id'],
                                        meta_result['svg_id'],
          Severity: Major
          Found in myems-api/core/virtualpowerplant.py and 3 other locations - About 1 hr to fix
          myems-api/core/advancedreport.py on lines 643..648
          myems-api/core/command.py on lines 676..681
          myems-api/core/datasource.py on lines 819..824

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status