Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-api/excelexporters/combinedequipmentstatistics.py

Summary

Maintainability
F
2 mos
Test Coverage

Function generate_excel has a Cognitive Complexity of 164 (exceeds 5 allowed). Consider refactoring.
Open

def generate_excel(report,
                   name,
                   base_period_start_datetime_local,
                   base_period_end_datetime_local,
                   reporting_start_datetime_local,
Severity: Minor
Found in myems-api/excelexporters/combinedequipmentstatistics.py - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File combinedequipmentstatistics.py has 676 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import base64
from core.utilities import get_translation
import os
import re
import uuid
Severity: Major
Found in myems-api/excelexporters/combinedequipmentstatistics.py - About 1 day to fix

    Function generate_excel has 81 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def generate_excel(report,
                   name,
                   base_period_start_datetime_local,
                   base_period_end_datetime_local,
                   reporting_start_datetime_local,
    Severity: Major
    Found in myems-api/excelexporters/combinedequipmentstatistics.py - About 3 hrs to fix

      Consider simplifying this complex logical expression.
      Open

          if 'parameters' not in report.keys() or \
            report['parameters'] is None or \
            'names' not in report['parameters'].keys() or \
            report['parameters']['names'] is None or \
            len(report['parameters']['names']) == 0 or \
      Severity: Critical
      Found in myems-api/excelexporters/combinedequipmentstatistics.py - About 2 hrs to fix

        Function generate_excel has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def generate_excel(report,
        Severity: Major
        Found in myems-api/excelexporters/combinedequipmentstatistics.py - About 1 hr to fix

          Consider simplifying this complex logical expression.
          Open

              if "associated_equipment" not in report.keys() or \
            "energy_category_names" not in report['associated_equipment'].keys() or \
            len(report['associated_equipment']["energy_category_names"]) == 0 \
            or 'associated_equipment_names_array' not in report['associated_equipment'].keys() \
            or report['associated_equipment']['associated_equipment_names_array'] is None \
          Severity: Major
          Found in myems-api/excelexporters/combinedequipmentstatistics.py - About 1 hr to fix

            Function export has 8 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def export(report,
            Severity: Major
            Found in myems-api/excelexporters/combinedequipmentstatistics.py - About 1 hr to fix

              Avoid deeply nested control flow statements.
              Open

                                  for j in range(0, ca_len):
                        current_col_number += 1
                        col = format_cell.get_column_letter(current_col_number)

                        ws[col + str(current_row_number)].font = title_font
              Severity: Major
              Found in myems-api/excelexporters/combinedequipmentstatistics.py - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                    for j in range(0, base_period_data_ca_len):
                        current_col_number += 1
                        col = format_cell.get_column_letter(current_col_number)

                        ws[col + str(current_row_number)].font = title_font
                Severity: Major
                Found in myems-api/excelexporters/combinedequipmentstatistics.py - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                      for j in range(0, reporting_period_data_ca_len):
                        current_col_number += 1
                        col = format_cell.get_column_letter(current_col_number)

                        ws[col + str(current_row_number)].font = title_font
                  Severity: Major
                  Found in myems-api/excelexporters/combinedequipmentstatistics.py - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                        for j in range(len(line.series)):
                        line.series[j].marker.symbol = "circle"
                        line.series[j].smooth = True
                    line.x_axis.crosses = 'min'
                    Severity: Major
                    Found in myems-api/excelexporters/combinedequipmentstatistics.py - About 45 mins to fix

                      Identical blocks of code found in 12 locations. Consider refactoring.
                      Open

                          if "timestamps" not in reporting_period_data.keys() or \
            reporting_period_data['timestamps'] is None or \
            len(reporting_period_data['timestamps']) == 0:
        pass
    else:
                      Severity: Major
                      Found in myems-api/excelexporters/combinedequipmentstatistics.py and 11 other locations - About 1 mo to fix
                      myems-api/excelexporters/combinedequipmentenergycategory.py on lines 524..805
                      myems-api/excelexporters/equipmentenergycategory.py on lines 518..799
                      myems-api/excelexporters/equipmentstatistics.py on lines 345..626
                      myems-api/excelexporters/shopfloorenergycategory.py on lines 658..939
                      myems-api/excelexporters/shopfloorstatistics.py on lines 452..733
                      myems-api/excelexporters/spaceenergycategory.py on lines 729..1009
                      myems-api/excelexporters/spacestatistics.py on lines 460..741
                      myems-api/excelexporters/storeenergycategory.py on lines 667..948
                      myems-api/excelexporters/storestatistics.py on lines 451..732
                      myems-api/excelexporters/tenantenergycategory.py on lines 630..910
                      myems-api/excelexporters/tenantstatistics.py on lines 461..745

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 4027.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          for i, value in enumerate(category):
        row = i * 2 + 9
        ws['B' + str(row)].font = name_font
        ws['B' + str(row)].alignment = c_c_alignment
        ws['B' + str(row)] = reporting_period_data['names'][i] + " (" + reporting_period_data['units'][i] + " )"
                      Severity: Major
                      Found in myems-api/excelexporters/combinedequipmentstatistics.py and 1 other location - About 3 wks to fix
                      myems-api/excelexporters/equipmentstatistics.py on lines 245..333

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 2200.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                          if "associated_equipment" not in report.keys() or \
            "energy_category_names" not in report['associated_equipment'].keys() or \
            len(report['associated_equipment']["energy_category_names"]) == 0 \
            or 'associated_equipment_names_array' not in report['associated_equipment'].keys() \
            or report['associated_equipment']['associated_equipment_names_array'] is None \
                      Severity: Major
                      Found in myems-api/excelexporters/combinedequipmentstatistics.py and 1 other location - About 1 wk to fix
                      myems-api/excelexporters/combinedequipmentenergycategory.py on lines 808..856

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 855.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 10 locations. Consider refactoring.
                      Open

                          if "names" not in reporting_period_data.keys() or \
            reporting_period_data['names'] is None or \
            len(reporting_period_data['names']) == 0:
        filename = str(uuid.uuid4()) + '.xlsx'
        wb.save(filename)
                      Severity: Major
                      Found in myems-api/excelexporters/combinedequipmentstatistics.py and 9 other locations - About 4 hrs to fix
                      myems-api/excelexporters/combinedequipmentload.py on lines 190..196
                      myems-api/excelexporters/equipmentload.py on lines 186..191
                      myems-api/excelexporters/equipmentstatistics.py on lines 188..193
                      myems-api/excelexporters/shopfloorload.py on lines 190..195
                      myems-api/excelexporters/shopfloorstatistics.py on lines 190..195
                      myems-api/excelexporters/spacestatistics.py on lines 188..193
                      myems-api/excelexporters/storeload.py on lines 190..195
                      myems-api/excelexporters/storestatistics.py on lines 189..194
                      myems-api/excelexporters/tenantstatistics.py on lines 190..195

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 79.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status