Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-api/excelexporters/energystoragepowerstationreportingparameters.py

Summary

Maintainability
C
1 day
Test Coverage

Function generate_excel has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

def generate_excel(report,
                   name,
                   reporting_start_datetime_local,
                   reporting_end_datetime_local,
                   language):
Severity: Minor
Found in myems-api/excelexporters/energystoragepowerstationreportingparameters.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

    if 'parameters' not in report.keys() or \
            report['parameters'] is None or \
            'names' not in report['parameters'].keys() or \
            report['parameters']['names'] is None or \
            len(report['parameters']['names']) == 0 or \
Severity: Critical
Found in myems-api/excelexporters/energystoragepowerstationreportingparameters.py - About 2 hrs to fix

    Function generate_excel has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def generate_excel(report,
                   name,
                   reporting_start_datetime_local,
                   reporting_end_datetime_local,
                   language):
    Severity: Minor
    Found in myems-api/excelexporters/energystoragepowerstationreportingparameters.py - About 1 hr to fix

      Function generate_excel has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def generate_excel(report,
      Severity: Minor
      Found in myems-api/excelexporters/energystoragepowerstationreportingparameters.py - About 35 mins to fix

        Function export has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def export(report, name, reporting_start_datetime_local, reporting_end_datetime_local, language):
        Severity: Minor
        Found in myems-api/excelexporters/energystoragepowerstationreportingparameters.py - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status