Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-api/excelexporters/metercomparison.py

Summary

Maintainability
F
3 wks
Test Coverage

Function generate_excel has a Cognitive Complexity of 95 (exceeds 5 allowed). Consider refactoring.
Open

def generate_excel(report, name1, name2, reporting_start_datetime_local, reporting_end_datetime_local, period_type,
                   language):
    trans = get_translation(language)
    trans.install()
    _ = trans.gettext
Severity: Minor
Found in myems-api/excelexporters/metercomparison.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File metercomparison.py has 561 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import base64
from core.utilities import get_translation
import os
import re
import uuid
Severity: Major
Found in myems-api/excelexporters/metercomparison.py - About 1 day to fix

    Consider simplifying this complex logical expression.
    Open

        if 'parameters1' not in report.keys() or \
            report['parameters1'] is None or \
            'names' not in report['parameters1'].keys() or \
            report['parameters1']['names'] is None or \
            len(report['parameters1']['names']) == 0 or \
    Severity: Critical
    Found in myems-api/excelexporters/metercomparison.py - About 2 hrs to fix

      Consider simplifying this complex logical expression.
      Open

          if 'parameters2' not in report.keys() or \
            report['parameters2'] is None or \
            'names' not in report['parameters2'].keys() or \
            report['parameters2']['names'] is None or \
            len(report['parameters2']['names']) == 0 or \
      Severity: Critical
      Found in myems-api/excelexporters/metercomparison.py - About 2 hrs to fix

        Function generate_excel has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        def generate_excel(report, name1, name2, reporting_start_datetime_local, reporting_end_datetime_local, period_type,
                   language):
    trans = get_translation(language)
    trans.install()
    _ = trans.gettext
        Severity: Major
        Found in myems-api/excelexporters/metercomparison.py - About 2 hrs to fix

          Function generate_excel has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def generate_excel(report, name1, name2, reporting_start_datetime_local, reporting_end_datetime_local, period_type,
          Severity: Major
          Found in myems-api/excelexporters/metercomparison.py - About 50 mins to fix

            Function export has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def export(result, name1, name2, reporting_start_datetime_local, reporting_end_datetime_local, period_type, language):
            Severity: Major
            Found in myems-api/excelexporters/metercomparison.py - About 50 mins to fix

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      for i in range(0, parameters_names_len):

            if len(parameters_data1['timestamps'][i]) == 0:
                continue
              Severity: Major
              Found in myems-api/excelexporters/metercomparison.py and 2 other locations - About 5 days to fix
              myems-api/excelexporters/metercomparison.py on lines 610..650
              myems-api/excelexporters/metertrend.py on lines 353..393

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 584.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      for i in range(0, parameters_names_len):

            if len(parameters_data2['timestamps'][i]) == 0:
                continue
              Severity: Major
              Found in myems-api/excelexporters/metercomparison.py and 2 other locations - About 5 days to fix
              myems-api/excelexporters/metercomparison.py on lines 498..538
              myems-api/excelexporters/metertrend.py on lines 353..393

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 584.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 6 locations. Consider refactoring.
              Open

                  if 'parameters1' not in report.keys() or \
            report['parameters1'] is None or \
            'names' not in report['parameters1'].keys() or \
            report['parameters1']['names'] is None or \
            len(report['parameters1']['names']) == 0 or \
              Severity: Major
              Found in myems-api/excelexporters/metercomparison.py and 5 other locations - About 2 days to fix
              myems-api/excelexporters/combinedequipmentefficiency.py on lines 311..324
              myems-api/excelexporters/combinedequipmentenergyitem.py on lines 658..671
              myems-api/excelexporters/equipmentefficiency.py on lines 306..319
              myems-api/excelexporters/metercomparison.py on lines 414..426
              myems-api/excelexporters/spaceefficiency.py on lines 258..271

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 230.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 6 locations. Consider refactoring.
              Open

                  if 'parameters2' not in report.keys() or \
            report['parameters2'] is None or \
            'names' not in report['parameters2'].keys() or \
            report['parameters2']['names'] is None or \
            len(report['parameters2']['names']) == 0 or \
              Severity: Major
              Found in myems-api/excelexporters/metercomparison.py and 5 other locations - About 2 days to fix
              myems-api/excelexporters/combinedequipmentefficiency.py on lines 311..324
              myems-api/excelexporters/combinedequipmentenergyitem.py on lines 658..671
              myems-api/excelexporters/equipmentefficiency.py on lines 306..319
              myems-api/excelexporters/metercomparison.py on lines 400..412
              myems-api/excelexporters/spaceefficiency.py on lines 258..271

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 230.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                          for j in range(0, time_len):
                row = str(start_detail_data_row_num + 1 + j)
                # col = chr(ord('B') + i)
                ws[col + row].font = title_font
                ws[col + row].alignment = c_c_alignment
              Severity: Major
              Found in myems-api/excelexporters/metercomparison.py and 2 other locations - About 1 day to fix
              myems-api/excelexporters/metercomparison.py on lines 299..305
              myems-api/excelexporters/metercomparison.py on lines 342..348

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 123.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                          for j in range(0, time_len):
                row = str(start_detail_data_row_num + 1 + j)
                # col = chr(ord('B') + i)
                ws[col + row].font = title_font
                ws[col + row].alignment = c_c_alignment
              Severity: Major
              Found in myems-api/excelexporters/metercomparison.py and 2 other locations - About 1 day to fix
              myems-api/excelexporters/metercomparison.py on lines 299..305
              myems-api/excelexporters/metercomparison.py on lines 321..327

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 123.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                          for j in range(0, time_len):
                row = str(start_detail_data_row_num + 1 + j)
                # col = chr(ord('B') + i)
                ws[col + row].font = title_font
                ws[col + row].alignment = c_c_alignment
              Severity: Major
              Found in myems-api/excelexporters/metercomparison.py and 2 other locations - About 1 day to fix
              myems-api/excelexporters/metercomparison.py on lines 321..327
              myems-api/excelexporters/metercomparison.py on lines 342..348

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 123.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          for i in range(0, len(time)):
                col = 'B'
                row = str(start_detail_data_row_num + 1 + i)
                # col = chr(ord('B') + i)
                ws[col + row].font = title_font
              Severity: Major
              Found in myems-api/excelexporters/metercomparison.py and 1 other location - About 7 hrs to fix
              myems-api/excelexporters/combinedequipmentenergycategory.py on lines 899..906

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 121.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          ws[col + str(start_detail_data_row_num)] = name2 + report['meter2']['energy_category_name'] + \
                " (" + report['meter2']['unit_of_measure'] + ")"
              Severity: Major
              Found in myems-api/excelexporters/metercomparison.py and 1 other location - About 3 hrs to fix
              myems-api/excelexporters/metercomparison.py on lines 291..292

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 69.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          ws[col + str(start_detail_data_row_num)] = name1 + report['meter1']['energy_category_name'] + \
                " (" + report['meter1']['unit_of_measure'] + ")"
              Severity: Major
              Found in myems-api/excelexporters/metercomparison.py and 1 other location - About 3 hrs to fix
              myems-api/excelexporters/metercomparison.py on lines 313..314

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 69.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 4 locations. Consider refactoring.
              Open

                      for i in range(0, parameters_names_len):
            if len(parameters_data['timestamps'][i]) == 0:
                continue
            parameters_parameters_datas_len += 1
              Severity: Major
              Found in myems-api/excelexporters/metercomparison.py and 3 other locations - About 1 hr to fix
              myems-api/excelexporters/metercomparison.py on lines 253..256
              myems-api/excelexporters/metersubmetersbalance.py on lines 232..235
              myems-api/excelexporters/metertrend.py on lines 185..188

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 4 locations. Consider refactoring.
              Open

                      for i in range(0, parameters_names_len):
            if len(parameters_data['timestamps'][i]) == 0:
                continue
            parameters_parameters_datas_len += 1
              Severity: Major
              Found in myems-api/excelexporters/metercomparison.py and 3 other locations - About 1 hr to fix
              myems-api/excelexporters/metercomparison.py on lines 247..250
              myems-api/excelexporters/metersubmetersbalance.py on lines 232..235
              myems-api/excelexporters/metertrend.py on lines 185..188

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if len(time) > 0:
            has_data = True
            max_row = start_detail_data_row_num + len(time)
              Severity: Minor
              Found in myems-api/excelexporters/metercomparison.py and 1 other location - About 40 mins to fix
              myems-api/excelexporters/combinedequipmentenergycategory.py on lines 894..896

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 34.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status