Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-api/excelexporters/metersubmetersbalance.py

Summary

Maintainability
F
3 days
Test Coverage

Function generate_excel has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
Open

def generate_excel(report, name, reporting_start_datetime_local, reporting_end_datetime_local, period_type, language):

    trans = get_translation(language)
    trans.install()
    _ = trans.gettext
Severity: Minor
Found in myems-api/excelexporters/metersubmetersbalance.py - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File metersubmetersbalance.py has 373 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import base64
from core.utilities import get_translation
import os
import re
import uuid
Severity: Minor
Found in myems-api/excelexporters/metersubmetersbalance.py - About 4 hrs to fix

    Consider simplifying this complex logical expression.
    Open

        if 'parameters' not in report.keys() or \
            report['parameters'] is None or \
            'names' not in report['parameters'].keys() or \
            report['parameters']['names'] is None or \
            len(report['parameters']['names']) == 0 or \
    Severity: Critical
    Found in myems-api/excelexporters/metersubmetersbalance.py - About 2 hrs to fix

      Function generate_excel has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      def generate_excel(report, name, reporting_start_datetime_local, reporting_end_datetime_local, period_type, language):

    trans = get_translation(language)
    trans.install()
    _ = trans.gettext
      Severity: Minor
      Found in myems-api/excelexporters/metersubmetersbalance.py - About 1 hr to fix

        Function export has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def export(result, name, reporting_start_datetime_local, reporting_end_datetime_local, period_type, language):
        Severity: Minor
        Found in myems-api/excelexporters/metersubmetersbalance.py - About 45 mins to fix

          Function generate_excel has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def generate_excel(report, name, reporting_start_datetime_local, reporting_end_datetime_local, period_type, language):
          Severity: Minor
          Found in myems-api/excelexporters/metersubmetersbalance.py - About 45 mins to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                        ws['C' + str(current_row_number)] = report['meter']['energy_category_name'] + " (" + report['meter'][
                'unit_of_measure'] + ")"
            Severity: Major
            Found in myems-api/excelexporters/metersubmetersbalance.py and 2 other locations - About 3 hrs to fix
            myems-api/excelexporters/meterenergy.py on lines 329..330
            myems-api/excelexporters/metersubmetersbalance.py on lines 262..263

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                            ws['C' + str(current_row_number)] = report['meter']['energy_category_name'] + " (" + report['meter'][
                    'unit_of_measure'] + ")"
            Severity: Major
            Found in myems-api/excelexporters/metersubmetersbalance.py and 2 other locations - About 3 hrs to fix
            myems-api/excelexporters/meterenergy.py on lines 329..330
            myems-api/excelexporters/metersubmetersbalance.py on lines 174..175

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 4 locations. Consider refactoring.
            Open

                        for i in range(0, parameters_names_len):
                if len(parameters_data['timestamps'][i]) == 0:
                    continue
                parameters_parameters_datas_len += 1
            Severity: Major
            Found in myems-api/excelexporters/metersubmetersbalance.py and 3 other locations - About 1 hr to fix
            myems-api/excelexporters/metercomparison.py on lines 247..250
            myems-api/excelexporters/metercomparison.py on lines 253..256
            myems-api/excelexporters/metertrend.py on lines 185..188

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                        ws['C' + str(current_row_number)] = round2(reporting_period_data['difference_in_category'], 2)
            Severity: Major
            Found in myems-api/excelexporters/metersubmetersbalance.py and 3 other locations - About 30 mins to fix
            myems-api/excelexporters/metersubmetersbalance.py on lines 187..187
            myems-api/excelexporters/metersubmetersbalance.py on lines 199..199
            myems-api/excelexporters/metersubmetersbalance.py on lines 308..309

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 32.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                        ws['C' + str(current_row_number)] = round2(reporting_period_data['master_meter_consumption_in_category'], 2)
            Severity: Major
            Found in myems-api/excelexporters/metersubmetersbalance.py and 3 other locations - About 30 mins to fix
            myems-api/excelexporters/metersubmetersbalance.py on lines 199..199
            myems-api/excelexporters/metersubmetersbalance.py on lines 211..211
            myems-api/excelexporters/metersubmetersbalance.py on lines 308..309

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 32.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                            ws['C' + str(current_row_number)] = \
                    round2(reporting_period_data['master_meter_consumption_in_category'], 2)
            Severity: Major
            Found in myems-api/excelexporters/metersubmetersbalance.py and 3 other locations - About 30 mins to fix
            myems-api/excelexporters/metersubmetersbalance.py on lines 187..187
            myems-api/excelexporters/metersubmetersbalance.py on lines 199..199
            myems-api/excelexporters/metersubmetersbalance.py on lines 211..211

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 32.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                        ws['C' + str(current_row_number)] = round2(reporting_period_data['submeters_consumption_in_category'], 2)
            Severity: Major
            Found in myems-api/excelexporters/metersubmetersbalance.py and 3 other locations - About 30 mins to fix
            myems-api/excelexporters/metersubmetersbalance.py on lines 187..187
            myems-api/excelexporters/metersubmetersbalance.py on lines 211..211
            myems-api/excelexporters/metersubmetersbalance.py on lines 308..309

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 32.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status