Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-api/excelexporters/spaceenergycategory.py

Summary

Maintainability
F
3 mos
Test Coverage

Function generate_excel has a Cognitive Complexity of 213 (exceeds 5 allowed). Consider refactoring.
Open

def generate_excel(report,
                   name,
                   base_period_start_datetime_local,
                   base_period_end_datetime_local,
                   reporting_start_datetime_local,
Severity: Minor
Found in myems-api/excelexporters/spaceenergycategory.py - About 4 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File spaceenergycategory.py has 953 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import base64
from core.utilities import get_translation
import os
import re
import uuid
Severity: Major
Found in myems-api/excelexporters/spaceenergycategory.py - About 2 days to fix

    Consider simplifying this complex logical expression.
    Open

        if 'parameters' not in report.keys() or \
            report['parameters'] is None or \
            'names' not in report['parameters'].keys() or \
            report['parameters']['names'] is None or \
            len(report['parameters']['names']) == 0 or \
    Severity: Critical
    Found in myems-api/excelexporters/spaceenergycategory.py - About 2 hrs to fix

      Consider simplifying this complex logical expression.
      Open

          if "non_working_days_subtotals" not in report['base_period'].keys() or \
            report['base_period']['non_working_days_subtotals'] is None or \
            len(report['base_period']['non_working_days_subtotals']) == 0 or \
            "working_days_subtotals" not in report['base_period'].keys() or \
            report['base_period']['working_days_subtotals'] is None or \
      Severity: Critical
      Found in myems-api/excelexporters/spaceenergycategory.py - About 2 hrs to fix

        Function generate_excel has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        def generate_excel(report,
                   name,
                   base_period_start_datetime_local,
                   base_period_end_datetime_local,
                   reporting_start_datetime_local,
        Severity: Minor
        Found in myems-api/excelexporters/spaceenergycategory.py - About 1 hr to fix

          Function generate_excel has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def generate_excel(report,
          Severity: Major
          Found in myems-api/excelexporters/spaceenergycategory.py - About 1 hr to fix

            Consider simplifying this complex logical expression.
            Open

                if "child_space" not in report.keys() or "energy_category_names" not in report['child_space'].keys() or \
            len(report['child_space']["energy_category_names"]) == 0 \
            or 'child_space_names_array' not in report['child_space'].keys() \
            or report['child_space']['energy_category_names'] is None \
            or len(report['child_space']['child_space_names_array']) == 0 \
            Severity: Major
            Found in myems-api/excelexporters/spaceenergycategory.py - About 1 hr to fix

              Function export has 8 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def export(report,
              Severity: Major
              Found in myems-api/excelexporters/spaceenergycategory.py - About 1 hr to fix

                Avoid deeply nested control flow statements.
                Open

                                    for j in range(0, ca_len):
                        current_col_number += 1
                        col = format_cell.get_column_letter(current_col_number)

                        ws[col + str(current_row_number)].font = title_font
                Severity: Major
                Found in myems-api/excelexporters/spaceenergycategory.py - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                      for j in range(len(line.series)):
                        line.series[j].marker.symbol = "circle"
                        line.series[j].smooth = True
                    line.x_axis.crosses = 'min'
                  Severity: Major
                  Found in myems-api/excelexporters/spaceenergycategory.py - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                        for j in range(0, base_period_data_ca_len):
                        current_col_number += 1
                        col = format_cell.get_column_letter(current_col_number)

                        ws[col + str(current_row_number)].font = title_font
                    Severity: Major
                    Found in myems-api/excelexporters/spaceenergycategory.py - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                          for j in range(0, reporting_period_data_ca_len):
                        current_col_number += 1
                        col = format_cell.get_column_letter(current_col_number)

                        ws[col + str(current_row_number)].font = title_font
                      Severity: Major
                      Found in myems-api/excelexporters/spaceenergycategory.py - About 45 mins to fix

                        Consider simplifying this complex logical expression.
                        Open

                            if "non_working_days_subtotals" not in report['reporting_period'].keys() or \
            report['reporting_period']['non_working_days_subtotals'] is None or \
            len(report['reporting_period']['non_working_days_subtotals']) == 0 or \
            "working_days_subtotals" not in report['reporting_period'].keys() or \
            report['reporting_period']['working_days_subtotals'] is None or \
                        Severity: Major
                        Found in myems-api/excelexporters/spaceenergycategory.py - About 40 mins to fix

                          Identical blocks of code found in 12 locations. Consider refactoring.
                          Open

                              if "timestamps" not in reporting_period_data.keys() or \
            reporting_period_data['timestamps'] is None or \
            len(reporting_period_data['timestamps']) == 0:
        pass
    else:
                          Severity: Major
                          Found in myems-api/excelexporters/spaceenergycategory.py and 11 other locations - About 1 mo to fix
                          myems-api/excelexporters/combinedequipmentenergycategory.py on lines 524..805
                          myems-api/excelexporters/combinedequipmentstatistics.py on lines 340..621
                          myems-api/excelexporters/equipmentenergycategory.py on lines 518..799
                          myems-api/excelexporters/equipmentstatistics.py on lines 345..626
                          myems-api/excelexporters/shopfloorenergycategory.py on lines 658..939
                          myems-api/excelexporters/shopfloorstatistics.py on lines 452..733
                          myems-api/excelexporters/spacestatistics.py on lines 460..741
                          myems-api/excelexporters/storeenergycategory.py on lines 667..948
                          myems-api/excelexporters/storestatistics.py on lines 451..732
                          myems-api/excelexporters/tenantenergycategory.py on lines 630..910
                          myems-api/excelexporters/tenantstatistics.py on lines 461..745

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 4027.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 4 locations. Consider refactoring.
                          Open

                              if "non_working_days_subtotals" not in report['base_period'].keys() or \
            report['base_period']['non_working_days_subtotals'] is None or \
            len(report['base_period']['non_working_days_subtotals']) == 0 or \
            "working_days_subtotals" not in report['base_period'].keys() or \
            report['base_period']['working_days_subtotals'] is None or \
                          Severity: Major
                          Found in myems-api/excelexporters/spaceenergycategory.py and 3 other locations - About 1 wk to fix
                          myems-api/excelexporters/shopfloorenergycategory.py on lines 530..592
                          myems-api/excelexporters/storeenergycategory.py on lines 535..597
                          myems-api/excelexporters/tenantenergycategory.py on lines 504..566

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 1130.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 4 locations. Consider refactoring.
                          Open

                              if "non_working_days_subtotals" not in report['reporting_period'].keys() or \
            report['reporting_period']['non_working_days_subtotals'] is None or \
            len(report['reporting_period']['non_working_days_subtotals']) == 0 or \
            "working_days_subtotals" not in report['reporting_period'].keys() or \
            report['reporting_period']['working_days_subtotals'] is None or \
                          Severity: Major
                          Found in myems-api/excelexporters/spaceenergycategory.py and 3 other locations - About 1 wk to fix
                          myems-api/excelexporters/shopfloorenergycategory.py on lines 594..652
                          myems-api/excelexporters/storeenergycategory.py on lines 599..657
                          myems-api/excelexporters/tenantenergycategory.py on lines 568..626

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 1082.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 6 locations. Consider refactoring.
                          Open

                              if "subtotals_in_kgce" not in reporting_period_data.keys() or \
            reporting_period_data['subtotals_in_kgce'] is None or \
            len(reporting_period_data['subtotals_in_kgce']) == 0:
        pass
    else:
                          Severity: Major
                          Found in myems-api/excelexporters/spaceenergycategory.py and 5 other locations - About 1 wk to fix
                          myems-api/excelexporters/shopfloorenergycategory.py on lines 397..458
                          myems-api/excelexporters/shopfloorenergycategory.py on lines 466..526
                          myems-api/excelexporters/spaceenergycategory.py on lines 442..502
                          myems-api/excelexporters/tenantenergycategory.py on lines 376..437
                          myems-api/excelexporters/tenantenergycategory.py on lines 440..500

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 839.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 6 locations. Consider refactoring.
                          Open

                              if "subtotals_in_kgco2e" not in reporting_period_data.keys() or \
            reporting_period_data['subtotals_in_kgco2e'] is None or \
            len(reporting_period_data['subtotals_in_kgco2e']) == 0:
        pass
    else:
                          Severity: Major
                          Found in myems-api/excelexporters/spaceenergycategory.py and 5 other locations - About 1 wk to fix
                          myems-api/excelexporters/shopfloorenergycategory.py on lines 397..458
                          myems-api/excelexporters/shopfloorenergycategory.py on lines 466..526
                          myems-api/excelexporters/spaceenergycategory.py on lines 378..439
                          myems-api/excelexporters/tenantenergycategory.py on lines 376..437
                          myems-api/excelexporters/tenantenergycategory.py on lines 440..500

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 839.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  for i in range(0, ca_len):
            col = chr(ord('C') + i)
            ws[col + '8'].fill = table_fill
            ws[col + '8'].font = name_font
            ws[col + '8'].alignment = c_c_alignment
                          Severity: Major
                          Found in myems-api/excelexporters/spaceenergycategory.py and 1 other location - About 4 days to fix
                          myems-api/excelexporters/spaceincome.py on lines 217..241

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 502.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  ws[tco2e_col + '10'] = round2(reporting_period_data['total_in_kgco2e_per_unit_area'] / 1000, 2) \
            if reporting_period_data['total_in_kgco2e_per_unit_area'] is not None else ''
                          Severity: Major
                          Found in myems-api/excelexporters/spaceenergycategory.py and 1 other location - About 2 hrs to fix
                          myems-api/excelexporters/spaceenergycategory.py on lines 259..260

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 52.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  ws[tce_col + '10'] = round2(reporting_period_data['total_in_kgce_per_unit_area'] / 1000, 2) \
            if reporting_period_data['total_in_kgce_per_unit_area'] is not None else ''
                          Severity: Major
                          Found in myems-api/excelexporters/spaceenergycategory.py and 1 other location - About 2 hrs to fix
                          myems-api/excelexporters/spaceenergycategory.py on lines 284..285

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 52.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status