Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-api/excelexporters/spaceenergyitem.py

Summary

Maintainability
F
2 mos
Test Coverage

Function generate_excel has a Cognitive Complexity of 146 (exceeds 5 allowed). Consider refactoring.
Open

def generate_excel(report,
                   name,
                   base_period_start_datetime_local,
                   base_period_end_datetime_local,
                   reporting_start_datetime_local,
Severity: Minor
Found in myems-api/excelexporters/spaceenergyitem.py - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File spaceenergyitem.py has 706 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import base64
from core.utilities import get_translation
import os
import re
import uuid
Severity: Major
Found in myems-api/excelexporters/spaceenergyitem.py - About 1 day to fix

    Consider simplifying this complex logical expression.
    Open

        if 'parameters' not in report.keys() or \
            report['parameters'] is None or \
            'names' not in report['parameters'].keys() or \
            report['parameters']['names'] is None or \
            len(report['parameters']['names']) == 0 or \
    Severity: Critical
    Found in myems-api/excelexporters/spaceenergyitem.py - About 2 hrs to fix

      Function generate_excel has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      def generate_excel(report,
                   name,
                   base_period_start_datetime_local,
                   base_period_end_datetime_local,
                   reporting_start_datetime_local,
      Severity: Major
      Found in myems-api/excelexporters/spaceenergyitem.py - About 2 hrs to fix

        Function export has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def export(report,
        Severity: Major
        Found in myems-api/excelexporters/spaceenergyitem.py - About 1 hr to fix

          Function generate_excel has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def generate_excel(report,
          Severity: Major
          Found in myems-api/excelexporters/spaceenergyitem.py - About 1 hr to fix

            Consider simplifying this complex logical expression.
            Open

                if "child_space" not in report.keys() or "energy_item_names" not in report['child_space'].keys() or \
            len(report['child_space']["energy_item_names"]) == 0 \
            or 'child_space_names_array' not in report['child_space'].keys() \
            or report['child_space']['child_space_names_array'] is None \
            or len(report['child_space']['child_space_names_array']) == 0 \
            Severity: Major
            Found in myems-api/excelexporters/spaceenergyitem.py - About 1 hr to fix

              Identical blocks of code found in 6 locations. Consider refactoring.
              Open

                  if not is_base_period_timestamp_exists_flag:
        if has_values_data and has_timestamps_data:
            ca_len = len(reporting_period_data['names'])
            time = reporting_period_data['timestamps'][0]
            real_timestamps_len = timestamps_data_not_equal_0(report['parameters']['timestamps'])
              Severity: Major
              Found in myems-api/excelexporters/spaceenergyitem.py and 5 other locations - About 1 mo to fix
              myems-api/excelexporters/combinedequipmentenergyitem.py on lines 333..602
              myems-api/excelexporters/equipmentenergyitem.py on lines 325..594
              myems-api/excelexporters/shopfloorenergyitem.py on lines 345..614
              myems-api/excelexporters/storeenergyitem.py on lines 345..614
              myems-api/excelexporters/tenantenergyitem.py on lines 345..614

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 3907.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  if "names" not in reporting_period_data.keys() or \
            reporting_period_data['names'] is None or \
            len(reporting_period_data['names']) == 0:
        pass
    else:
              Severity: Major
              Found in myems-api/excelexporters/spaceenergyitem.py and 2 other locations - About 2 wks to fix
              myems-api/excelexporters/storeenergyitem.py on lines 185..326
              myems-api/excelexporters/tenantenergyitem.py on lines 185..326

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 2018.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 9 locations. Consider refactoring.
              Open

                  if 'timestamps' not in reporting_period_data.keys() or \
            reporting_period_data['timestamps'] is None or \
            len(reporting_period_data['timestamps']) == 0 or \
            len(reporting_period_data['timestamps'][0]) == 0:
        has_timestamps_data = False
              Severity: Major
              Found in myems-api/excelexporters/spaceenergyitem.py and 8 other locations - About 4 hrs to fix
              myems-api/excelexporters/combinedequipmentefficiency.py on lines 335..339
              myems-api/excelexporters/combinedequipmentenergyitem.py on lines 327..331
              myems-api/excelexporters/equipmentefficiency.py on lines 331..335
              myems-api/excelexporters/equipmentenergyitem.py on lines 319..323
              myems-api/excelexporters/shopfloorenergyitem.py on lines 339..343
              myems-api/excelexporters/spaceefficiency.py on lines 283..287
              myems-api/excelexporters/storeenergyitem.py on lines 339..343
              myems-api/excelexporters/tenantenergyitem.py on lines 339..343

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 76.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 6 locations. Consider refactoring.
              Open

              def group_by_category(category_list):
    category_dict = dict()
    for i, value in enumerate(category_list):
        if value not in category_dict.keys():
            category_dict[value] = list()
              Severity: Major
              Found in myems-api/excelexporters/spaceenergyitem.py and 5 other locations - About 3 hrs to fix
              myems-api/excelexporters/combinedequipmentenergyitem.py on lines 841..847
              myems-api/excelexporters/equipmentenergyitem.py on lines 779..785
              myems-api/excelexporters/shopfloorenergyitem.py on lines 800..806
              myems-api/excelexporters/storeenergyitem.py on lines 800..806
              myems-api/excelexporters/tenantenergyitem.py on lines 799..805

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 71.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status