Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-api/excelexporters/virtualmeterbatch.py

Summary

Maintainability
F
1 wk
Test Coverage

Function generate_excel has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def generate_excel(report, space_name, reporting_start_datetime_local, reporting_end_datetime_local, language):

    trans = get_translation(language)
    trans.install()
    _ = trans.gettext
Severity: Minor
Found in myems-api/excelexporters/virtualmeterbatch.py - About 1 hr to fix

    Function export has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def export(result, space_name, reporting_start_datetime_local, reporting_end_datetime_local, language):
    Severity: Minor
    Found in myems-api/excelexporters/virtualmeterbatch.py - About 35 mins to fix

      Function generate_excel has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def generate_excel(report, space_name, reporting_start_datetime_local, reporting_end_datetime_local, language):
      Severity: Minor
      Found in myems-api/excelexporters/virtualmeterbatch.py - About 35 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        Severity: Major
        Found in myems-api/excelexporters/virtualmeterbatch.py and 2 other locations - About 1 wk to fix
        myems-api/excelexporters/meterbatch.py on lines 0..121
        myems-api/excelexporters/offlinemeterbatch.py on lines 0..121

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 957.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status