Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-api/reports/microgridlist.py

Summary

Maintainability
F
1 wk
Test Coverage

Function on_get has a Cognitive Complexity of 126 (exceeds 5 allowed). Consider refactoring.
Open

    def on_get(req, resp):
        access_control(req)
        # Get user inforamtion
        user_uuid = str.strip(req.headers['USER-UUID'])
        cnx_user_db = mysql.connector.connect(**config.myems_user_db)
Severity: Minor
Found in myems-api/reports/microgridlist.py - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function on_get has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def on_get(req, resp):
        access_control(req)
        # Get user inforamtion
        user_uuid = str.strip(req.headers['USER-UUID'])
        cnx_user_db = mysql.connector.connect(**config.myems_user_db)
Severity: Minor
Found in myems-api/reports/microgridlist.py - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                            if analog_value_latest_dict.get(row_point[0]) is not None:
                            photovoltaic_power_point_value = analog_value_latest_dict.get(row_point[0])['actual_value']

                # get grid power point
                grid_power_point_value = None
    Severity: Major
    Found in myems-api/reports/microgridlist.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if analog_value_latest_dict.get(row_point[0]) is not None:
                            battery_soc_point_value = analog_value_latest_dict.get(row_point[0])['actual_value']
                            battery_power_point_value = analog_value_latest_dict.get(row_point[1])['actual_value']

                # get photovoltaic power point
      Severity: Major
      Found in myems-api/reports/microgridlist.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if digital_value_latest_dict.get(row_point[0]) is not None:
                            pcs_run_state_point_value = digital_value_latest_dict.get(row_point[0])['actual_value']

                # 0: 初始上电, Initial power on
                # 1: 待机, Standby
        Severity: Major
        Found in myems-api/reports/microgridlist.py - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if digital_value_latest_dict.get(row_point[0]) is not None:
                            battery_state_point_value = digital_value_latest_dict.get(row_point[0])['actual_value']

                # 0: 无电池, No Battery
                # 1: 故障, Fault
          Severity: Major
          Found in myems-api/reports/microgridlist.py - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if analog_value_latest_dict.get(row_point[0]) is not None:
                            load_power_point_value = analog_value_latest_dict.get(row_point[0])['actual_value']
            Severity: Major
            Found in myems-api/reports/microgridlist.py - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      if row_datetime[0] + timedelta(minutes=10) > datetime.utcnow():
                            is_online = True

                # get PCS run state point
                pcs_run_state_point_value = None
              Severity: Major
              Found in myems-api/reports/microgridlist.py - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                        if analog_value_latest_dict.get(row_point[0]) is not None:
                            grid_power_point_value = analog_value_latest_dict.get(row_point[0])['actual_value']

                # get load power point
                load_power_point_value = None
                Severity: Major
                Found in myems-api/reports/microgridlist.py - About 45 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                                  if is_online:
                    query = (" SELECT soc_point_id, power_point_id "
                             " FROM tbl_microgrids_batteries "
                             " WHERE microgrid_id = %s "
                             " LIMIT 1 ")
                  Severity: Major
                  Found in myems-api/reports/microgridlist.py and 1 other location - About 1 day to fix
                  myems-api/reports/energystoragepowerstationlist.py on lines 210..222

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 123.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 9 locations. Consider refactoring.
                  Open

                                  if is_online:
                    query = (" SELECT run_state_point_id "
                             " FROM tbl_microgrids_power_conversion_systems "
                             " WHERE microgrid_id = %s "
                             " LIMIT 1 ")
                  Severity: Major
                  Found in myems-api/reports/microgridlist.py and 8 other locations - About 6 hrs to fix
                  myems-api/reports/energystoragepowerstationlist.py on lines 122..133
                  myems-api/reports/energystoragepowerstationlist.py on lines 167..178
                  myems-api/reports/energystoragepowerstationlist.py on lines 225..236
                  myems-api/reports/energystoragepowerstationlist.py on lines 240..251
                  myems-api/reports/microgridlist.py on lines 156..166
                  myems-api/reports/microgridlist.py on lines 201..210
                  myems-api/reports/microgridlist.py on lines 214..223
                  myems-api/reports/microgridlist.py on lines 227..236

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 100.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 9 locations. Consider refactoring.
                  Open

                                  if is_online:
                    query = (" SELECT power_point_id "
                             " FROM tbl_microgrids_loads "
                             " WHERE microgrid_id = %s "
                             " LIMIT 1 ")
                  Severity: Major
                  Found in myems-api/reports/microgridlist.py and 8 other locations - About 6 hrs to fix
                  myems-api/reports/energystoragepowerstationlist.py on lines 122..133
                  myems-api/reports/energystoragepowerstationlist.py on lines 167..178
                  myems-api/reports/energystoragepowerstationlist.py on lines 225..236
                  myems-api/reports/energystoragepowerstationlist.py on lines 240..251
                  myems-api/reports/microgridlist.py on lines 118..127
                  myems-api/reports/microgridlist.py on lines 156..166
                  myems-api/reports/microgridlist.py on lines 201..210
                  myems-api/reports/microgridlist.py on lines 214..223

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 100.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 9 locations. Consider refactoring.
                  Open

                                  if is_online:
                    query = (" SELECT power_point_id "
                             " FROM tbl_microgrids_photovoltaics "
                             " WHERE microgrid_id = %s "
                             " LIMIT 1 ")
                  Severity: Major
                  Found in myems-api/reports/microgridlist.py and 8 other locations - About 6 hrs to fix
                  myems-api/reports/energystoragepowerstationlist.py on lines 122..133
                  myems-api/reports/energystoragepowerstationlist.py on lines 167..178
                  myems-api/reports/energystoragepowerstationlist.py on lines 225..236
                  myems-api/reports/energystoragepowerstationlist.py on lines 240..251
                  myems-api/reports/microgridlist.py on lines 118..127
                  myems-api/reports/microgridlist.py on lines 156..166
                  myems-api/reports/microgridlist.py on lines 214..223
                  myems-api/reports/microgridlist.py on lines 227..236

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 100.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 9 locations. Consider refactoring.
                  Open

                                  if is_online:
                    query = (" SELECT power_point_id "
                             " FROM tbl_microgrids_grids "
                             " WHERE microgrid_id = %s "
                             " LIMIT 1 ")
                  Severity: Major
                  Found in myems-api/reports/microgridlist.py and 8 other locations - About 6 hrs to fix
                  myems-api/reports/energystoragepowerstationlist.py on lines 122..133
                  myems-api/reports/energystoragepowerstationlist.py on lines 167..178
                  myems-api/reports/energystoragepowerstationlist.py on lines 225..236
                  myems-api/reports/energystoragepowerstationlist.py on lines 240..251
                  myems-api/reports/microgridlist.py on lines 118..127
                  myems-api/reports/microgridlist.py on lines 156..166
                  myems-api/reports/microgridlist.py on lines 201..210
                  myems-api/reports/microgridlist.py on lines 227..236

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 100.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 9 locations. Consider refactoring.
                  Open

                                  if is_online:
                    query = (" SELECT battery_state_point_id "
                             " FROM tbl_microgrids_batteries "
                             " WHERE microgrid_id = %s "
                             " LIMIT 1 ")
                  Severity: Major
                  Found in myems-api/reports/microgridlist.py and 8 other locations - About 6 hrs to fix
                  myems-api/reports/energystoragepowerstationlist.py on lines 122..133
                  myems-api/reports/energystoragepowerstationlist.py on lines 167..178
                  myems-api/reports/energystoragepowerstationlist.py on lines 225..236
                  myems-api/reports/energystoragepowerstationlist.py on lines 240..251
                  myems-api/reports/microgridlist.py on lines 118..127
                  myems-api/reports/microgridlist.py on lines 201..210
                  myems-api/reports/microgridlist.py on lines 214..223
                  myems-api/reports/microgridlist.py on lines 227..236

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 100.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 4 locations. Consider refactoring.
                  Open

                                  if row_datetime is not None and len(row_datetime) > 0:
                    if isinstance(row_datetime[0], datetime):
                        if row_datetime[0] + timedelta(minutes=10) > datetime.utcnow():
                            is_online = True
                  Severity: Major
                  Found in myems-api/reports/microgridlist.py and 3 other locations - About 4 hrs to fix
                  myems-api/reports/energystoragepowerstationdashboard.py on lines 116..119
                  myems-api/reports/energystoragepowerstationlist.py on lines 115..118
                  myems-api/reports/microgriddashboard.py on lines 183..186

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 77.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status