Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-api/test_mqtt.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function main has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def main():
    global g_mqtt_connected_flag
    mqc = None
    try:
        mqc = mqtt.Client(callback_api_version=mqtt.CallbackAPIVersion.VERSION2,
Severity: Minor
Found in myems-api/test_mqtt.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function on_mqtt_connect has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def on_mqtt_connect(client, userdata, connect_flags, reason_code, properties):
Severity: Minor
Found in myems-api/test_mqtt.py - About 35 mins to fix

    Function on_mqtt_disconnect has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def on_mqtt_disconnect(client, userdata, disconnect_flags, reason_code, properties):
    Severity: Minor
    Found in myems-api/test_mqtt.py - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status