Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-normalization/virtualpoint.py

Summary

Maintainability
F
1 wk
Test Coverage

Function worker has a Cognitive Complexity of 144 (exceeds 5 allowed). Consider refactoring.
Open

def worker(virtual_point):
    cnx_historical_db = None
    cursor_historical_db = None

    try:
Severity: Minor
Found in myems-normalization/virtualpoint.py - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function calculate has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

def calculate(logger):
    while True:
        # the outermost while loop to reconnect server if there is a connection error
        cnx_system_db = None
        cursor_system_db = None
Severity: Minor
Found in myems-normalization/virtualpoint.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File virtualpoint.py has 289 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import json
import random
import re
import time
from datetime import datetime
Severity: Minor
Found in myems-normalization/virtualpoint.py - About 2 hrs to fix

    Function worker has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def worker(virtual_point):
    cnx_historical_db = None
    cursor_historical_db = None

    try:
    Severity: Minor
    Found in myems-normalization/virtualpoint.py - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                              for row in rows:
                            point_values_dict[point['point_id']][row[0]] = row[1]
                elif point_object_type == 'ENERGY_VALUE':
      Severity: Major
      Found in myems-normalization/virtualpoint.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                for row in rows:
                            point_values_dict[point['point_id']][row[0]] = row[1]
                    else:
        Severity: Major
        Found in myems-normalization/virtualpoint.py - About 45 mins to fix

          Avoid too many return statements within this function.
          Open

                      return "Error in step 2.1 of virtual point worker for '" + virtual_point['name'] + "'"
          Severity: Major
          Found in myems-normalization/virtualpoint.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return
            Severity: Major
            Found in myems-normalization/virtualpoint.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return "Error in step 4.1 virtual point worker " + str(e) + " for '" + virtual_point['name'] + "'"
              Severity: Major
              Found in myems-normalization/virtualpoint.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return None
                Severity: Major
                Found in myems-normalization/virtualpoint.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                      return "variable point type should not be DIGITAL_VALUE " + " for '" + virtual_point['name'] + "'"
                  Severity: Major
                  Found in myems-normalization/virtualpoint.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return
                    Severity: Major
                    Found in myems-normalization/virtualpoint.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                          return "variable point type should not be None " + " for '" + virtual_point['name'] + "'"
                      Severity: Major
                      Found in myems-normalization/virtualpoint.py - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                return "Error in step 5.1 virtual point worker " + str(e) + " for '" + virtual_point['name'] + "'"
                        Severity: Major
                        Found in myems-normalization/virtualpoint.py - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                      return "Error in step 5.3 virtual point worker " + str(e) + " for '" + virtual_point['name'] + "'"
                          Severity: Major
                          Found in myems-normalization/virtualpoint.py - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                            return "Error in step 5.2 virtual point worker " + str(e) + " for '" + virtual_point['name'] + "'"
                            Severity: Major
                            Found in myems-normalization/virtualpoint.py - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                      return
                              Severity: Major
                              Found in myems-normalization/virtualpoint.py - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                        return "Error in step 2.2 of virtual point worker " + str(e) + " for '" + virtual_point['name'] + "'"
                                Severity: Major
                                Found in myems-normalization/virtualpoint.py - About 30 mins to fix

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                      try:
        cnx_historical_db = mysql.connector.connect(**config.myems_historical_db)
        cursor_historical_db = cnx_historical_db.cursor()
    except Exception as e:
        if cursor_historical_db:
                                  Severity: Major
                                  Found in myems-normalization/virtualpoint.py and 1 other location - About 5 hrs to fix
                                  myems-normalization/virtualmeter.py on lines 98..106

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 92.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                              for row in rows_virtual_points:
                meta_result = {"id": row[0],
                               "name": row[1],
                               "data_source_id": row[2],
                               "object_type": row[3],
                                  Severity: Major
                                  Found in myems-normalization/virtualpoint.py and 1 other location - About 4 hrs to fix
                                  myems-api/core/command.py on lines 43..52

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 78.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Identical blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                                      if rows is not None and len(rows) > 0:
                        point_values_dict[point['point_id']] = dict()
                        for row in rows:
                            point_values_dict[point['point_id']][row[0]] = row[1]
                                  Severity: Major
                                  Found in myems-normalization/virtualpoint.py and 1 other location - About 2 hrs to fix
                                  myems-normalization/virtualpoint.py on lines 245..248

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 61.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Identical blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                                      if rows is not None and len(rows) > 0:
                        point_values_dict[point['point_id']] = dict()
                        for row in rows:
                            point_values_dict[point['point_id']][row[0]] = row[1]
                                  Severity: Major
                                  Found in myems-normalization/virtualpoint.py and 1 other location - About 2 hrs to fix
                                  myems-normalization/virtualpoint.py on lines 256..259

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 61.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                      if end_datetime_utc <= start_datetime_utc:
        if cursor_historical_db:
            cursor_historical_db.close()
        if cnx_historical_db:
            cnx_historical_db.close()
                                  Severity: Major
                                  Found in myems-normalization/virtualpoint.py and 1 other location - About 2 hrs to fix
                                  myems-normalization/virtualmeter.py on lines 160..165

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 59.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 3 locations. Consider refactoring.
                                  Open

                                              if rows_virtual_points is None or len(rows_virtual_points) == 0:
                # sleep several minutes and continue the outer loop to reconnect the database
                time.sleep(60)
                continue
                                  Severity: Major
                                  Found in myems-normalization/virtualpoint.py and 2 other locations - About 45 mins to fix
                                  myems-normalization/meter.py on lines 49..52
                                  myems-normalization/virtualmeter.py on lines 45..48

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 35.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  There are no issues that match your filters.

                                  Category
                                  Status