Sign upLogin

N3Cr0N/HMVC

View on GitHub
Star
third_party/MX/Config.php

Summary

Maintainability
A
2 hrs
Test Coverage

Function load has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function load($file = '', $use_sections = false, $fail_gracefully = false, $_module = '')
    {
        if (in_array($file, $this->is_loaded, true)) {
            return $this->item($file);
        }
Severity: Minor
Found in third_party/MX/Config.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method load has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function load($file = '', $use_sections = false, $fail_gracefully = false, $_module = '')
    {
        if (in_array($file, $this->is_loaded, true)) {
            return $this->item($file);
        }
Severity: Minor
Found in third_party/MX/Config.php - About 1 hr to fix

    The method load has a boolean flag argument $use_sections, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function load($file = '', $use_sections = false, $fail_gracefully = false, $_module = '')
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method load has a boolean flag argument $fail_gracefully, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function load($file = '', $use_sections = false, $fail_gracefully = false, $_module = '')
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method load uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            [$path, $file] = Modules::find($file, $_module, 'config/');
        }
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid assigning values to variables in if clauses and the like (line '72', column '13').
    Open

        public function load($file = '', $use_sections = false, $fail_gracefully = false, $_module = '')
    {
        if (in_array($file, $this->is_loaded, true)) {
            return $this->item($file);
        }
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    The method load uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                    } else {
                    $current_config[$file] = $config;
                }
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class 'Modules' in method 'load'.
    Open

                [$path, $file] = Modules::find($file, $_module, 'config/');
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method load uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                } else {
                $current_config = array_merge($current_config, $config);
            }
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class 'Modules' in method 'load'.
    Open

            if ($config = Modules::load_file($file, $path, 'config')) {
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Modules' in method 'load'.
    Open

                list($path, $file) = Modules::find($file, $_module, 'config/');
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Reference to undeclared property \MX_Config->is_loaded
    Open

            if (in_array($file, $this->is_loaded, true)) {
    Severity: Minor
    Found in third_party/MX/Config.php by phan

    Reference to undeclared property \CI->router
    Open

            $_module or $_module = CI::$APP->router->fetch_module();
    Severity: Minor
    Found in third_party/MX/Config.php by phan

    Call to undeclared method \MX_Config::item
    Open

                return $this->item($file);
    Severity: Critical
    Found in third_party/MX/Config.php by phan

    Call to undeclared method \MX_Config::item
    Open

                return $this->item($file);
    Severity: Critical
    Found in third_party/MX/Config.php by phan

    Reference to undeclared class \CI_Config (Did you mean class \MX_Config)
    Open

                parent::load($file, $use_sections, $fail_gracefully);
    Severity: Critical
    Found in third_party/MX/Config.php by phan

    The phpdoc comment for @method cannot occur on a method
    Open

         * @method load
    Severity: Info
    Found in third_party/MX/Config.php by phan

    Saw unextractable annotation for comment '* @return [type] [description]'
    Open

         * @return [type]                   [description]
    Severity: Info
    Found in third_party/MX/Config.php by phan

    Reference to undeclared property \MX_Config->is_loaded
    Open

                $this->is_loaded[] = $file;
    Severity: Minor
    Found in third_party/MX/Config.php by phan

    Class extends undeclared class \CI_Config (Did you mean class \MX_Config)
    Open

    class MX_Config extends CI_Config
    Severity: Critical
    Found in third_party/MX/Config.php by phan

    Reference to undeclared property \MX_Config->config (Did you mean $config)
    Open

                $current_config =& $this->config;
    Severity: Minor
    Found in third_party/MX/Config.php by phan

    Saw unextractable annotation for comment '* @method load'
    Open

         * @method load
    Severity: Info
    Found in third_party/MX/Config.php by phan

    Call to undeclared method \MX_Config::item
    Open

                return $this->item($file);
    Severity: Critical
    Found in third_party/MX/Config.php by phan

    Each class must be in a namespace of at least one level (a top-level vendor name)
    Open

    class MX_Config extends CI_Config
    Severity: Minor
    Found in third_party/MX/Config.php by phpcodesniffer

    A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 36 and the first side effect is on line 1.
    Open

    <?php defined('BASEPATH') or exit('No direct script access allowed');
    Severity: Minor
    Found in third_party/MX/Config.php by phpcodesniffer

    The parameter $use_sections is not named in camelCase.
    Open

        public function load($file = '', $use_sections = false, $fail_gracefully = false, $_module = '')
    {
        if (in_array($file, $this->is_loaded, true)) {
            return $this->item($file);
        }
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    CamelCaseParameterName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name parameters.

    Example

    class ClassName {
    public function doSomething($user_name) {
    }
}

    Source

    The parameter $_module is not named in camelCase.
    Open

        public function load($file = '', $use_sections = false, $fail_gracefully = false, $_module = '')
    {
        if (in_array($file, $this->is_loaded, true)) {
            return $this->item($file);
        }
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    CamelCaseParameterName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name parameters.

    Example

    class ClassName {
    public function doSomething($user_name) {
    }
}

    Source

    The class MX_Config is not named in CamelCase.
    Open

    class MX_Config extends CI_Config
{
    /**
     * [load description]
     *
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    CamelCaseClassName

    Since: 0.2

    It is considered best practice to use the CamelCase notation to name classes.

    Example

    class class_name {
}

    Source

    The parameter $fail_gracefully is not named in camelCase.
    Open

        public function load($file = '', $use_sections = false, $fail_gracefully = false, $_module = '')
    {
        if (in_array($file, $this->is_loaded, true)) {
            return $this->item($file);
        }
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    CamelCaseParameterName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name parameters.

    Example

    class ClassName {
    public function doSomething($user_name) {
    }
}

    Source

    Class name "MX_Config" is not in camel caps format
    Open

    class MX_Config extends CI_Config
    Severity: Minor
    Found in third_party/MX/Config.php by phpcodesniffer

    The variable $current_config is not named in camelCase.
    Open

        public function load($file = '', $use_sections = false, $fail_gracefully = false, $_module = '')
    {
        if (in_array($file, $this->is_loaded, true)) {
            return $this->item($file);
        }
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $current_config is not named in camelCase.
    Open

        public function load($file = '', $use_sections = false, $fail_gracefully = false, $_module = '')
    {
        if (in_array($file, $this->is_loaded, true)) {
            return $this->item($file);
        }
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $_module is not named in camelCase.
    Open

        public function load($file = '', $use_sections = false, $fail_gracefully = false, $_module = '')
    {
        if (in_array($file, $this->is_loaded, true)) {
            return $this->item($file);
        }
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $_module is not named in camelCase.
    Open

        public function load($file = '', $use_sections = false, $fail_gracefully = false, $_module = '')
    {
        if (in_array($file, $this->is_loaded, true)) {
            return $this->item($file);
        }
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $fail_gracefully is not named in camelCase.
    Open

        public function load($file = '', $use_sections = false, $fail_gracefully = false, $_module = '')
    {
        if (in_array($file, $this->is_loaded, true)) {
            return $this->item($file);
        }
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $current_config is not named in camelCase.
    Open

        public function load($file = '', $use_sections = false, $fail_gracefully = false, $_module = '')
    {
        if (in_array($file, $this->is_loaded, true)) {
            return $this->item($file);
        }
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $_module is not named in camelCase.
    Open

        public function load($file = '', $use_sections = false, $fail_gracefully = false, $_module = '')
    {
        if (in_array($file, $this->is_loaded, true)) {
            return $this->item($file);
        }
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $current_config is not named in camelCase.
    Open

        public function load($file = '', $use_sections = false, $fail_gracefully = false, $_module = '')
    {
        if (in_array($file, $this->is_loaded, true)) {
            return $this->item($file);
        }
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $use_sections is not named in camelCase.
    Open

        public function load($file = '', $use_sections = false, $fail_gracefully = false, $_module = '')
    {
        if (in_array($file, $this->is_loaded, true)) {
            return $this->item($file);
        }
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $current_config is not named in camelCase.
    Open

        public function load($file = '', $use_sections = false, $fail_gracefully = false, $_module = '')
    {
        if (in_array($file, $this->is_loaded, true)) {
            return $this->item($file);
        }
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $use_sections is not named in camelCase.
    Open

        public function load($file = '', $use_sections = false, $fail_gracefully = false, $_module = '')
    {
        if (in_array($file, $this->is_loaded, true)) {
            return $this->item($file);
        }
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $_module is not named in camelCase.
    Open

        public function load($file = '', $use_sections = false, $fail_gracefully = false, $_module = '')
    {
        if (in_array($file, $this->is_loaded, true)) {
            return $this->item($file);
        }
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $current_config is not named in camelCase.
    Open

        public function load($file = '', $use_sections = false, $fail_gracefully = false, $_module = '')
    {
        if (in_array($file, $this->is_loaded, true)) {
            return $this->item($file);
        }
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $current_config is not named in camelCase.
    Open

        public function load($file = '', $use_sections = false, $fail_gracefully = false, $_module = '')
    {
        if (in_array($file, $this->is_loaded, true)) {
            return $this->item($file);
        }
    Severity: Minor
    Found in third_party/MX/Config.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    There are no issues that match your filters.

    Category
    Status