Sign upLogin

N3Cr0N/HMVC

View on GitHub
Star
third_party/MX/Lang.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function load has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function load($langfile, $lang = '', $return = false, $add_suffix = true, $alt_path = '', $_module = '')
    {
        if (is_array($langfile)) {
            foreach ($langfile as $_lang) {
                $this->load($_lang);
Severity: Minor
Found in third_party/MX/Lang.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method load has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function load($langfile, $lang = '', $return = false, $add_suffix = true, $alt_path = '', $_module = '')
    {
        if (is_array($langfile)) {
            foreach ($langfile as $_lang) {
                $this->load($_lang);
Severity: Minor
Found in third_party/MX/Lang.php - About 1 hr to fix

    Method load has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function load($langfile, $lang = '', $return = false, $add_suffix = true, $alt_path = '', $_module = '')
    Severity: Minor
    Found in third_party/MX/Lang.php - About 45 mins to fix

      Avoid too many return statements within this method.
      Open

              return $this->language;
      Severity: Major
      Found in third_party/MX/Lang.php - About 30 mins to fix

        The method load() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
        Open

            public function load($langfile, $lang = '', $return = false, $add_suffix = true, $alt_path = '', $_module = '')
    {
        if (is_array($langfile)) {
            foreach ($langfile as $_lang) {
                $this->load($_lang);
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        The method load has a boolean flag argument $return, which is a certain sign of a Single Responsibility Principle violation.
        Open

            public function load($langfile, $lang = '', $return = false, $add_suffix = true, $alt_path = '', $_module = '')
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        BooleanArgumentFlag

        Since: 1.4.0

        A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

        Example

        class Foo {
    public function bar($flag = true) {
    }
}

        Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

        The method load has a boolean flag argument $add_suffix, which is a certain sign of a Single Responsibility Principle violation.
        Open

            public function load($langfile, $lang = '', $return = false, $add_suffix = true, $alt_path = '', $_module = '')
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        BooleanArgumentFlag

        Since: 1.4.0

        A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

        Example

        class Foo {
    public function bar($flag = true) {
    }
}

        Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

        The method load uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                } else {
            [$path, $_langfile] = Modules::find($langfile.'_lang', $_module, 'language/'.$idiom.'/');
        }
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        Avoid using static access to class 'Modules' in method 'load'.
        Open

                    [$path, $_langfile] = Modules::find($langfile.'_lang', $_module, 'language/'.$idiom.'/');
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class 'Modules' in method 'load'.
        Open

                    if ($lang = Modules::load_file($_langfile, $path, 'lang')) {
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        The method load uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                } else {
            if ($lang = Modules::load_file($_langfile, $path, 'lang')) {
                if ($return) {
                    return $lang;
                }
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        Avoid assigning values to variables in if clauses and the like (line '84', column '17').
        Open

            public function load($langfile, $lang = '', $return = false, $add_suffix = true, $alt_path = '', $_module = '')
    {
        if (is_array($langfile)) {
            foreach ($langfile as $_lang) {
                $this->load($_lang);
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        Avoid assigning values to variables in if clauses and the like (line '80', column '17').
        Open

            public function load($langfile, $lang = '', $return = false, $add_suffix = true, $alt_path = '', $_module = '')
    {
        if (is_array($langfile)) {
            foreach ($langfile as $_lang) {
                $this->load($_lang);
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        Avoid using static access to class 'Modules' in method 'load'.
        Open

                    list($path, $_langfile) = Modules::find($langfile.'_lang', $_module, 'language/'.$idiom.'/');
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Saw unextractable annotation for comment '* @return [type] [description]'
        Open

             * @return [type]              [description]
        Severity: Info
        Found in third_party/MX/Lang.php by phan

        Reference to undeclared property \MX_Lang->language
        Open

                    return $this->language;
        Severity: Minor
        Found in third_party/MX/Lang.php by phan

        Reference to undeclared property \MX_Lang->language
        Open

                    return $this->language;
        Severity: Minor
        Found in third_party/MX/Lang.php by phan

        Reference to undeclared property \MX_Lang->language
        Open

                return $this->language;
        Severity: Minor
        Found in third_party/MX/Lang.php by phan

        The phpdoc comment for @method cannot occur on a method
        Open

             * @method load
        Severity: Info
        Found in third_party/MX/Lang.php by phan

        Reference to undeclared property \MX_Lang->is_loaded
        Open

                        $this->is_loaded[] = $langfile.'_lang'.EXT;
        Severity: Minor
        Found in third_party/MX/Lang.php by phan

        Reference to undeclared property \CI->router
        Open

                $_module or $_module = CI::$APP->router->fetch_module();
        Severity: Minor
        Found in third_party/MX/Lang.php by phan

        Reference to undeclared property \MX_Lang->language
        Open

                        $this->language = array_merge($this->language, $lang);
        Severity: Minor
        Found in third_party/MX/Lang.php by phan

        Saw unextractable annotation for comment '* @param [type] $langfile [description]'
        Open

             * @param  [type]  $langfile   [description]
        Severity: Info
        Found in third_party/MX/Lang.php by phan

        Class extends undeclared class \CI_Lang (Did you mean class \MX_Lang)
        Open

        class MX_Lang extends CI_Lang
        Severity: Critical
        Found in third_party/MX/Lang.php by phan

        Reference to undeclared property \CI->config
        Open

                $deft_lang = CI::$APP->config->item('language');
        Severity: Minor
        Found in third_party/MX/Lang.php by phan

        Reference to undeclared property \MX_Lang->is_loaded
        Open

                if (in_array($langfile.'_lang'.EXT, $this->is_loaded, true)) {
        Severity: Minor
        Found in third_party/MX/Lang.php by phan

        Saw unextractable annotation for comment '* @method load'
        Open

             * @method load
        Severity: Info
        Found in third_party/MX/Lang.php by phan

        Reference to undeclared class \CI_Lang (Did you mean class \MX_Lang)
        Open

                    if ($lang = parent::load($langfile, $lang, $return, $add_suffix, $alt_path)) {
        Severity: Critical
        Found in third_party/MX/Lang.php by phan

        Each class must be in a namespace of at least one level (a top-level vendor name)
        Open

        class MX_Lang extends CI_Lang
        Severity: Minor
        Found in third_party/MX/Lang.php by phpcodesniffer

        A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 36 and the first side effect is on line 1.
        Open

        <?php defined('BASEPATH') or exit('No direct script access allowed');
        Severity: Minor
        Found in third_party/MX/Lang.php by phpcodesniffer

        The parameter $add_suffix is not named in camelCase.
        Open

            public function load($langfile, $lang = '', $return = false, $add_suffix = true, $alt_path = '', $_module = '')
    {
        if (is_array($langfile)) {
            foreach ($langfile as $_lang) {
                $this->load($_lang);
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The class MX_Lang is not named in CamelCase.
        Open

        class MX_Lang extends CI_Lang
{
    /**
     * [load description]
     *
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        CamelCaseClassName

        Since: 0.2

        It is considered best practice to use the CamelCase notation to name classes.

        Example

        class class_name {
}

        Source

        The parameter $alt_path is not named in camelCase.
        Open

            public function load($langfile, $lang = '', $return = false, $add_suffix = true, $alt_path = '', $_module = '')
    {
        if (is_array($langfile)) {
            foreach ($langfile as $_lang) {
                $this->load($_lang);
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The parameter $_module is not named in camelCase.
        Open

            public function load($langfile, $lang = '', $return = false, $add_suffix = true, $alt_path = '', $_module = '')
    {
        if (is_array($langfile)) {
            foreach ($langfile as $_lang) {
                $this->load($_lang);
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        Class name "MX_Lang" is not in camel caps format
        Open

        class MX_Lang extends CI_Lang
        Severity: Minor
        Found in third_party/MX/Lang.php by phpcodesniffer

        The variable $_lang is not named in camelCase.
        Open

            public function load($langfile, $lang = '', $return = false, $add_suffix = true, $alt_path = '', $_module = '')
    {
        if (is_array($langfile)) {
            foreach ($langfile as $_lang) {
                $this->load($_lang);
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $_module is not named in camelCase.
        Open

            public function load($langfile, $lang = '', $return = false, $add_suffix = true, $alt_path = '', $_module = '')
    {
        if (is_array($langfile)) {
            foreach ($langfile as $_lang) {
                $this->load($_lang);
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $_module is not named in camelCase.
        Open

            public function load($langfile, $lang = '', $return = false, $add_suffix = true, $alt_path = '', $_module = '')
    {
        if (is_array($langfile)) {
            foreach ($langfile as $_lang) {
                $this->load($_lang);
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $add_suffix is not named in camelCase.
        Open

            public function load($langfile, $lang = '', $return = false, $add_suffix = true, $alt_path = '', $_module = '')
    {
        if (is_array($langfile)) {
            foreach ($langfile as $_lang) {
                $this->load($_lang);
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $alt_path is not named in camelCase.
        Open

            public function load($langfile, $lang = '', $return = false, $add_suffix = true, $alt_path = '', $_module = '')
    {
        if (is_array($langfile)) {
            foreach ($langfile as $_lang) {
                $this->load($_lang);
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $_langfile is not named in camelCase.
        Open

            public function load($langfile, $lang = '', $return = false, $add_suffix = true, $alt_path = '', $_module = '')
    {
        if (is_array($langfile)) {
            foreach ($langfile as $_lang) {
                $this->load($_lang);
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $deft_lang is not named in camelCase.
        Open

            public function load($langfile, $lang = '', $return = false, $add_suffix = true, $alt_path = '', $_module = '')
    {
        if (is_array($langfile)) {
            foreach ($langfile as $_lang) {
                $this->load($_lang);
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $_langfile is not named in camelCase.
        Open

            public function load($langfile, $lang = '', $return = false, $add_suffix = true, $alt_path = '', $_module = '')
    {
        if (is_array($langfile)) {
            foreach ($langfile as $_lang) {
                $this->load($_lang);
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $_lang is not named in camelCase.
        Open

            public function load($langfile, $lang = '', $return = false, $add_suffix = true, $alt_path = '', $_module = '')
    {
        if (is_array($langfile)) {
            foreach ($langfile as $_lang) {
                $this->load($_lang);
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $_langfile is not named in camelCase.
        Open

            public function load($langfile, $lang = '', $return = false, $add_suffix = true, $alt_path = '', $_module = '')
    {
        if (is_array($langfile)) {
            foreach ($langfile as $_lang) {
                $this->load($_lang);
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $deft_lang is not named in camelCase.
        Open

            public function load($langfile, $lang = '', $return = false, $add_suffix = true, $alt_path = '', $_module = '')
    {
        if (is_array($langfile)) {
            foreach ($langfile as $_lang) {
                $this->load($_lang);
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $_module is not named in camelCase.
        Open

            public function load($langfile, $lang = '', $return = false, $add_suffix = true, $alt_path = '', $_module = '')
    {
        if (is_array($langfile)) {
            foreach ($langfile as $_lang) {
                $this->load($_lang);
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        The variable $_module is not named in camelCase.
        Open

            public function load($langfile, $lang = '', $return = false, $add_suffix = true, $alt_path = '', $_module = '')
    {
        if (is_array($langfile)) {
            foreach ($langfile as $_lang) {
                $this->load($_lang);
        Severity: Minor
        Found in third_party/MX/Lang.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        There are no issues that match your filters.

        Category
        Status