NGUtech/lnd-adapter

View on GitHub

Showing 9 of 9 total issues

File LndService.php has 281 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php declare(strict_types=1);
/**
 * This file is part of the ngutech/lnd-adapter project.
 *
 * For the full copyright and license information, please view the LICENSE
Severity: Minor
Found in src/Service/LndService.php - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        protected function mapPaymentState(int $state): PaymentState
        {
            $paymentState = null;
            switch ($state) {
                case LnrpcPaymentStatus::UNKNOWN:
    Severity: Major
    Found in src/Service/LndService.php and 1 other location - About 1 hr to fix
    src/Service/LndService.php on lines 316..334

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 112.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        protected function mapInvoiceState(int $state): InvoiceState
        {
            $invoiceState = null;
            switch ($state) {
                case LnrpcInvoiceState::OPEN:
    Severity: Major
    Found in src/Service/LndService.php and 1 other location - About 1 hr to fix
    src/Service/LndService.php on lines 336..354

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 112.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method send has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function send(LightningPayment $payment): LightningPayment
        {
            Assertion::true($this->canSend($payment->getAmount()), 'Lnd service cannot send given amount.');
    
            /** @var LndGrpcClient $client */
    Severity: Minor
    Found in src/Service/LndService.php - About 1 hr to fix

      Method createInvoiceMessage has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function createInvoiceMessage(AMQPMessage $amqpMessage): LightningInvoiceMessageInterface
          {
              $invoice = json_decode($amqpMessage->body, true);
      
              switch ($invoice['state']) {
      Severity: Minor
      Found in src/Message/LndMessageWorker.php - About 1 hr to fix

        Method getPayment has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getPayment(Hash $preimageHash): ?LightningPayment
            {
                /** @var LndGrpcClient $client */
                $client = $this->connector->getConnection();
        
        
        Severity: Minor
        Found in src/Service/LndService.php - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function canSend(MoneyInterface $amount): bool
              {
                  return ($this->settings['send']['enabled'] ?? true)
                      && $amount->isGreaterThanOrEqual(
                          $this->convert(($this->settings['send']['minimum'] ?? LightningInvoice::AMOUNT_MIN))
          Severity: Minor
          Found in src/Service/LndService.php and 1 other location - About 50 mins to fix
          src/Service/LndService.php on lines 291..299

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 97.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function canRequest(MoneyInterface $amount): bool
              {
                  return ($this->settings['request']['enabled'] ?? true)
                      && $amount->isGreaterThanOrEqual(
                          $this->convert(($this->settings['request']['minimum'] ?? LightningInvoice::AMOUNT_MIN))
          Severity: Minor
          Found in src/Service/LndService.php and 1 other location - About 50 mins to fix
          src/Service/LndService.php on lines 301..309

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 97.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  Text $incomingChannelId,
                  Text $outgoingChannelId,
                  Text $incomingHtlcId,
                  Text $outgoingHtlcId,
                  Timestamp $timestamp,
          Severity: Minor
          Found in src/Message/LndHtlcMessageTrait.php - About 45 mins to fix
            Severity
            Category
            Status
            Source
            Language