Sign upLogin

NIT-dgp/cat-forum

View on GitHub
Star

Showing 145 of 145 total issues

Put empty method definitions on a single line.
Open

  def delete
  end
Severity: Minor
Found in app/controllers/replies_controller.rb by rubocop

This cop checks for the formatting of empty method definitions. By default it enforces empty method definitions to go on a single line (compact style), but it can be configured to enforce the end to go on its own line (expanded style).

Note: A method definition is not considered empty if it contains comments.

Example: EnforcedStyle: compact (default)

# bad
def foo(bar)
end

def self.foo(bar)
end

# good
def foo(bar); end

def foo(bar)
  # baz
end

def self.foo(bar); end

Example: EnforcedStyle: expanded

# bad
def foo(bar); end

def self.foo(bar); end

# good
def foo(bar)
end

def self.foo(bar)
end

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

    if current_user.present? && current_user.blocked?
Severity: Minor
Found in app/controllers/application_controller.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Put empty method definitions on a single line.
Open

  def list
  end
Severity: Minor
Found in app/controllers/flags_controller.rb by rubocop

This cop checks for the formatting of empty method definitions. By default it enforces empty method definitions to go on a single line (compact style), but it can be configured to enforce the end to go on its own line (expanded style).

Note: A method definition is not considered empty if it contains comments.

Example: EnforcedStyle: compact (default)

# bad
def foo(bar)
end

def self.foo(bar)
end

# good
def foo(bar); end

def foo(bar)
  # baz
end

def self.foo(bar); end

Example: EnforcedStyle: expanded

# bad
def foo(bar); end

def self.foo(bar); end

# good
def foo(bar)
end

def self.foo(bar)
end

Use the return of the conditional for variable assignment and comparison.
Open

    if params[:tag]
      @new_threads = NewThread.tagged_with(params[:tag])
    else
      @new_threads = NewThread.paginate(page: params[:page], per_page: 10)
                              .order('id DESC')
Severity: Minor
Found in app/controllers/new_threads_controller.rb by rubocop

Favor a normal if-statement over a modifier clause in a multiline statement.
Open

      set_flash_message(
        :notice,
        :success,
        kind: 'Facebook'
      ) if is_navigational_format?
Severity: Minor
Found in app/controllers/users/omniauth_callbacks_controller.rb by rubocop

Checks for uses of if/unless modifiers with multiple-lines bodies.

Example:

# bad
{
  result: 'this should not happen'
} unless cond

# good
{ result: 'ok' } if cond
Severity
Category
Status
Source
Language